On Mon, 2022-08-15 at 22:24 -0400, Dmitry Goncharov wrote:
> make-4.3 lets the user control (via presence or absence of +) if a
> particular sub-process should participate in the jobserver business.
> The current master, on the other hand, is "everyting is up to the
> sub-make".
> E.g.
> all:; make
On Thu, Jul 21, 2022 at 10:23 AM Paul Smith wrote:
> Instead, any sub-process can look at MAKEFLAGS, see the value of
jobserver-auth, find the name of the pipe, open it, and start to use
it. If the sub-process doesn't know anything about MAKEFLAGS, it will
never know that the jobserver is relevan
On Thu, 2022-07-21 at 10:23 -0400, Paul Smith wrote:
> 6) There is another issue with setting blocking / non-blocking read
> on the jobserver fds. I can't remember if there's a Savannah bug or
> not about this, but changing the blocking/non-blocking status on a fd
> is not local to a given process
On Wed, 2022-07-20 at 20:33 -0400, Dmitry Goncharov wrote:
> if we take a step back, what is the problem? The problem is the
> presence of jobserver-auth in MAKEFLAGS in the non recursive case.
> You already implemented a solution which sets jobserver-auth=-2,-2.
> Another option is to remove jobse
On Wed, Jul 20, 2022 at 9:33 AM Paul Smith wrote:
> There are so many ways this can bite people. The last thing
> GNU make needs IMO is more obscure subtleties. For example if someone
> writes this:
>
> NRMAKE = $(MAKE)
>
> recurse:
> MAKEFLAGS=$(MAKEFLAGS) $(NRMAKE)
>
> it will br
On Wed, 2022-07-20 at 00:47 -0400, Dmitry Goncharov wrote:
> On Tue, Jul 19, 2022 at 6:13 PM Paul Smith wrote:
> > There are at least two Savannah bugs about this very subtle and
> > annoying issue.
>
> Do you mean that jobserver-auth is present in the child env, even
> though the fds are closed?
On Tue, Jul 19, 2022 at 6:13 PM Paul Smith wrote:
> There are at least two Savannah bugs about this very subtle and
> annoying issue.
Do you mean that jobserver-auth is present in the child env, even
though the fds are closed?
> So the first thing I tried to do was to add another setting of the
So after the changes I made to allow exporting environment variables to
subshells, I wanted to work on the issues we have with jobserver pipes
getting confused when you run make in unexpected ways such as inside a
shell function or in a recipe line which is not considered a submake.
There are at l
