Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Tue, 10 Sep 2019 12:35:18 -0400 > > > Btw, I see you added support for dirent.d_type for dirent functions > > emulation when compiling with MSVC, but I don't think Make uses this > > anywhere, except when building with glibc. In particular, the

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Tue, 2019-09-10 at 19:17 +0300, Eli Zaretskii wrote: > Btw, I see you added support for dirent.d_type for dirent functions > emulation when compiling with MSVC, but I don't think Make uses this > anywhere, except when building with glibc. In particular, the > HAVE_STRUCT_DIRENT_D_TYPE macro

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Cc: dgoncha...@users.sf.net, bug-make@gnu.org > Date: Tue, 10 Sep 2019 11:47:35 -0400 > > On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote: > > > From: Paul Smith > > > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > > > > > I plan to make a new release candidate this

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > > > I plan to make a new release candidate this week. > > Did you have a chance to review the patch I proposed in >

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > I plan to make a new release candidate this week. Did you have a chance to review the patch I proposed in https://lists.gnu.org/archive/html/bug-make/2019-08/msg00106.html? I'd like to install it. Also, regarding SV 56449: are you

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Mon, 2019-09-09 at 22:30 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > ar add output is system dependent. Thanks Dmitry; I had already made basically that same change. See the latest Git master (pushed this morning). I plan to make a new release candidate this

patch to fix features/archives test 10 on sunos

2019-09-09 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. ar add output is system dependent. This makes features/archives test 10 fail on sunos. This patch uses the output of `ar rv` rather than a hardcoded string. linux $ ar rv libxx.a 1234567890123456b a - 1234567890123456b sunos $ ar rv libxx.a 1234567890123456b a - 1234567890123456b