Re: [Bug-tar] tar-1.25: test 39 fails on FreeBSD

2010-11-25 Thread Paul Eggert
On 11/23/2010 07:26 PM, Bruno Haible wrote: > Additionally, on NetBSD, the errno value EFTYPE should be turned into ELOOP > in the same way. And possibly also ENOTSUP on OSF/1. > > >

Re: [Bug-tar] tar-1.25: test 39 fails on FreeBSD

2010-11-23 Thread Paul Eggert
On 11/23/10 08:16, Joerg Schilling wrote: > The POSIX standard requires errno to be ELOOP in this case. Quite right. And I see that this incompatibility is not fixed in FreeBSD 9-current, at least according to the published manual page. Christian, would you please report this to the FreeBSD fol

Re: [Bug-tar] tar-1.25: test 39 fails on FreeBSD

2010-11-23 Thread Joerg Schilling
Christian Weisgerber wrote: > > maybe_recoverable should execute this code: > > > > if (*interdir_made) > > return RECOVER_NO; > > > > switch (e) > > { > > case ELOOP: > > The problem turns out to be very straightforward: On FreeBSD, the > open() call returns -1 with e

Re: [Bug-tar] tar-1.25: test 39 fails on FreeBSD

2010-11-23 Thread Christian Weisgerber
Paul Eggert: > If I understand things correctly, src/extract.c's extract_file > is invoking open_output_file, which returns -1 with errno==ELOOP. > extract_file then should invoke: > >maybe_recoverable ("./file1", true, &interdir_made) > > maybe_recoverable should execute this code: > >

Re: [Bug-tar] tar-1.25: test 39 fails on FreeBSD

2010-11-22 Thread Paul Eggert
On 11/22/10 13:05, Christian Weisgerber wrote: > On FreeBSD 7.3, test #39 "extract over symlinks" fails. Specifically, > it's this snippet of extrac13 > > ln -s target1 dst2/file1 > echo target1 >dst2/target1 > tar --overwrite -xf archive.tar -C dst2 --warning=no-timestamp > > that errors

[Bug-tar] tar-1.25: test 39 fails on FreeBSD

2010-11-22 Thread Christian Weisgerber
On FreeBSD 7.3, test #39 "extract over symlinks" fails. Specifically, it's this snippet of extrac13 ln -s target1 dst2/file1 echo target1 >dst2/target1 tar --overwrite -xf archive.tar -C dst2 --warning=no-timestamp that errors out: tar: ./file1: Cannot open: Too many links ktrace shows