Re: Patch: fix various issues found by static analysis

On 10/16/24 10:48 PM, Gavin Smith wrote: On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote: Hi, Please review proposed fixes of issues found by static analysis of texinfo-7.1 in the attached patch and consider applying them. Thanks for sending all of these. I have

Re: Patch: fix various issues found by static analysis [LONG_MAX]

On 10/15/24 1:06 PM, Gavin Smith wrote: On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote: Hi, Please review proposed fixes of issues found by static analysis of texinfo-7.1 in the attached patch and consider applying them. Thanks for sending them, I would like to take

Patch: fix various issues found by static analysis

arked line seems suspicious - I guess there's a typo and 'f2' should be tested instead of 'f' in the condition. But this is _not_ changed in proposed patch, just a heads-up here. Best regards VitaFrom e807d95e3422b1b45b6ec9d3b6b0f559c136fa5f Mon Sep 17 00:00:00 2001 From: Vitezs

Issues found by static analysis (patch)

Hello, Patch fixing issues found by static analysis of the code is attached. (mostly memory leaks). I tried to be verbose in commit messages and usually the problem is pretty much obvious. Please review the patch and consider to apply it. Best regards, Vitezslav Crhonek -- Vitezslav Crhonek

Re: ShellCheck reports error in run_parser_all.sh (patch)

On 2/16/21 5:00 PM, Gavin Smith wrote: > On Tue, Feb 16, 2021 at 10:30:44AM +0100, Vitezslav Crhonek wrote: >> Hi, >> >> ShellCheck reports error [1] in tp/tests/run_parser_all.sh script. >> 'continue' is used there to exit a function. >> >> I d

ShellCheck reports error in run_parser_all.sh (patch)

lly reported by yeah_wang at [2]. Best regards Vita [1] https://github.com/koalaman/shellcheck/wiki/SC2104 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1921666 -- Vitezslav Crhonek Software Engineer Red Hat diff --git a/tp/tests/run_parser_all.sh b/tp/tests/run_parser_all.sh index f424bbb421..80

Memory leak in info man page fall back

e memory (line 298). Steps to reproduce: 1) run '$ valgrind --leak-check=full fetchmail' (or any other argument, which doesn't have info page and fall backs to man page) 2) quit info and see valgrind summary Attached patch resolves the issue. Best regards, Vita -

Memory leak in info completion

f' key ('Follow xref:' appears in echo area) 3) write 's?' and hit ENTER ('[No completions]' appears in echo area) 4) leave info (hit ESC, ESC and 'q' key) and see valgrind summary If you hit ENTER more often in step number three, the amount of leaked me

Re: 'info mount' doesn't follow ref

On 07/09/2017 08:55 PM, Gavin Smith wrote: > On Mon, Jul 03, 2017 at 03:17:33PM +0200, Vitezslav Crhonek wrote: >> The culprit seems to be info_find_subfile() function in nodes.c, >> more precisely this line: >> /* Check if fullpath starts the name of the

'info mount' doesn't follow ref

y isn't present there and following the reference fails in the end. Otherwise correct file "/usr/share/info/libc.info-1.gz" is found and the node is displayed. Best regards, Vita -- Vitezslav Crhonek Software Engineer Red Hat signature.asc Description: OpenPGP digital signature

Re: problem with texi2dvi from texinfo 6.1

2d:/home/vcrhonek/t2d/.:' /usr/bin/texi2dvi: Cycle 1 for ././test1.tex /usr/bin/texi2dvi: /usr/bin/texi2dvi: Running latex --file-line-error '\input' '././test1.tex' ... /usr/bin/texi2dvi: Removing /home/vcrhonek/t2d/test1.t2d $ echo $? 1 test1-log.txt attached. Please l

[bug #44099] info segfaults on xterm when window height is very small

Follow-up Comment #2, bug #44099 (project texinfo): Thanks for your reply. I can confirm that it works fine in latest development revision (6074). There's just minor issue - when compiling with "-Werror=format-security", the build fails: info.c: In function 'main': info.c:908:9: error: format no

[bug #44099] info segfaults on xterm when window height is very small

URL: Summary: info segfaults on xterm when window height is very small Project: texinfo - GNU documentation system Submitted by: vcrhonek Submitted on: Tue 27 Jan 2015 12:34:37 PM GMT

Re: 'info non_existing_info_page -o -' (or 'info non_existing_info_page -o somefile') segfaults

On 01/15/2014 04:30 PM, Sergey Poznyakoff wrote: > Vitezslav Crhonek ha escrit: > >> # info non_existing_info_page -o >> >> or >> >> # info non_existing_info_page -o somefile >> >> ends with segmentation fault with latest upstream release >&g

'info non_existing_info_page -o -' (or 'info non_existing_info_page -o somefile') segfaults

behaving like in the previous versions. The closest one is attached (but it produces also blank space and does not terminate the last line...). Best regards, Vitezslav Crhonek diff -up texinfo-5.2/info/info.c.orig texinfo-5.2/info/info.c --- texinfo-5.2/info/info.c.orig2013-08-22 19:54:06.00

Using index in help can crash info

Hi, when indexing help page in info (after another index on another page was already built), segmentation fault occurs. Steps to reproduce: a) $ info info b) hit "i" and then hit "RETURN" (you'll see index window) c) hit "h" (you'll see help window) d) hit "i" (you'll see Segmentation fault)

Re: Segfault when resizing the terminal

all to big. But when repeating this several times, text appears again.) I'll add this patch to F-7, F-8 and Fedora devel, thanks! Best regards, Vitezslav Crhonek signature.asc Description: OpenPGP digital signature

Segfault when resizing the terminal

s a time and is interested, I think problem is somewhere in window.c functions, where window->height is set, but I didn't find out where yet and don't know, when I'll spare some time to look at it in detail again... Best regards, Vitezslav Crhonek --- texinfo-4.11/info/displa