[Bug-wget] [PATCH] remove 'const' issues from ftp.c

2012-04-12 Thread Tim Ruehsen
Removed warnings "... discards 'const' qualifier from pointer target type" from ftp.c. Since my ChangeLog is somehow out of sync, please add this manually: 2012-04-12 Tim Ruehsen * ftp.c: removed discarding 'const' warnings Tim === modified file 'src/ftp.c' --- src/ftp.c 2011-11-04

Re: [Bug-wget] [PATCH] Some potential memory leaks in wget-1.3

2012-04-12 Thread Tim Ruehsen
Thanks again, Zhenbo. there where several leaks in http.c and one in ftp-basic.c (patches attached). retr.c seems to be ok (false positives). Also, init.c/home_dir() has to be rewritten (some stupids, e.g. MSDOS branch wouldn't compile.). I'll do that later. Tim Am Wednesday 11 April 2012 schr

[Bug-wget] [PATCH] rewrote home_dir() to fix memleak

2012-04-12 Thread Tim Ruehsen
Fixed a memleak found by Zhenbo Xu, reportted on 11.04.2012 to bug-wget. 2012-04-12 Tim Ruehsen * rewrote home_dir() to fix memleak, removed need for freeing home === modified file 'src/init.c' --- src/init.c 2012-03-08 09:00:51 + +++ src/init.c 2012-04-12 11:17:21 + @@ -389,6

[Bug-wget] [PATCH] fix warning and possible invalid free

2012-04-12 Thread TeeRasen
In main.c we have opt.progress_type = "dot"; gcc warns about that... main.c:1302:29: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] ...and is right since opt.progress_type is malloced/freed somewhere else: init.c/cmd_spec_progress

Re: [Bug-wget] [PATCH] rewrote home_dir() to fix memleak

2012-04-12 Thread Giuseppe Scrivano
Tim Ruehsen writes: > Fixed a memleak found by Zhenbo Xu, reportted on 11.04.2012 to bug-wget. > > 2012-04-12 Tim Ruehsen > > * rewrote home_dir() to fix memleak, removed need for freeing home what is exactly the problem with the current code? Thanks, Giuseppe

Re: [Bug-wget] [PATCH] rewrote home_dir() to fix memleak

2012-04-12 Thread Tim Ruehsen
Am Thursday 12 April 2012 schrieb Giuseppe Scrivano: > Tim Ruehsen writes: > > Fixed a memleak found by Zhenbo Xu, reportted on 11.04.2012 to bug-wget. > > > > 2012-04-12 Tim Ruehsen > > > > * rewrote home_dir() to fix memleak, removed need for freeing home > > what is exactly the probl

Re: [Bug-wget] [PATCH] rewrote home_dir() to fix memleak

2012-04-12 Thread Tim Ruehsen
Sorry to say this, there is a little bug in my changes: if (!p || !asprintf(&home,"%.*s", (int)(p - path), path)) return NULL; should be if (!p || asprintf(&home,"%.*s", (int)(p - path), path) == -1) return NULL; What about the 'remove trailing path seperator' code. I think i

[Bug-wget] [PATCH] memory leak in warc.c

2012-04-12 Thread Tim Ruehsen
Freeing the lineptr in warc.c/warc_load_cdx_dedup_file(), allocated by getline(). Tim === modified file 'src/warc.c' --- src/warc.c 2012-04-02 11:26:23 + +++ src/warc.c 2012-04-12 13:19:51 + @@ -956,6 +956,7 @@ nrecords); } + free (lineptr); fclos

[Bug-wget] Wget 1.13.4 on True64 OSF1 Beta

2012-04-12 Thread Gunaji, Siddesh (TCS)
Hello Team, I have installed the above version on our True 64 and I get following error tnax02> wget ftp://gnjilux.cc.fer.hr/welcome.msg --2012-04-12 09:35:31-- ftp://gnjilux.cc.fer.hr/welcome.msg => `welcome.msg' Resolving gnjilux.cc.fer.hr... 161.53.74.67 Connecting to gnjilux.c

[Bug-wget] --trust-server-names

2012-04-12 Thread David H. Lipman
Is it possible to add; --trust-server-names To the WGETRC file ? -- Dave Multi-AV Scanning Tool - http://multi-av.thespykiller.co.uk http://www.pctipp.ch/downloads/dl/35905.asp

Re: [Bug-wget] Wget 1.13.4 on True64 OSF1 Beta

2012-04-12 Thread Tim Ruehsen
Hi, can you try wget ftp://161.53.74.67 and some other URLs ? Same error ? To the coders: The error seems to come from socket(). Since ipv6 is disabled, AF_INET is the only possibility being in sa->sa_family. Should work, though. Could you post the output from 'man socket' ? Tim Am Thursday 1

Re: [Bug-wget] --trust-server-names

2012-04-12 Thread David H. Lipman
From: "David H. Lipman" Is it possible to add; --trust-server-names To the WGETRC file ? Nevermind. It wasn't in the version of my documentation but the following worked... trust-server-names = on -- Dave Multi-AV Scanning Tool - http://multi-av.thespykiller.co.uk http://www.pctipp.ch

Re: [Bug-wget] [PATCH] fix warning and possible invalid free

2012-04-12 Thread Micah Cowan
On 04/12/2012 01:23 AM, TeeRasen wrote: > In main.c we have > opt.progress_type = "dot"; In C, a string literal is of type char[] (which automatically transforms to char*), not const char[] or const char* (even though one must still not modify it. You're either compiling with C++ (a bad

Re: [Bug-wget] --trust-server-names

2012-04-12 Thread Ángel González
On 12/04/12 18:23, David H. Lipman wrote: > From: "David H. Lipman" > >> Is it possible to add; --trust-server-names >> To the WGETRC file ? >> > > Nevermind. It wasn't in the version of my documentation but the > following worked... > > trust-server-names = on You're aware of the risks of downl

Re: [Bug-wget] [PATCH] memory leak in warc.c

2012-04-12 Thread Ángel González
12/04/12 15:25, Tim Ruehsen wrote: > Freeing the lineptr in warc.c/warc_load_cdx_dedup_file(), allocated by > getline(). > > Tim Well found. The patch is Ok.

Re: [Bug-wget] --trust-server-names

2012-04-12 Thread David H. Lipman
From: "Ángel González" > On 12/04/12 18:23, David H. Lipman wrote: >> From: "David H. Lipman" >> >>> Is it possible to add; --trust-server-names >>> To the WGETRC file ? >>> >> >> Nevermind. It wasn't in the version of my documentation but the >> following worked... >> >> trust-server-names =

Re: [Bug-wget] --trust-server-names

2012-04-12 Thread Micah Cowan
On 04/12/2012 03:13 PM, David H. Lipman wrote: > From: "Ángel González" > >> On 12/04/12 18:23, David H. Lipman wrote: >>> From: "David H. Lipman" >>> Is it possible to add; --trust-server-names To the WGETRC file ? >>> >>> Nevermind. It wasn't in the version of my documentation

Re: [Bug-wget] --trust-server-names

2012-04-12 Thread David H. Lipman
From: "Micah Cowan" On 04/12/2012 03:13 PM, David H. Lipman wrote: From: "Ángel González" On 12/04/12 18:23, David H. Lipman wrote: From: "David H. Lipman" Is it possible to add; --trust-server-names To the WGETRC file ? Nevermind. It wasn't in the version of my documentation but th