Hi,
I noticed some problems relating to URLs like
http://www.example.com/path/to/filename.zip?arg1=somestring&arg2=anotherstring&;...
Wget doesn't strip the ? and following characters from the filename when
creating local files. As far as I can tell it doesn't have an option to do
that. This c
In comment to `request_new` was that it *always* must be followed by
`request_set_method`. I changed code to combine these functionality into
single function. Please, review.
>From 4e2a98f3746400846486de0e57b4d68e654622f3 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov
Date: Wed, 8 May 2013 18:10:5
>
> In comment to `request_new` was that it *always* must be followed by
> `request_set_method`. I changed code to combine these functionality into
> single function. Please, review.
>
Looks good to me.
Just one thing though, the method string is now converted to uppercase
through cmd_string_upper
Darshit Shah writes:
>
> We suspend the post data only when we receive a 307, or do you
> mean we
> shouldn't suspend in this case too?
>
> It's the other way round. A 307 response code is used when the server
> wishes to explicitly ask the client to not suspend. And that is
Darshit Shah writes:
>>
>> In comment to `request_new` was that it *always* must be followed by
>> `request_set_method`. I changed code to combine these functionality into
>> single function. Please, review.
>
> Looks good to me.
> Just one thing though, the method string is now converted to upp
Hi,
Am Mittwoch, 8. Mai 2013 schrieb Mark:
> Hi,
>
> I noticed some problems relating to URLs like
>
http://www.example.com/path/to/filename.zip?arg1=somestring&arg2=anotherstring&;...
>
> Wget doesn't strip the ? and following characters from the filename when
> creating local files. As far
>> Giuseppe pushed a patch with that change a few days ago.. Please rebase it
>> onto the master branch.
> Good idea, but as Darshit said, please rebase it onto the master
> branch. I will be offline for the next few days, I will review it
> when I am back.
Here it is: >From 6b35e408194bb197053
Dmitry Bogatov writes:
> - meth = opt.method;
> + {
> +char *q;
> +for (q = opt.method; *q; ++q)
> + *q = c_toupper (*q);
> +meth = opt.method;
> + }
this code should go. Now you can assume opt.method is already uppercase
as this is already enforc
> > We currently suspend any method if the response code is a non 307
> > redirect. That I believe is wrong. We should only be suspending the
> > POST method and not others.
>
> It sounds good, but we must be careful also with 303.
>
> Do you agree that the matrix for the method to use on the next
Giuseppe Scrivano writes:
> Now you can assume opt.method is already uppercase as this is already
> enforced in cmd_string_uppercase (init.c).
>
> Please take a look at the commit 550457.
My bad. Here is fixed version.
>From dfb31c06db0ea98dfc8f08c20c8ec1de1f7ed0ca Mon Sep 17 00:00:00 2001
From
10 matches
Mail list logo
