Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

2014-06-12 Thread Tim Rühsen
Am Mittwoch, 11. Juni 2014, 18:57:13 schrieb Darshit Shah: > On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote: > > Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah: > >> I'm facing an issue with the patch I submitted for libpsl and would be > >> glad if someone could help me. > >> > >> Th

Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

2014-06-12 Thread Giuseppe Scrivano
Darshit Shah writes: > On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote: >> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah: >>> I'm facing an issue with the patch I submitted for libpsl and would be >>> glad if someone could help me. >>> >>> The configure.ac file does not work as expec

Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

2014-06-12 Thread Darshit Shah
Yes, the configure statements given by Tim work. I found out that the issue on machine was caching of configure values. Deleting the configure cache fixed the issue. I also agree with Giuseppe's point about not using the autoconf variables. Let's fix the rest of them too. Tim's patch however

Re: [Bug-wget] Issue in cookie path checking

2014-06-12 Thread yasuhisa . ishikawa
Hi Darshit, Sorry to be late. I have never used git so it takes long for me to learn how to generate path using git. I’m not sure I have done it well. If there are something wrong with this attachment, please correct. 0001-2014-06-12-Yasuhisa-Ishikawa-yasuhisa.ishikawa-kuman.patch Descripti

Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

2014-06-12 Thread Tim Rühsen
Am Donnerstag, 12. Juni 2014, 07:16:13 schrieb Darshit Shah: > Yes, the configure statements given by Tim work. I found out that the issue > on machine was caching of configure values. Deleting the configure cache > fixed the issue. > > I also agree with Giuseppe's point about not using the autoco

Re: [Bug-wget] [PATCH 02/14] Do not use exit() with a magic number

2014-06-12 Thread Gisle Vanem
wrote: ... diff --git a/src/mswindows.c b/src/mswindows.c index 179773e..c0d9be6 100644 --- a/src/mswindows.c +++ b/src/mswindows.c @@ -308,7 +308,7 @@ cleanup: /* We're the parent. If all is well, terminate. */ if (rv) -exit (0); +exit (WGET_EXIT_SUCCESS); This breaks compila

Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

2014-06-12 Thread Tim Rühsen
Am Donnerstag, 12. Juni 2014, 13:24:02 schrieb Giuseppe Scrivano: > Darshit Shah writes: > > On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote: > >> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah: > >>> I'm facing an issue with the patch I submitted for libpsl and would be > >>> glad if

Re: [Bug-wget] [PATCH 10/14] Do not depend on always defined macros

2014-06-12 Thread Steven M. Schweda
From: Giuseppe Scrivano > ops, thanks to have catched it. I've fixed it in my local copy, this is > how it looks now: > > diff --git a/vms/vms.h b/vms/vms.h > index d65aeda..6053df1 100644 > --- a/vms/vms.h > +++ b/vms/vms.h > @@ -49,16 +49,6 @@ int utime( const char *path, const struct utimbuf

Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

2014-06-12 Thread Darshit Shah
That patch works perfectly for me. Maybe we should update the rest of the file along the same lines? It would help to reduce some fragmentation. On Thu, Jun 12, 2014 at 8:53 PM, Tim Rühsen wrote: > Am Donnerstag, 12. Juni 2014, 13:24:02 schrieb Giuseppe Scrivano: >> Darshit Shah writes: >> > On

Re: [Bug-wget] [PATCH 02/14] Do not use exit() with a magic number

2014-06-12 Thread Giuseppe Scrivano
"Gisle Vanem" writes: > wrote: > > ... > >> diff --git a/src/mswindows.c b/src/mswindows.c >> index 179773e..c0d9be6 100644 >> --- a/src/mswindows.c >> +++ b/src/mswindows.c >> @@ -308,7 +308,7 @@ cleanup: >> >> /* We're the parent. If all is well, terminate. */ >> if (rv) >> -exit (0)

Re: [Bug-wget] [PATCH 10/14] Do not depend on always defined macros

2014-06-12 Thread Darshit Shah
On Thu, Jun 12, 2014 at 8:59 PM, Steven M. Schweda wrote: > From: Giuseppe Scrivano > >> ops, thanks to have catched it. I've fixed it in my local copy, this is >> how it looks now: >> >> diff --git a/vms/vms.h b/vms/vms.h >> index d65aeda..6053df1 100644 >> --- a/vms/vms.h >> +++ b/vms/vms.h >>