[Bug-wget] [Bug-Wget] Misc. patches

2014-07-05 Thread Darshit Shah
Hi, I've attached 3 patches to this mail. The first one eliminates some of the error codes in Wget as a first step to cleaning up the error reporting method. The second is siimply fixing indentation issues. The third updates our usage of libpsl according to the latest release version and

Re: [Bug-wget] [Bug-Wget] Misc. patches

2014-07-05 Thread Giuseppe Scrivano
Hi Darshit, few comments below: Darshit Shah dar...@gmail.com writes: Hi, I've attached 3 patches to this mail. The first one eliminates some of the error codes in Wget as a first step to cleaning up the error reporting method. The second is siimply fixing indentation issues. The third

Re: [Bug-wget] [Bug-Wget] Misc. patches

2014-07-05 Thread Giuseppe Scrivano
Darshit Shah dar...@gmail.com writes: static bool check_domain_match (const char *cookie_domain, const char *host) @@ -509,6 +519,7 @@ check_domain_match (const char *cookie_domain, const char *host) #ifdef HAVE_LIBPSL DEBUGP ((cdm: 1)); + char * cookie_domain_lower, * host_lower;

Re: [Bug-wget] [Bug-Wget] Misc. patches

2014-07-05 Thread Darshit Shah
I just pushed a slightly amended patch. However, here is what I propose: diff --git a/src/cookies.c b/src/cookies.c index 76301ac..3139671 100644 --- a/src/cookies.c +++ b/src/cookies.c @@ -549,6 +549,9 @@ check_domain_match (const char *cookie_domain, const char *host) return true ?