[Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-30 Thread Giuseppe Scrivano
Tim Rühsen writes: > as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with > GnuTLS does not show any problems. and this remembers us that maintaining two different backends is not a good idea. I am for just moving to GNU TLS and forget about OpenSSL. It is a bit drastic b

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-30 Thread Tim Ruehsen
On Thursday 30 October 2014 10:55:49 Daniel Stenberg wrote: > On Thu, 30 Oct 2014, Tim Ruehsen wrote: > > How the test should work: > > - client open plain connection to proxy > > - client sends CONNECT request > > - server answers 200 OK > > - client/server change to SSL on the existing connection

Re: [Bug-wget] Several little patches / fixes

2014-10-30 Thread Tim Ruehsen
On Thursday 30 October 2014 09:47:20 Giuseppe Scrivano wrote: > Tim Ruehsen writes: > > Please review and give me a short feedback before I push them. > > > > 0001 > > fix memory leak in openssl.c (not freeing X509_NAME_oneline() output) and > > replaces X509_NAME_oneline() by a RFC 2253 complia

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-30 Thread Daniel Stenberg
On Thu, 30 Oct 2014, Tim Ruehsen wrote: How the test should work: - client open plain connection to proxy - client sends CONNECT request - server answers 200 OK - client/server change to SSL on the existing connection (in the real world the proxy does this when it established the requested conne

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-30 Thread Tim Ruehsen
On Wednesday 29 October 2014 15:57:04 Mike Frysinger wrote: > On 28 Oct 2014 11:47, Tim Ruehsen wrote: > > I pushed it, since it fixes a bug anyways. > > it still seems to be racy for me -- passes only rarely. using wget 1.16 > with just the one fix 3eff3ad69a46364475e1f4abdf9412cfa87e3d6c. Meanw

Re: [Bug-wget] Several little patches / fixes

2014-10-30 Thread Giuseppe Scrivano
Tim Ruehsen writes: > Please review and give me a short feedback before I push them. > > 0001 > fix memory leak in openssl.c (not freeing X509_NAME_oneline() output) and > replaces X509_NAME_oneline() by a RFC 2253 compliant output. > From the docs: > "The functions X509_NAME_oneline() and X509

[Bug-wget] Several little patches / fixes

2014-10-30 Thread Tim Ruehsen
Please review and give me a short feedback before I push them. 0001 fix memory leak in openssl.c (not freeing X509_NAME_oneline() output) and replaces X509_NAME_oneline() by a RFC 2253 compliant output. From the docs: "The functions X509_NAME_oneline() and X509_NAME_print() are legacy functions w