Fixes #43262 [1]
504 Gateway Timeout responses will now be dealt like other non-fatal errors.
Added a test case for the same
[1]: https://savannah.gnu.org/bugs/?43262
--
Thanking You,
Darshit Shah
From e5d5c0b23d85b9e1853b18a1cb7384f66ba8cf50 Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date:
> > I think we should just have one xfree() macro instead of two (xfree and
> > xfree_null, some parts of the code even use free() directly).
>
> I was looking into such things yesterday. Maybe we can write git hooks to
> prevent known bad coding conventions from being pushed into the repository
>
On Wed, 19 Nov 2014, Darshit Shah wrote:
I already have a few sanity checks for Wget in my pre-commit hook. Such
things can be restyled for a server side update hook too.
IMHO, it is better if you integrate those checks into the test suite or
something so that contributors can figure them out
[in reply to Giuseppe Scrivano Tue, 18 Nov 2014 21:04:52 +0100]
> it just works for me:
>
> sudo mkdir -p /usr/local/wget-1.16/
> sudo chown $(id -u):$(id -g) /usr/local/wget-1.16
> ./configure --prefix=/usr/local/wget-1.16
> make
> make install
>
>
> Can you please double check the permissions on
On Tuesday 18 November 2014 21:11:57 Giuseppe Scrivano wrote:
> Tim Ruehsen writes:
> > Trivial change to option c), see http://savannah.gnu.org/bugs/?41331.
> >
> >> f. Just read .pem and .crt file
> >
> > This might introduce regressions. These extensions are not standardized,
> > at
> > least
On Wednesday 19 November 2014 14:11:12 Darshit Shah wrote:
> Fixes #43262 [1]
>
> 504 Gateway Timeout responses will now be dealt like other non-fatal errors.
>
> Added a test case for the same
Looks good here.
Tim
signature.asc
Description: This is a digitally signed message part.
;-) From my post:
> > This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these
If the patch in my original post is OK for you, I'll would like to push it.
Tim
On Wednesday 19 November 2014 07:17:35 Darshit Shah wrote:
> I think we use std=gnu89 or std=gnu99.
>
> I've been usi
On 11/19, Tim Rühsen wrote:
On Wednesday 19 November 2014 14:11:12 Darshit Shah wrote:
Fixes #43262 [1]
504 Gateway Timeout responses will now be dealt like other non-fatal errors.
Added a test case for the same
Looks good here.
Tim
Pushed!
--
Thanking You,
Darshit Shah
pgpFM04SsNnym.
I just ran the latest HEAD of our repository through Coverity's static
analysis engine.
Here is the report it returned.
Anyone who wishes to look at the full reports, please send a request
through coverity and I'll grant you permissions.
-- Forwarded message --
From:
Date: Wed
On Wednesday 19 November 2014 18:17:15 Darshit Shah wrote:
> I just ran the latest HEAD of our repository through Coverity's static
> analysis engine.
>
> Here is the report it returned.
>
> Anyone who wishes to look at the full reports, please send a request
> through coverity and I'll grant you
On 11/19, Tim Rühsen wrote:
On Wednesday 19 November 2014 18:17:15 Darshit Shah wrote:
I just ran the latest HEAD of our repository through Coverity's static
analysis engine.
Here is the report it returned.
Anyone who wishes to look at the full reports, please send a request
through coverity a
On Wednesday 19 November 2014 18:17:15 Darshit Shah wrote:
> I just ran the latest HEAD of our repository through Coverity's static
> analysis engine.
Here are two patches for three of the reports (the 4th seems to be a false
positive).
Please have a look.
Tim
From 02c3a2a3af08c662e3c3a33a5c538f
On 11/19, Tim Rühsen wrote:
On Wednesday 19 November 2014 18:17:15 Darshit Shah wrote:
I just ran the latest HEAD of our repository through Coverity's static
analysis engine.
Here are two patches for three of the reports (the 4th seems to be a false
positive).
Please have a look.
Looks goo
On Wednesday 19 November 2014 20:05:29 Darshit Shah wrote:
> On 11/19, Tim Rühsen wrote:
> >On Wednesday 19 November 2014 18:17:15 Darshit Shah wrote:
> >> I just ran the latest HEAD of our repository through Coverity's static
> >> analysis engine.
> >
> >Here are two patches for three of the repor
On 11/18, Tim Rühsen wrote:
This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these may
prevent from compiling with MSVC.
There are still some warnings "ISO C forbids conversion of function pointer to
object pointer type [-Wpedantic]" left over. I'll care for these the next
da
On 11/18, Tim Rühsen wrote:
I amended three tests to fail when run with turkish locale.
I fixed these issues (using c_strcasecmp/c_strncasecmp) and also replaced
strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at places where we
definitely want a ASCII comparison instead of a locale dependen
On 11/09, Ángel González wrote:
On 07/11/14 06:12, Darshit Shah wrote:
Because real life is catching up, I've very little time till the end of
this year. But I'm going to try and debug this issue and fix it asap.
A small suggestion before you stop touching this part of the codebase: do
not inc
On 11/04, David McMackins wrote:
I noticed in the new version of wget that there is a scrolling preview
name of the file being downloaded.
This is interesting, but it leaves off the last letter before resetting
to the beginning.
This doesn't affect performance; it's just a little irritating if
Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
> On 11/18, Tim Rühsen wrote:
> >This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these
> >may prevent from compiling with MSVC.
> >
> >There are still some warnings "ISO C forbids conversion of function pointer
> >t
Am Mittwoch, 19. November 2014, 22:21:12 schrieb Darshit Shah:
> On 11/18, Tim Rühsen wrote:
> >I amended three tests to fail when run with turkish locale.
> >I fixed these issues (using c_strcasecmp/c_strncasecmp) and also replaced
> >strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at places
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 20-Nov-2014 12:07 am, "Tim Rühsen" wrote:
>
> Am Mittwoch, 19. November 2014, 22:21:12 schrieb Darshit Shah:
> > On 11/18, Tim Rühsen wrote:
> > >I amended three tests to fail when run with turkish locale.
> > >I fixed
Darshit Shah wrote:
> On the other hand, providing this configure option and making a note in the
> NEWS
> section, I am hoping that more maintainers will use the --disable-assert flag
> and
> remove assertions from the compiled code.
Would it make more sense to have an --enable-assert flag to
Alfred M. Szmidt wrote:
> wget -o /dev/null -O - "$@"
By the way, you can accomplish the same thing by:
wget -q -O - "$@"
Hi Tim,
> Am 17.11.2014 um 20:49 schrieb Tim Rühsen :
>
> Am Montag, 17. November 2014, 09:05:52 schrieb Alfred M. Szmidt:
>> It would be nice if wget also installed a wcat command which would
>> default to something like,
>>
>> wget -o /dev/null -O - "$@"
>>
>> Would it be possible to add som
Am Donnerstag, 20. November 2014, 00:38:28 schrieb Darshit Shah:
> > Dumb question: I never saw ^L in source code. What is it good for ?
>
> Printing ?
>
> The GNU coding conventions require those. They are apparently for
> demarcating pages. Most probably for printing I'd guess
Just a citation:
I meant to send this to the whole list, sorry.
-- Forwarded message --
From: "William Tracy"
Date: Nov 19, 2014 1:32 PM
Subject: Re: [Bug-wget] wcat?
To: "Dagobert Michelsen"
Cc:
Two thoughts:
1. Curl already behaves this way out of the box, so the path of least
resistance here
Or, if there's any real need, may I suggest this simple patch for making a
wrapper in contrib/wcat? :-9
Best regards,
/Pär
2014-11-19 22:34 GMT+01:00 William Tracy :
> I meant to send this to the whole list, sorry.
> -- Forwarded message --
> From: "William Tracy"
> Date: Nov 1
Or, realizing that even the simplest of shell scripts contain bugs, this
one is slightly better... and conforms better to GNU coding standards. :-)
/Pär
2014-11-19 22:50 GMT+01:00 Pär Karlsson :
> Or, if there's any real need, may I suggest this simple patch for making a
> wrapper in contrib/wca
I think Alfred wants to have a behaviour similar to to gzip/gzcat
where you could also have similar structure but nonetheless gzip
ships gzcat, gzgrep etc.
Exactly.
On Wed, 19 Nov 2014, Tim Rühsen wrote:
I won't change my toolchain just to see these formfeeds. Looks like I had
luck so far... but now, really, how can I work on Wget's sources from now on
? I have to stop here and now...
Stop with that crap (formfeed characters) already. Exactly zero people
Tim Rühsen wrote:
This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these may
prevent from compiling with MSVC.
That's really good news to me. But there are still lots
more C99 "errors". Espesially in main.c.
--gv
On 18/11/14 12:53, Tim Ruehsen wrote:
On Tuesday 18 November 2014 12:08:58 Giuseppe Scrivano wrote:
There are many other places in Wget where we should use these functions.
(See my email from 24.9.2014 13:08:21).
I am not sure (in fact I doubt) that we can blindly replace strcasecmp and
strncas
On 18/11/14 17:12, Tim Ruehsen wrote:
I amended three tests to fail when run with turkish locale.
I fixed these issues (using c_strcasecmp/c_strncasecmp) and also replaced
strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at places where we
definitely want a ASCII comparison instead of a local
On 11/19, Daniel Stenberg wrote:
On Wed, 19 Nov 2014, Tim Rühsen wrote:
I won't change my toolchain just to see these formfeeds. Looks like
I had luck so far... but now, really, how can I work on Wget's
sources from now on ? I have to stop here and now...
Stop with that crap (formfeed charac
On 11/19, Ángel González wrote:
On 18/11/14 12:53, Tim Ruehsen wrote:
On Tuesday 18 November 2014 12:08:58 Giuseppe Scrivano wrote:
There are many other places in Wget where we should use these functions.
(See my email from 24.9.2014 13:08:21).
I am not sure (in fact I doubt) that we can blind
On 11/19, Tim Rühsen wrote:
Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
On 11/18, Tim Rühsen wrote:
>This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these
>may prevent from compiling with MSVC.
>
>There are still some warnings "ISO C forbids conversion of
On 11/19, Pär Karlsson wrote:
Or, realizing that even the simplest of shell scripts contain bugs, this
one is slightly better... and conforms better to GNU coding standards. :-)
/Pär
Or realizing that Free Software means legal stuff, we need to modify this and
add a legal notice about the GPL,
That does seem like an crazy amount of extra work (and code) for just a
simple wrapper. :-) And really, curl would be the way to do this on most
platforms/systems.
I'd be happy to do it, though, if there is enough interest from the people
on the list?
/Pär
2014-11-20 7:34 GMT+01:00 Darshit Shah
On 20/11/14 07:34, Darshit Shah wrote:
And talking about legalities, I'm hoping you already have signed the
assignment papers because otherwise that's even more work, before we
can add this to the source. :-)
Come on, that's not needed for trivial changes :)
The given shell script is a perfect
On 20/11/14 06:13, Darshit Shah wrote:
@Tim: Please just add that include statement one line above, or else
I'll make the required change and push it.
You can copy that block from my patch if that's easier for you, but
please comment on the issues I mentioned.
40 matches
Mail list logo
