Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys

2016-02-23 Thread moparisthebest
Hi Tim, I attempted to implement your suggestions and formatting everywhere, though it's entirely possible I missed a place or two. :) I also added an entry in wget.texi. Attached is the latest patch and it's also pushed up to my github repo. Let me know when you have future comments about it, u

Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys

2016-02-23 Thread Tim Rühsen
Hi Travis, thank you for your contribution to wget ! We'll take a closer look at the functionality the next days and will think about automated tests. Just a few comments from the first glimpse - the wget options are documented in doc/wget.texi, please add an entry for the new option - xmalloc

[Bug-wget] Implement --pinnedpubkey option to pin public keys

2016-02-23 Thread moparisthebest
Hello wget team, The attached patch implements a --pinnedpubkey option to pin public keys for TLS/SSL. I also pushed this to github [1]. I implemented and tested this for both the openssl and gnutls backends, and they share code which I put in util.c. It supports a path to a single .der or .pem

Re: [Bug-wget] newer versions of wget broke file download

2016-02-23 Thread Tim Paulson
I have already deleted the account. That was a temporary account created for troubleshooting this issue. Regards, Tim Paulson -Original Message- From: Tim Ruehsen [mailto:tim.rueh...@gmx.de] Sent: Tuesday, February 23, 2016 3:09 AM To: bug-wget@gnu.org Cc: Tim Paulson ; Darshit Shah

Re: [Bug-wget] Segfault when padding is negative

2016-02-23 Thread Tim Ruehsen
Thanks for feedback. Just want to mention that you won't need docker. 'stty cols x' is enough to reproduce the crash. 'x' must be low enough (somewhere around 40 here). Tim On Tuesday 23 February 2016 03:36:10 Lauchlin Wilkinson wrote: > Hi Darshit, > > Patch works perfectly. > > To reproduc

Re: [Bug-wget] newer versions of wget broke file download

2016-02-23 Thread Tim Ruehsen
> Thank you > Adding the --auth-no-challenge switch allows the file to download. You posted your credentials on a public mailing list, did you already change your password !? Tim On Monday 22 February 2016 20:57:41 Tim Paulson wrote: > Thank you > Adding the --auth-no-challenge switch allows th