Re: [Bug-wget] [PATCH v2] wget: Add --use-askpass support

2016-07-27 Thread Ángel González
On 27/07/16 16:15, Liam R. Howlett wrote: There are a few spots that require C99 (char * const argv, unsigned int bytes), but I'm unsure if we ending up dropping C90 support or not. I'd be happy to do this - however I need help doing so. The issue is that changing char * question to a const cau

Re: [Bug-wget] [PATCH v2] wget: Add --use-askpass support

2016-07-25 Thread Ángel González
On 25/07/16 20:28, Liam R. Howlett wrote: This adds the --use-askpass option which is disabled by default. --use-askpass will request the username and password for a given URL by executing the external program pointed to by the environment variable WGET_ASKPASS. If the environment variable is n

Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support

2016-07-24 Thread Ángel González
I don't think the name --ssh-askpass is appropriate. It would be better to have a parameter to --ask-password like --ask-password=external or receive the name of the environment variable to use. Plus I also agree that something like popen would be preferable.

Re: [Bug-wget] OpenSSL 1.1.0

2016-06-28 Thread Ángel González
On 28/06/16 22:16, Tim Rühsen wrote: Patching src/openssl.c for 1.1.0 (see below) let it compile. But the HTTPS tests fail due to ERROR: cannot verify localhost's certificate, issued by 'O=GNU,OU=Wget,CN=GNU Wget': unsupported certificate purpose Any idea ? server-cert.pem has the followin

Re: [Bug-wget] Anyone want to add libcares support to wget?

2016-03-18 Thread Ángel González
On 16/03/16 15:35, Ben Greear wrote: wget can already bind to a local IP. It might be nice to add support for SO_BINDTODEVICE, but not sure it is required for what I need. The rest of your suggestions are total hacks! The place for setting this is the resolver. It's not reasonable to expect

[Bug-wget] [bug #46611] log errors with --trust-server-names

2016-03-18 Thread Ángel
Follow-up Comment #9, bug #46611 (project wget): The problem is not that with -E a .html is appended, but that it checks .exe but reports about .exe.html Running: LANG=C strace -e stat,open wget -E -d --timestamping --trust-server-names http://downloads.malwarebytes.org/file/mbam I get: 304 Not

Re: [Bug-wget] Anyone want to add libcares support to wget?

2016-03-15 Thread Ángel González
On 15/03/16 17:03, Ben Greear wrote: I want to use wget on multi-homed machines, and I use routing rules to route pkts out specific interfaces based on the source IP. So, I need to be able to bind to a local IP address, including for the resolver logic, which is why I want to use libcares. T

Re: [Bug-wget] short option for --content-disposition (feature request)

2016-01-12 Thread Ángel González
On 05/01/16 14:34, Giuseppe Scrivano wrote: Hanno Böck writes: Hi, I quite often use the --content-disposition command line option of wget. It's a bit annoying to type in, but currently it seems there is no short option for it. Could such a short option be added? c and d are already taken an

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-10 Thread Ángel González
Giuseppe Scrivano writes: Ángel González writes: Sure. This was actually a diff against the file in master, so if you are ok with the contents, it only needed a commit log. thanks, recommendations for users are never enough :) I have shortened the commit message and pushed it. Giuseppe

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-10 Thread Ángel González
Giuseppe Scrivano wrote: Hi Ángel, thanks for the suggestion, it looks fine to me. I already pushed the patch, could you prepare a new one that adds this part? Regards, Giuseppe Sure. This was actually a diff against the file in master, so if you are ok with the contents, it only needed a

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-09 Thread Ángel González
On 02/12/15 14:33, Giuseppe Scrivano wrote: Tim agreed so I've changed the patch to add --check-certificate=quiet. How does the new version look? Thanks, Giuseppe diff --git a/doc/wget.texi b/doc/wget.texi index c647e33..9cc2bb2 100644 --- a/doc/wget.texi +++ b/doc/wget.texi @@ -1725,6 +1725,9

Re: [Bug-wget] Windows cert store support

2015-12-09 Thread Ángel González
On 09/12/15 03:06, Random Coder wrote: I'm not sure if the wget maintainers would be interested, but I've been carrying this patch around in my private builds of wget for a while. It allows wget to load SSL certs from the default Windows cert store. The patch itself is fairly straightforward, b

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-11-30 Thread Ángel González
On 30/11/15 22:33, Tim Rühsen wrote: There is the situation where --no-check-cert is implicitly set (.wgetrc, /etc/wgetrc, alias) and the user isn't aware of it. Just downloading without a warning opens a huge security hole because you can't verify where you downloaded it from (DNS attacks, MITM)

Re: [Bug-wget] Travis-CI updates and minor bug fixes

2015-11-22 Thread Ángel González
Darshit Shah wrote: Currently, the only build that fails is one with --without-ssl. While I understand that this is a ridiculous idea in this day, but we provide a configure option to build without SSL and should support it. I've left it there since it's a more major issue we need to look into be

[Bug-wget] [bug #46061] wget https://contributors.debian.org fails with "No data received."

2015-09-27 Thread Ángel
Follow-up Comment #1, bug #46061 (project wget): wget in debian is using gnutls. Compiling wget using --with-ssl=openssl doesn't exhibit this bug. gnutls-cli contributors.debian.org works, though. ___ Reply to this item at:

Re: [Bug-wget] wget downloads index.html unnecessarily and halts batch script (Windows)

2015-09-22 Thread Ángel González
El 22/09/15 19:10, El Gato escribió: Hi, everyone. I am having trouble with wget64 on Windows. I am using a batch script to download files from a host: @echo OFF FOR /L %%i in (1, 1, ) DO ( cls echo Downloading file %%i wget64.exe -A pdf,chm -e robots=off --progress=bar --show

Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded

2015-09-22 Thread Ángel González
On 22/09/15 15:32, Jernej Simončič wrote: On Tuesday, September 22, 2015, 12:38:02, Tim Ruehsen wrote: I would like to see that (if I was using Windows). Should be activated by a switch (maybe windows only). Feel free to create a patch. There already is a patch for this, but it's C++:

Re: [Bug-wget] --header="Accept-encoding: gzip"

2015-09-22 Thread Ángel González
On 22/09/15 19:57, andreas wpv wrote: Unfortunately this only pulls the html files (because where I pull them they are compressed), and not all the other scripts and stylesheets and so on, although at least a few of these are compressed, either. From wget point of view, the "html" is a binary blo

Re: [Bug-wget] wget bug

2015-09-17 Thread Ángel González
On 18/09/15 01:30, Johnny Chin wrote: Thank you for that flag. I was unaware of that. Can that flag be set as default in the wgetrc? I have users that used the old wget to get files from our servers that needs it. Yes, you can set |trust-server-names| in |~/.wgetrc| *but* you are reintroduci

Re: [Bug-wget] wget bug

2015-09-17 Thread Ángel González
On 17/09/15 22:55, Johnny Chin wrote: I sent this to who I believe the person who ported the latest Windows binary but I figure it might be a bug in the current version code (well since 1.11.4 anyway). Please see if you can fix. Thank you. It does download the binary. If you want it to have t

Re: [Bug-wget] bad filenames (again)

2015-08-23 Thread Ángel González
On 23/08/15 16:47, Eli Zaretskii wrote: Wrong. I can work with a larger one by using a UNC path. But then you will be unable to use relative file names, and will have to convert all the file names to the UNC format by hand, and any file names we create that exceed the 260-character limit will be

Re: [Bug-wget] bad filenames (again)

2015-08-23 Thread Ángel González
On 20/08/15 04:42, Eli Zaretskii wrote: From: Ángel González wrote: On 19/08/15 16:38, Eli Zaretskii wrote: Indeed. Actually, there's no need to allocate memory dynamically, neither will malloc nor with alloca, since Windows file names have fixed size limitation that is known in advance

Re: [Bug-wget] bad filenames (again)

2015-08-20 Thread Ángel González
On 19/08/15 16:38, Eli Zaretskii wrote: Indeed. Actually, there's no need to allocate memory dynamically, neither will malloc nor with alloca, since Windows file names have fixed size limitation that is known in advance. So each conversion function can use a fixed-sized local wchar_t array. Do

[Bug-wget] [bug #45776] ClamAV integration?

2015-08-18 Thread Ángel
Follow-up Comment #2, bug #45776 (project wget): I agree a clamav specific feature isn't appropiate, but a feature that notifies (execs) a script of file completion would be, and such feature would solve the request IMHO (use as command: clam[d]scan --remove) _

Re: [Bug-wget] bad filenames (again)

2015-08-18 Thread Ángel González
On 18/08/15 22:28, Andries E. Brouwer wrote: On Tue, Aug 18, 2015 at 10:31:31PM +0300, Eli Zaretskii wrote: No, it's not possible. Windows does have a UTF-8 codepage, but it doesn't allow setting that as the system codepage. What is needed to have a full Unicode support in wget on Windows is t

Re: [Bug-wget] libtlssep and wget

2015-07-23 Thread Ángel González
Great work, Michael and Leo. I really like that. I should also note however that the API is too simple for many advanced uses. The --no-check-certificate is one example. Another could be cipher selection. wget explicitely disavows ciphers like RC4 or NULL, libtlsep doesn't allow choosing accep

Re: [Bug-wget] ERROR 407: authenticationrequired

2015-07-20 Thread Ángel González
Error repeated. It's as if it failed to authenticate you :s 1. This feature vget? 2. Vget can not work with ntlm? wget does support ntlm authentication. 3. I do not properly use vget (customizable)? And the parameters look ok 4. Or something else? But as it doesn't work, I guess we wil

[Bug-wget] [PATCH] Use u8_check() instead our own utf8 checking

2015-07-05 Thread Ángel González
* bootstrap.conf: Enable u8-check module * src/iri.c: Remove _utf8_is_valid() --- This is probably the shortest-lived function in wget :) I didn't change the urls, but there are probably more suited ones. bootstrap.conf | 1 + src/iri.c | 62 ++-

Re: [Bug-wget] OT: About donwload file from nitroflare

2015-07-05 Thread Ángel González
On 02/07/15 09:36, Carlos Cardenas escribió: Hi friends I want to try download some files from nitroflare, I don't know what nitroflare is. i made some test but its not possible, {{reference needed}} i have a count and made a code with python an use wget with -u -p parameters but always ni

Re: [Bug-wget] the libidn problem

2015-07-05 Thread Ángel González
On 02/07/15 13:43, Giuseppe Scrivano wrote: This is the reply I got: http://lists.gnu.org/archive/html/help-libidn/2015-07/msg0.html I don't like much the "You need to pass valid UTF-8 to libidn" in there. However, the rationale for giving them CVE-2015-2059

Re: [Bug-wget] Clang analyze on Win32

2015-06-17 Thread Ángel González
On 17/06/15 22:31, Gisle Vanem wrote: I'm trying to familiarize myself with clang and did a quick 'clang-cl --analyze '. This is what it revealed: init.c(569,13) : warning: Value stored to 'home' during its initialization is never read char *home = home_dir (); ^~~~ ~~

Re: [Bug-wget] [bug #45236] Memory disclosure in wget using incomplete UTF-8 sequences

2015-06-02 Thread Ángel González
On 02/06/15 12:50, Ander Juaristi wrote: On 06/02/2015 10:36 AM, anonymous wrote: Hello, We discovered a vulnerability in the parsing and processing of international domain names performed by the GNU IDN library in wget. It affects systems using the UTF-8 locales and allows to read bytes ou

Re: [Bug-wget] Contribution on bug #45037

2015-05-19 Thread Ángel González
On 18/05/15 08:43, Ander Juaristi wrote: On 05/17/2015 07:02 PM, Ángel González wrote: It's not possible to create a symlink with HTTP, so it's not a problem there. And although I thought it was possible with FTP (I can certainly see symlinks on FTP servers), a brief test sugests

Re: [Bug-wget] history of --random-wait

2015-05-19 Thread Ángel González
On 19/05/15 18:46, Tony Lewis wrote: On Tuesday, May 05, 2015 4:05 PM Ángel González wrote: The commit that added it (2c41d783c) says: Submitted by Alan Eldridge in <200111042106.fa4l63b75...@wwweasel.geeksrus.net>. My personal archive goes back to March 7, 2002. There are a few message

Re: [Bug-wget] Contribution on bug #45037

2015-05-17 Thread Ángel González
On 17/05/15 12:55, Tim Rühsen wrote: Thank you Ángel for digging the history up. What Loïc needs it a way to go. Else he can't fix anything. How about changing the FTP code behavior so that it exactly works the same as the HTTP code ? That is what the user expects. Or are there any &#x

Re: [Bug-wget] Contribution on bug #45037

2015-05-16 Thread Ángel González
On 16/05/15 22:10, Ander Juaristi Alamos wrote: Hello, I found another task where I want to contribute, the issue with 45037. For what I understand, and read in the mailling list, the problem occur inftp.c ftp_loop_internal -> remove_link. But what I don't understand, is why each time he try t

Re: [Bug-wget] Understanding Wget - FTP Client

2015-05-08 Thread Ángel González
On 08/05/15 15:04, Satyam Zode wrote: Hello everyone ! I am working on GNU Wget FTP Test suite, I have been understanding the different aspects and working of FTP Server from RFC 959 and other resources. I have some questions related to Wget (that is FTP client side) in my mind.

Re: [Bug-wget] [bug #45037] wget -O foo ftp://ftp.funet.fi/pub/Linux/mirrors/debian/README deletes README symlink

2015-05-08 Thread Ángel González
On 07/05/15 06:10, Darshit Shah wrote: Given that this is a clearly documented feature of Wget, that -O is supposed to work as shell redirection, I think it should not pose too many issues. Yes, there is the security risk where another file may be overwritten, but I think the user should be car

[Bug-wget] [bug #44886] Windows filepaths not recognized for -i, reported in the *NIX style

2015-05-06 Thread Ángel
Follow-up Comment #3, bug #44886 (project wget): Problem: wget64.exe -i C:UsersAspireDesktoptest3input.txt fails with C:/Users/Aspire/Desktop/test3/input.txt: No such file or directory My first guess was related to cygwin shell, but you explicitely stated that you are using cmd.exe Does it wor

[Bug-wget] [bug #45037] wget -O foo ftp://ftp.funet.fi/pub/Linux/mirrors/debian/README deletes README symlink

2015-05-06 Thread Ángel
Follow-up Comment #3, bug #45037 (project wget): It's clearly a bug. If we are downloading README to local file foo, there's no reason to remove the local symlink README. When we want to save into a name where there's currently a symlink, consistency with shell > would dictate just to follow the

Re: [Bug-wget] bootstrap problem

2015-05-06 Thread Ángel González
On 06/05/15 10:46, Giuseppe Scrivano wrote: Ander Juaristi writes: Why don't we just add Bash to the dependency list, at README.checkout? This is (or at least, should be) the first resource to read for current and future Wget developers. that won't be enough, I am afraid. He had bash install

Re: [Bug-wget] bootstrap problem

2015-05-05 Thread Ángel González
On 06/05/15 01:33, Jim Meyering wrote: On Tue, May 5, 2015 at 2:50 PM, Ángel González wrote: I don't think that we should spend any effort attempting to support non-POSIX shells (Solaris sh seems the only midly common under that category). That said, it would be nice to have a nicer

Re: [Bug-wget] history of --random-wait

2015-05-05 Thread Ángel González
On 05/05/15 01:58, lev wrote: Question: What's the story behind wget's "--random-wait" Option. According to the man page "…A 2001 article in a publication devoted to development on a popular consumer platform provided code to perform this analysis on the fly. Its author suggested blocking at t

Re: [Bug-wget] bootstrap problem

2015-05-05 Thread Ángel González
On 05/05/15 12:45, Dagobert Michelsen wrote: Hi Darshit, Am 05.05.2015 um 12:23 schrieb Darshit Shah: So, is the issue because some platforms are shipping a non-compatible version of sh, or is the script incorrectly using bash while only claiming to use sh? The problem is the evaluation with $

Re: [Bug-wget] bootstrap problem

2015-05-05 Thread Ángel González
On 05/05/15 14:21, Mariusz Balewski wrote: It was using /bin/sh. I tested it on Ubuntu Linux. Mariusz The Ubuntu default is to use bash for /bin/sh (although you didn't provide versions). And even dash should work. Did you change anything?

Re: [Bug-wget] GSoC15: Speed up Wget's Download Mechanism

2015-05-04 Thread Ángel González
Darshit Shah wrote: 2. Regarding the socket options, we should spend some more time evaluating our options. My understanding of TCP_CORK is that it may be a useful option for Servers, but it doesn't really affect TCP clients in any useful way. This is because TCP_CORK modifies the minimu

Re: [Bug-wget] avoiding a large number of HEAD reqs when resuming

2015-05-04 Thread Ángel González
On 30/04/15 14:04, User Goblin wrote: My initial idea was to parse wget's -o output and figure out which files still need to be downloaded, and then feed them via -i when continuing the download. This led me to the conclusion that I'd need two pieces of functionality, (1) machine-parseable output

Re: [Bug-wget] bootstrap problem

2015-05-04 Thread Ángel González
On 04/05/15 12:54, Mariusz Balewski wrote: it looks like something fishy with your shell. Could you give us the output of "ls -l /bin/sh" ? Could you try to run instead "bash ./bootstrap" ? Regards, Giuseppe Problem already resolved. Bad shebang was the issue. As soon as I changed it to #!/

Re: [Bug-wget] GSoC15: Speed up Wget's Download Mechanism

2015-04-29 Thread Ángel González
On 29/04/15 10:02, Hubert Tarasiuk wrote: Hello developers, There are two tasks to be done there: - TCP Fast Open (RFC7413) I didn't know about TFO. https://lwn.net/Articles/508865/ was a nice read! A summarized version of my proposal is available: http://pliki.h.trsk.org/gsoc/wget_publi

Re: [Bug-wget] bootstrap problem

2015-04-29 Thread Ángel González
Onl 29/04/15 15:03, m_balewski wrote: Hi, It's my first mail here, so I would like to welcome you all! wget isgreat (I'm using it for years) and I wish to try to look into it's codeand maybe do some changens some day :) But for now, I have a problem... I've just downloaded the sources and tryin

Re: [Bug-wget] No warning printed when using options: -N -O-

2015-04-28 Thread Ángel González
On 28/04/15 21:56, Nik Nyby wrote: The wget manual states: ‘-N’ (for timestamp-checking) is not supported in combination with ‘-O’: since file is always newly created, it will always have a very new timestamp. A warning will be issued if this combination is used. (In this section of th

Re: [Bug-wget] no_proxy env ip address range support

2015-04-15 Thread Ángel González
On 14/04/15 23:44, Aníbal Limón wrote: Hi guys, I noticed that wget only support domain names entries into no_proxy env-var, i think will be good to add support for IPs and IP ranges. I reviewed the code and i think can be added to src/retr.c:no_proxy_match , that will be resolv the host to

Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file

2015-04-08 Thread Ángel González
On 08/04/15 19:08, Hubert Tarasiuk wrote: W dniu 07.04.2015 o 00:11, Ángel González pisze: On 06/04/15 22:15, Hubert Tarasiuk wrote: We should probably also fix this comment: /* sXXXav : free new when needed ! */ As it presumably mentions the problem that we are going to repair. I

Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file

2015-04-06 Thread Ángel González
On 06/04/15 22:15, Hubert Tarasiuk wrote: We should probably also fix this comment: /* sXXXav : free new when needed ! */ As it presumably mentions the problem that we are going to repair. I thought it refered to idna_to_ascii_8z sometimes allocating memory on error (that's why I didn

[Bug-wget] Fix const usage in iri.c

2015-04-06 Thread Ángel González
While looking at Hubert patch to iri.c (and surrounding code) I noticed that remote_to_utf8 declared the output parameter as const char** (instead of char**) and there was a number casting around to (const char **) and (char *) in the file. The following patch fixes the prototypes to have sens

Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file

2015-04-06 Thread Ángel González
Thanks for your work, Hubert. I agree it is helpful to name them differently. What about this alternative rename? (I'm the host reassignation by using a ternary, plus touched a comment) diff --git a/src/iri.c b/src/iri.c index dc1ebd0..eec5646 100644 --- a/src/iri.c +++ b/src/iri.c @@ -225,19

Re: [Bug-wget] Incorrect handling of Cyrillic characters in http request - any workaround?

2015-03-31 Thread Ángel González
On 01/04/15 00:16, Stephen Wells wrote: Hi Tim, Sorry for the ambiguity. To be more specific, the file name is fine: in the shell script the file name $*.mp3 expands correctly to e.g. мазать.mp3 . The audio within the file consists of the Google robot voice reading the string of percent-escaped

Re: [Bug-wget] Trust On First Use & GSoC 2015 participation

2015-03-13 Thread Ángel González
(adding back the list) On 13/03/15 16:53, Molnár Géza wrote: Hi Ángel. "Try to come up with a few options and submit them to the list. A potential problem is that wget can be used either as an interactive tool than as a batch one. It isn't appropiate that a cron job stops as

Re: [Bug-wget] Trust On First Use & GSoC 2015 participation

2015-03-09 Thread Ángel González
Molnár Géza wrote: Greetings all, Greetings Molnár, I'm glad you were attracted by wget project :) I am writing to you regarding two topics: 1.) I was delighted to find that Wget has a GSoC page. Last night I read the project ideas and the instructions on how to start contributing to Wget.

Re: [Bug-wget] How can I help?

2015-03-09 Thread Ángel González
Anderson Goulart wrote: Hi, I read at savanah page that you need some help in this project. I am not an experienced C programmer, but I can help fixing bugs and trying to implement some feature requests. I have some spare time and I would like to contribute. Could you please say how can I start?

Re: [Bug-wget] [PATCH] maint: update copyright year ranges to include 2015

2015-03-09 Thread Ángel González
IOn 09/03/15 16:33, Giuseppe Scrivano wrote: FYI, I am going to push the result of running: git ls-files doc contrib msdos src testenv/ tests util vms | xargs gnulib/build-aux/update-copyright on the repository to mass update copyright years. Regards, Giuseppe What's the point of doing that?

Re: [Bug-wget] wget produces erroneous robots.txt

2015-02-19 Thread Ángel González
leoh Jones wrote: I can buy mis-configured server. I only tried it one the one server, maybe that server has an issue with http 200 requests. Run wget -S http:///robots.txt and see what was returned by the server.

Re: [Bug-wget] xfree() crashes on libidn memory

2015-02-10 Thread Ángel González
On 10/02/15 23:27, Gisle Vanem wrote: This probably is alien stuff to you Unix folks. You have no release/debug-modes to take care of (?) Heh, there can be such things on *nix systems too. Suppose that libidn switched to a different allocator, for instance. Low importance since the cases where

Re: [Bug-wget] python3

2014-12-18 Thread Ángel González
On 18/12/14 09:16, Jérémie Courrèges-Anglas wrote: wget-1.16.1 introduced a change wrt. python. Just upgrading the port lead to the following failure: checking whether /usr/local/bin/python3.4 version is>= 3.0... no configure: error: Python interpreter is too old *** Error 1 in . (/usr/ports/in

Re: [Bug-wget] [PATCH 1-3/3] support HTTP compression

2014-12-18 Thread Ángel González
On 18/12/14 13:32, Yuriy M. Kaminskiy wrote: I preferred to save file as is, without attempting to decompress them, leaving decompression to user. That isn't really user friendly. (Later patches only decompress files in-memory, when wget want to parse them for links (-r/-p options)). It also

Re: [Bug-wget] [PATCH 1-3/3] support HTTP compression

2014-12-17 Thread Ángel González
On 17/12/14 23:51, Daniel Stenberg wrote: + else request_set_header (req, "Accept-Encoding", "identity", rel_none); You should indent lines when they move into else branches. And why add add "identity" at all in the first place? What good is meant to come out that increased request size

Re: [Bug-wget] [PATCH 1-3/3] support HTTP compression

2014-12-17 Thread Ángel González
On 16/12/14 16:20, Yuriy M. Kaminskiy wrote: Thanks! Comments inline. > From ccb95548926a0ab8ad4ed3787470d4803efad4ca Mon Sep 17 00:00:00 2001 From: "Yuriy M. Kaminskiy" Date: Tue, 16 Dec 2014 17:19:22 +0300 Subject: [PATCH 1/3] Recognize Content-Encoding header --- src/http.c | 49

Re: [Bug-wget] HTTP gzip compression

2014-12-15 Thread Ángel González
Hi Donavan, No problem for suggesting things. I agree it would be cool. Doesn't even look too hard, just detect the Content-Encoding: gzip and filter through gzip -d when saving. But someone needs to code it :) Best regards

Re: [Bug-wget] [PATCH] Fix for #43785 (ngettext with Solaris 10)

2014-12-11 Thread Ángel González
Tim Ruehsen wrote: Another option would be to completely avoid ngettext() - we just use it at two places (spider.c and warc.c) (ngettext(s1,s2,n) --> n==1?s1:s2). Some languages have plurals way weirder than n==1?s1:s2 (OTOH it's possible they aren't handled by ngettext() either).

Re: [Bug-wget] [PATCH] Fixing C89 warnings

2014-11-20 Thread Ángel González
On 20/11/14 16:56, Gisle Vanem wrote: FYI. the error from MSVC was: progress.c(844) : error C2010: '*' : unexpected in macro formal parameter list progress.c(978) : error C2059: syntax error : 'do' Here is a patch: --- ../Git-latest/src/progress.c2014-11-20 15:39:55 + +++ prog

Re: [Bug-wget] Disable assertions by default

2014-11-20 Thread Ángel González
On 20/11/14 15:29, Darshit Shah wrote: --- a/src/progress.c +++ b/src/progress.c @@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double dl_total_time, bool done) { int percentage = 100.0 * size / bp->total_length; assert (percentage<= 100); + assert (false);

Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale

2014-11-20 Thread Ángel González
es that). Tim Ruehsen wrote: On Thursday 20 November 2014 00:12:08 Ángel González wrote: I am attaching it here fwiw. I generally changed them on a few more places, although I think some of your edits to init.c are incorrect, as well as those on progress.c: as they are user-parameters, they _might

Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale

2014-11-19 Thread Ángel González
On 20/11/14 06:13, Darshit Shah wrote: @Tim: Please just add that include statement one line above, or else I'll make the required change and push it. You can copy that block from my patch if that's easier for you, but please comment on the issues I mentioned.

Re: [Bug-wget] wcat?

2014-11-19 Thread Ángel González
On 20/11/14 07:34, Darshit Shah wrote: And talking about legalities, I'm hoping you already have signed the assignment papers because otherwise that's even more work, before we can add this to the source. :-) Come on, that's not needed for trivial changes :) The given shell script is a perfect

Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale

2014-11-19 Thread Ángel González
On 18/11/14 17:12, Tim Ruehsen wrote: I amended three tests to fail when run with turkish locale. I fixed these issues (using c_strcasecmp/c_strncasecmp) and also replaced strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at places where we definitely want a ASCII comparison instead of a local

Re: [Bug-wget] [PATCH] First

2014-11-19 Thread Ángel González
On 18/11/14 12:53, Tim Ruehsen wrote: On Tuesday 18 November 2014 12:08:58 Giuseppe Scrivano wrote: There are many other places in Wget where we should use these functions. (See my email from 24.9.2014 13:08:21). I am not sure (in fact I doubt) that we can blindly replace strcasecmp and strncas

Re: [Bug-wget] downloading entire site to transfer q?

2014-11-10 Thread Ángel González
On 10/11/14 02:03, voy...@sbt.net.au wrote: I'm trying to transfer entire site to a new host, tried several options including like: wget --recursive --no-clobber --page-requisites --no-parent http://www.domain.tld but, all i get was single file as so: index.html ---