without the reformatting ?
Regards, Tim
On Tuesday 16 June 2015 00:17:08 Pär Karlsson wrote:
Here is a suggested patch. I don't know if it will solve the problem, but
at least there should be diagnostics in the log if something fails.
Best regards,
/pär
2015-06-15 13:37 GMT+02:00 Pär
I quickly looked at the code in question, and one obvious quick test would
be to check the return value of the unlink calls (and $! / $ERRNO
afterwards) at the two places in the respective .px files where
'needs-auth.txt' is handled.
I've been cleaning up the two tests mentioned but so far have
Here is a suggested patch. I don't know if it will solve the problem, but
at least there should be diagnostics in the log if something fails.
Best regards,
/pär
2015-06-15 13:37 GMT+02:00 Pär Karlsson feino...@gmail.com:
I quickly looked at the code in question, and one obvious quick test
Pär Karlsson wrote:
Yes, you are right. The declaration of $i inside the for expression
shadows
the scope of the outer $i inside the for loop (which indeed makes the
outer
$i uninitialized after the loop).
The for loop itself is not stylistically Perlish with the C-style loop
embarrasing mistake - my suggestion
would be to change it to a while loop instead (see attached patch).
Best regards,
/Pär
2015-05-19 20:04 GMT+02:00 Hubert Tarasiuk hubert.taras...@gmail.com:
From: Pär Karlsson address@hidden
A number of Perl-specific cleanups in the test suite perl
Hello,
This is a kludge, but you could temporarily short-circuit the problematic
domain/hostname to localhost in your /etc/hosts file or (if on Windows) the
equivalent file (somewhere in c:\Windows\System32\ IIRC, Google should have
the answer).
/Pär
2014-11-26 1:36 GMT+01:00 Dun Peal
Hi,
Attached is a patch for a missing 'version.h' in wget_SOURCES in the
src/Makefile.am, which I suppose should have been included in the above
patch by Darshit.
Without it, 'make distcheck' fails.
Best regards,
/Pär
2014-11-22 10:22 GMT+01:00 Darshit Shah dar...@gmail.com:
---
Or, if there's any real need, may I suggest this simple patch for making a
wrapper in contrib/wcat? :-9
Best regards,
/Pär
2014-11-19 22:34 GMT+01:00 William Tracy afishion...@gmail.com:
I meant to send this to the whole list, sorry.
-- Forwarded message --
From: William
Or, realizing that even the simplest of shell scripts contain bugs, this
one is slightly better... and conforms better to GNU coding standards. :-)
/Pär
2014-11-19 22:50 GMT+01:00 Pär Karlsson feino...@gmail.com:
Or, if there's any real need, may I suggest this simple patch for making
dar...@gmail.com:
On 11/19, Pär Karlsson wrote:
Or, realizing that even the simplest of shell scripts contain bugs, this
one is slightly better... and conforms better to GNU coding standards. :-)
/Pär
Or realizing that Free Software means legal stuff, we need to modify
this and add
Hello,
Try running wget with the -v / --verbose option enabled, this will allow
you to see the details of what is happening.
The reply from the server above (405 Method Not Allowed) refers to a HTTP
method (probably GET) which is not a allowed on a certain resource. It
could be that the blog is
Sorry, my bad. :-/ Amended in new patch attached.
/Pär
2014-11-01 7:00 GMT+01:00 Darshit Shah dar...@gmail.com:
On 11/01, Darshit Shah wrote:
On 10/31, Pär Karlsson wrote:
Thanks for the tips, I was going crazy trying to make git to send the
emails via git send-email, and it just ended up
for git format-patch/send-email. Sorry about the spam :-/
Best regards,
/Pär
2014-10-30 20:54 GMT+01:00 feino...@gmail.com:
From: Pär Karlsson feino...@gmail.com
---
tests/ChangeLog | 12 +
tests/FTPServer.pm | 597
Regarding the Perl test suite, I'd be happy to clean up the code a little
bit, if you think it's worth it?
There are some minor issues with the current code (such as perl producing
certain warnings regarding invalid operators, i.e: Argument isn't
numeric in numeric eq (==) at WgetTests.pm line
No complaints from me, it applied cleanly, all tests OK. :-)
2014-10-27 21:53 GMT+01:00 Tim Rühsen tim.rueh...@gmx.de:
Am Samstag, 25. Oktober 2014, 11:09:48 schrieb Pär Karlsson:
Good point. I got carried away by the criticism against xrealloc being
too
expensive, etc, but you
be replaced.
FYI, if you want to work on CPU cycle optimization, use valgrind --
tool=callgrind for your wget command to be polished. The resulting file
can be
viewed with e.g. kcachegrind.
Tim
Am Freitag, 24. Oktober 2014, 19:27:43 schrieb Pär Karlsson:
Well, I wrote a little benchmark
is there a place where more than 5 strings are used...
to my knowledge :-) There's really nothing wrong with it, IMO :-)
Best regards,
/Pär
2014-10-23 22:01 GMT+02:00 Tim Rühsen tim.rueh...@gmx.de:
Am Dienstag, 21. Oktober 2014, 16:49:12 schrieb Yousong Zhou:
On 21 October 2014 16:17, Pär
October 2014 03:50, Pär Karlsson feino...@gmail.com wrote:
Hi, I fould a potential gotcha when playing with clang's code analysis
tool.
The concat_strings function silently stopped counting string lengths when
given more than 5 arguments. clang warned about potential garbage values
Thanks!
It didn't even occur to me to check this out. My only excuse is gratuitous
consistency and lack of pure C experience; a malloc() without a
corresponding sizeof() seemed a little arbitrary to me, but it makes sense
now :-)
/Pär
2014-10-21 17:46 GMT+02:00 Micah Cowan
of wget).
Best regards,
/Pär
Patch below:
diff --git a/src/ChangeLog b/src/ChangeLog
index d5aeca0..87abd85 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2014-10-20 Pär Karlsson feino...@gmail.com
+
+ * utils.c (concat_strings): got rid of double loop, cleaned up
, len);
p += len;
}
va_end (args);
+ ret = xrealloc (ret, charsize * total_length + 1);
*p = '\0';
return ret;
2014-10-20 22:14 GMT+02:00 Pär Karlsson feino...@gmail.com:
Thank you for your feedback and suggestions.
I thought about this during the weekend and figured it could
working ok with this patch.
This is my first patch to this list, by the way. I'd be happy to help out
more in the future.
Best regards,
/Pär Karlsson, Sweden
commit 2d855670e0e1fbe578506b376cdd40b0e465d3ef
Author: Pär Karlsson feino...@gmail.com
Date: Thu Oct 16 21:41:36 2014 +0200
22 matches
Mail list logo
