Hi,
I'd like to start contributing to wget. I've chosen
http://savannah.gnu.org/bugs/index.php?46584 for a good start.
Please let me know if attached patch is sane.
Thanks
Piotr
diff --git a/src/ftp.c b/src/ftp.c
index 39f20fa..e05d57b 100644
--- a/src/ftp.c
+++ b/src/ftp.c
@@ -1191,6 +1191,7
I've tried to tackle another bug. I've moved reading from .netrc file to
the end, when no user and no passwd is defined (for both http and ftp).
Please review.
Thanks
Piotr
diff --git a/src/ftp.c b/src/ftp.c
index 39f20fa..359cbce 100644
--- a/src/ftp.c
+++ b/src/ftp.c
@@ -360,11 +360,10 @@ get
Hi,
The case with stopping wget is obvious. CTRL+Z and bg should make wget
write to file and I can catch bg with SIGCONT.
But I wonder what to do when after CTRL+Z and bg, user runs fg. In this
case there's no signal between bg anf fg, and I can only check for
getpgrp() == tcgetpgrp(STDOUT_FILE
Sorry for incorrect Date email header in that email, I've send it from
previously suspended virtual machine that I forgot to ntpupdate.
Piotr
On 06/10/16 09:47, losgrandes wrote:
I've updated patch to not run tcgetpgrp, getpgrp and isatty (for
shell_is_interactive test) on windows.
I have com
Eli, you're awesome! :)
I tried many combinations (I think so), including LIBS=-liconv, but
without success. I've tried now and it works!
Now I'll test on my own.
Thanks
Piotr
On 07/10/16 09:08, Eli Zaretskii wrote:
From: losgrandes
Date: Thu, 6 Oct 2016 09:47:01 +0200
Fortunately I teste
From: losgrandes
Date: Thu, 6 Oct 2016 09:47:01 +0200
Fortunately I tested wget.exe in normal mode and background mode (-b). Was ok.
Unfortunately I haven't tested wget.exe with CTRL+Break/CTRL+C (is it really
works on windows?).
Yes, CTRL-C/CTRL-BREAK should work on Windows. What didn't wo
Can you please review my 3 patches?
Piotr
On 07/10/16 10:10, Wajda, Piotr wrote:
From: losgrandes
Date: Thu, 6 Oct 2016 09:47:01 +0200
Fortunately I tested wget.exe in normal mode and background mode
(-b). Was ok.
Unfortunately I haven't tested wget.exe with CTRL+Break/CTRL+C (is it
r
Sorry, I had the impression there was some discussion going on !?
My only confusion was that during testing on windows, when sending
CTRL+C or CTRL+Break it immediately terminates, which is basically what
I think it should do for CTRL+C. Not sure about CTRL+Break.
But the same behaviour was
Forgot to include mailinglist.
Forwarded Message
Subject: Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress
even when background
Date: Wed, 19 Oct 2016 12:18:13 +0200
From: Wajda, Piotr
To: Eli Zaretskii
For CTRL+Break we could probably go to backgrou
Yeah, I'll look into it.
Piotr
On 08/11/16 22:29, Tim Rühsen wrote:
On Dienstag, 8. November 2016 15:26:14 CET Dale R. Worley wrote:
I've been getting a script working, and as part of it, it appears that
-o does not work correctly. Specifically -o is supposed to send all
"messages" to a speci
Patch sent, should be good now.
Piotr
On 08/11/16 22:29, Tim Rühsen wrote:
On Dienstag, 8. November 2016 15:26:14 CET Dale R. Worley wrote:
I've been getting a script working, and as part of it, it appears that
-o does not work correctly. Specifically -o is supposed to send all
"messages" to
Hi Tim,
Just sent new version of this patch.
Shouldn't be any memleaks now.
Piotr
On 21/10/16 12:36, Tim Rühsen wrote:
Hi Piotr,
please include netrc.h in utils.c.
In getftp():
struct net_credentials *ftp_cred = malloc (sizeof *ftp_cred);
...
ftp_cred = pick_credentials()
This looks like
Hi All,
I've sent patch for this before already, but it hasn't been reviewed
yet. Besides logic correction, I've rebuilt/cleaned up code a bit.
Piotr
On 20/12/16 00:12, Vijeth Aradhya wrote:
Follow-up Comment #2, bug #48811 (project wget):
Hi Basin,
I'm new to the wget community, but I have
13 matches
Mail list logo
