Re: [Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-19 Thread Daniel Stenberg
On Wed, 19 Nov 2014, Darshit Shah wrote: I already have a few sanity checks for Wget in my pre-commit hook. Such things can be restyled for a server side update hook too. IMHO, it is better if you integrate those checks into the test suite or something so that contributors can figure them out

Re: [Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-19 Thread Tim Ruehsen
> > I think we should just have one xfree() macro instead of two (xfree and > > xfree_null, some parts of the code even use free() directly). > > I was looking into such things yesterday. Maybe we can write git hooks to > prevent known bad coding conventions from being pushed into the repository >

Re: [Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-18 Thread Darshit Shah
On 11/18, Giuseppe Scrivano wrote: Tim Rühsen writes: Fixes these warnings: gnutls.c:457:3: warning: Value stored to 'err' is never read err = 0; http-ntlm.c:477:5: warning: Value stored to 'size' is never read size = (size_t) snprintf (ntlmbuf, sizeof(ntl

Re: [Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-18 Thread Darshit Shah
Thanking You, Darshit Shah Sent from mobile device. Please excuse my brevity On 19-Nov-2014 1:24 am, "Tim Rühsen" wrote: > > Fixes these warnings: > > gnutls.c:457:3: warning: Value stored to 'err' is never read > err = 0; > > http-ntlm.c:477:5: warning: Value stored to '

Re: [Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-18 Thread Tim Rühsen
Am Dienstag, 18. November 2014, 21:07:41 schrieb Giuseppe Scrivano: > Tim Rühsen writes: > > Fixes these warnings: > > gnutls.c:457:3: warning: Value stored to 'err' is never read > > > > err = 0; > > > > http-ntlm.c:477:5: warning: Value stored to 'size' is never read > >

Re: [Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-18 Thread Giuseppe Scrivano
Tim Rühsen writes: > Fixes these warnings: > > gnutls.c:457:3: warning: Value stored to 'err' is never read > err = 0; > > http-ntlm.c:477:5: warning: Value stored to 'size' is never read > size = (size_t) snprintf (ntlmbuf, sizeof(ntlmbuf), > > http.c:1479:3: wa

[Bug-wget] [PATCH] Fix some clang-analyzer warnings

2014-11-18 Thread Tim Rühsen
Fixes these warnings: gnutls.c:457:3: warning: Value stored to 'err' is never read err = 0; http-ntlm.c:477:5: warning: Value stored to 'size' is never read size = (size_t) snprintf (ntlmbuf, sizeof(ntlmbuf), http.c:1479:3: warning: Attempt to free rel