[Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-11 Thread Tim Rühsen
Hi Martin, having an abort() without a message is simply a big waste of time for any developer who stumbles upon it. Since the init code of Wget has to be rewritten anyways, i provide the fastest solution right now: increasing the buffer size and printing a message before Wget aborts. And yes

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-12 Thread Giuseppe Scrivano
Tim Rühsen writes: > having an abort() without a message is simply a big waste of time for any > developer who stumbles upon it. I disagree here, what is so difficult that a debugger cannot catch? On the other hand, I agree this can be improved. > Since the init code of Wget has to be rewri

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-12 Thread Tim Rühsen
Am Sonntag, 12. Mai 2013 schrieb Giuseppe Scrivano: > Tim Rühsen writes: > > > having an abort() without a message is simply a big waste of time for any > > developer who stumbles upon it. > > I disagree here, what is so difficult that a debugger cannot catch? On > the other hand, I agree this

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-12 Thread Ángel González
On 12/05/13 21:50, Tim Rühsen wrote: > A real solution would be a rewrite of the init stuff (I saw that already > somewhere on the Wget 2.0 wish list or somewhere - don't remeber exactly). > > I already wrote this kind of code and would contribute it to Wget. > But i am unshure how to apply it to

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-13 Thread Tim Rühsen
Am Sonntag, 12. Mai 2013 schrieb Ángel González: > On 12/05/13 21:50, Tim Rühsen wrote: > > A real solution would be a rewrite of the init stuff (I saw that already > > somewhere on the Wget 2.0 wish list or somewhere - don't remeber exactly). > > > > I already wrote this kind of code and would co

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-13 Thread Bykov Aleksey
Greetings, Tim Rühsen. Possible that i'm understood wrong, but according to http://www.mingw.org/wiki/C99 MinGW doesn't support C99 at all. So i'm not sure about cross-compile. May be after implementation of C99 code it can be compiled only through CygWin (don't remember exactly, but two years ago

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-13 Thread Tim Rühsen
Hi Alex, yes, it is the _PC_NAME_MAX issue which is only valid for pathconf(). Attached is the little patch to fix it. Since MinGW is based on gcc-4.6, C99 should be available. As the Wiki states (well, the entry is 3 years old...), printf() is the main issue. But there may be some other functi

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-14 Thread Bykov Aleksey
Greetings, Tim Rühsen About C99 - sorry, i think "If article isn't changed/removed then it's still actually". Yes, in MinGW mailing lists i find mention about "-std=c99" and "changes to mingw_snprintf". Sorry for mistake. May be it's time for new test branch - "wget-C99"? And then find what fragm

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-15 Thread Tim Rühsen
Hi Alex, snprintf %a seems to print the correct result with wine (set to WinXP), but the same executable on a real WinXP just prints 'a'. Replacing the sprintf() by __mingw_sprintf printed the correct result with wine and on the WinXP machine. > About C99 - sorry, i think "If article isn't cha

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-15 Thread Giuseppe Scrivano
Tim Rühsen writes: > Hi Alex, > > yes, it is the _PC_NAME_MAX issue which is only valid for pathconf(). > > Attached is the little patch to fix it. > > Since MinGW is based on gcc-4.6, C99 should be available. > As the Wiki states (well, the entry is 3 years old...), printf() is the main > issue

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-16 Thread Tim Rühsen
Am Donnerstag, 16. Mai 2013 schrieb Giuseppe Scrivano: > Tim Rühsen writes: > > > Hi Alex, > > > > yes, it is the _PC_NAME_MAX issue which is only valid for pathconf(). > > > > Attached is the little patch to fix it. > > > > Since MinGW is based on gcc-4.6, C99 should be available. > > As the Wik