Re: [Bug-wget] Compilation Error when without-ssl is selected

2016-04-27 Thread Tim Rühsen
Hi Ygal. > Sorry for seeing this only now, but I've noticed that the patch file I've > sent included my work e-mail and not my private. Can you please change it > to ygal.b...@gmail.com. Though it is a minor fix, it should come from my > personal e-mail. Sorry, it is too late. Your email is now p

Re: [Bug-wget] Compilation Error when without-ssl is selected

2016-04-27 Thread Ygal Blum
Hi Tim, Sorry for seeing this only now, but I've noticed that the patch file I've sent included my work e-mail and not my private. Can you please change it to ygal.b...@gmail.com. Though it is a minor fix, it should come from my personal e-mail. Thanks, Ygal On Fri, Dec 4, 2015 at 4:54 PM Tim Ru

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-12-04 Thread Tim Ruehsen
Pushed (slightly amended). Tim On Friday 04 December 2015 13:09:50 Darshit Shah wrote: > On 12/04, Tim Rühsen wrote: > >Hi Darshit, > > > >regarding the SKIP, a little patch proposal based on your commits. > > > >Feel free to merge it with your changes (if you agree on using SKIP). > > Looks goo

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-12-04 Thread Darshit Shah
On 12/04, Tim Rühsen wrote: Hi Darshit, regarding the SKIP, a little patch proposal based on your commits. Feel free to merge it with your changes (if you agree on using SKIP). Looks good. Feel free to push it instead of mine. Also, the https test passes due to the same bug as earlier. I'll

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-12-04 Thread Tim Ruehsen
Hi Darshit, regarding the SKIP, a little patch proposal based on your commits. Feel free to merge it with your changes (if you agree on using SKIP). Tim On Thursday 03 December 2015 17:21:52 Darshit Shah wrote: > On 11/24, Tim Rühsen wrote: > >Hi Ygal, > > > >many thanks for the patch. > > > >A

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-12-04 Thread Tim Ruehsen
Hi Darshit, in your patch you forgot to remove the HTTPS tests, they are executed even when SSL_TESTS is empty. Interestingly, they still pass (another bug ?): # testenv/Test--https.log # Setting --no-config (noconfig) to 1 Usage: wget [OPTION]... [URL]... Try `wget --help' for more opt

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-12-03 Thread Darshit Shah
On 11/24, Tim Rühsen wrote: Hi Ygal, many thanks for the patch. An interesting side effect of testing './configure --without-ssl' is that there are at least three issues with the python test suite. I made up patches for two of them (attached). @Darshit Could you review 0001-Fix-python-test-su

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-11-24 Thread Darshit Shah
Thanks for the patches. I'll take a look later today or tomorrow to see what exactly is wrong with the tests / test suite. With this, we should be in a position to have constant reporting with Travis. On 11/24, Tim Rühsen wrote: Hi Ygal, many thanks for the patch. An interesting side effect

Re: [Bug-wget] Compilation Error when without-ssl is selected

2015-11-24 Thread Tim Ruehsen
Hi Ygal, many thanks for the patch. An interesting side effect of testing './configure --without-ssl' is that there are at least three issues with the python test suite. I made up patches for two of them (attached). @Darshit Could you review 0001-Fix-python-test-suite-return-value.patch ? - Y

[Bug-wget] Compilation Error when without-ssl is selected

2015-11-24 Thread Ygal Blum
Hi, When selecting without-ssl during configuration the compilation breaks. Please find attached the patch with the fix. Best Regards, Ygal Blum From 1cb3af1e5b392ac2fae6d9ed8b5d7be399d9f37e Mon Sep 17 00:00:00 2001 From: Ygal Blum Date: Tue, 24 Nov 2015 11:24:54 +0200 Subject: [PATCH] Fix compi