Hi all,
I found two issues in path checking code in cookie.c.
In cookie_handle_set_cookie(), path in Set-Cookie header should be
checked so as not to be accepted when it is upper than that of
requested document.
However, current implementation works as:
- check_path_match() validate the path
Hi Yasuhisa,
Thanks for the patch. The cookie domain patch checking code in Wget
was old and only based on a heuristic. However, we are currently in
the process of using libpsl a library that handles this for us. I have
submitted a patch which is currently in the pipeline that adds support
for usi
Hi Darshit,
Sorry to be late. I have never used git so it takes long for me to learn
how to generate path using git.
I’m not sure I have done it well. If there are something wrong with this
attachment, please correct.
0001-2014-06-12-Yasuhisa-Ishikawa-yasuhisa.ishikawa-kuman.patch
Descripti
cookies.c:727:59: warning: pointer/integer type mismatch in
conditional expression ('char *' and 'int')
[-Wconditional-type-mismatch]
if (!check_path_match (cookie->path, trailing_slash ?
strdupdelim (path, trailing_slash + 1) : '/'))
Hi Yasuhisa,
Thanks a lot or the patch file! However, I a
Darshit,
Sorry, I’m not familiar with git and "git clone”ed branch so I could not run
make before.
I hope this work….
0001-2014-06-16-Yasuhisa-Ishikawa-yasuhisa.ishikawa-kuman.patch
Description: Binary data
Yasuhisa Ishikawa
2014/06/16 18:06、Darshit Shah のメール：
> cookies.c:727:59: warni
