Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-11 Thread Eli Zaretskii
> From: "YX Hao" > Cc: > Date: Sun, 5 Nov 2017 23:01:22 +0800 > > And I can tell you that 'GetConsoleOutputCP' returns the codepage as command > 'chcp'. It is right. The gnu 'vsnprintf' doesn't work right with 'setlocale' > omitted. I guess this means wget needs to call 'setlocale' with the rig

Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-05 Thread Eli Zaretskii
> From: "YX Hao" > Cc: > Date: Sun, 5 Nov 2017 23:01:22 +0800 > > >> '_getmbcp' is used > > Maybe the problem is that the codepage used for the console output is > > different from the system's ANSI codepage? What does GetConsoleOutputCP > > return in the case you describe? > > > > What happens

Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-05 Thread YX Hao
Hi Eli, > From: Eli Zaretskii [mailto:e...@gnu.org] > Sent: 2017年11月4日 16:53 > > What do you mean by "gnu printf related functions"? If this is a build that > doesn't define ENABLE_NLS, then wget outputs the original text using the MS > runtime versions of printf. And in a build that does define

Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-04 Thread Eli Zaretskii
> From: "YX Hao" > Cc: "'Eli Zaretskii'" > Date: Fri, 3 Nov 2017 20:14:02 +0800 > > Second, as my test, 'setlocale' is needed for the gnu printf related > functions to work correctly on mutibyte characters. You can see that as > attached screensots: > setlocale_936.png > setlocale_empty.png > se

Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-03 Thread YX Hao
Hi Eli and maintainers, > From: Eli Zaretskii [mailto:e...@gnu.org] > Sent: 2017年11月3日 0:15 > > I'm not Tim, but I have a few questions about your patches. I thought just Tim is active, by my previous experiences. :) Thanks for your work and answers. > > > 1. setlocale > Can you explain why you

Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-02 Thread Eli Zaretskii
> From: "YX Hao" > Date: Thu, 2 Nov 2017 21:09:31 +0800 > > During my daily use, I've found a few small bugs and made the patches. > I will email them in standalone topics. Patch is attached. > > I made the patch on Windows. I think it shouldn't break anything on other > platforms. Please take a

[Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows

2017-11-02 Thread YX Hao
Dear Tim, During my daily use, I've found a few small bugs and made the patches. I will email them in standalone topics. Patch is attached. I made the patch on Windows. I think it shouldn't break anything on other platforms. Please take a review :) Best Regards, YX Hao wget_v1.9.2_Fix printi