Hello,
Dmitry Bogatov writes:
> -request_set_method (req, meth, meth_arg);
> +req = request_new(meth, meth_arg);
I have amended this change:
> +req = request_new (meth, meth_arg);
and I am going to push it.
Thanks for your contribution!
Giuseppe
> ...
> We still need to set meth to opt.method. The method string is only ensured
> to be uppercase at this moment.
Thanks. Fixed this too.
>From 1a1247b7bded577def4572ff1a8f1eb76739858b Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov
Date: Wed, 8 May 2013 18:10:55 +0400
Subject: [PATCH] Non-functi
>
> Giuseppe Scrivano writes:
> > Now you can assume opt.method is already uppercase as this is already
> > enforced in cmd_string_uppercase (init.c).
> >
> > Please take a look at the commit 550457.
> My bad. Here is fixed version.
>
On Thu, May 9, 2013 at 12:21 PM, Dmitry Bogatov wrote:
-
Giuseppe Scrivano writes:
> Now you can assume opt.method is already uppercase as this is already
> enforced in cmd_string_uppercase (init.c).
>
> Please take a look at the commit 550457.
My bad. Here is fixed version.
>From dfb31c06db0ea98dfc8f08c20c8ec1de1f7ed0ca Mon Sep 17 00:00:00 2001
From
Dmitry Bogatov writes:
> - meth = opt.method;
> + {
> +char *q;
> +for (q = opt.method; *q; ++q)
> + *q = c_toupper (*q);
> +meth = opt.method;
> + }
this code should go. Now you can assume opt.method is already uppercase
as this is already enforc
>> Giuseppe pushed a patch with that change a few days ago.. Please rebase it
>> onto the master branch.
> Good idea, but as Darshit said, please rebase it onto the master
> branch. I will be offline for the next few days, I will review it
> when I am back.
Here it is: >From 6b35e408194bb197053
Darshit Shah writes:
>>
>> In comment to `request_new` was that it *always* must be followed by
>> `request_set_method`. I changed code to combine these functionality into
>> single function. Please, review.
>
> Looks good to me.
> Just one thing though, the method string is now converted to upp
>
> In comment to `request_new` was that it *always* must be followed by
> `request_set_method`. I changed code to combine these functionality into
> single function. Please, review.
>
Looks good to me.
Just one thing though, the method string is now converted to uppercase
through cmd_string_upper
In comment to `request_new` was that it *always* must be followed by
`request_set_method`. I changed code to combine these functionality into
single function. Please, review.
>From 4e2a98f3746400846486de0e57b4d68e654622f3 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov
Date: Wed, 8 May 2013 18:10:5
