Re: ipmi problem introduced with sys/conf.h 1.150 enodev->selfalse

2020-06-29 Thread Martin Pieuchot
On 28/06/20(Sun) 22:17, Stuart Henderson wrote: > Thanks to Jens A. Griepentrog for reporting and bisecting, we discovered > that sys/conf.h r1.150 broke /dev/ipmi. I found a machine to test on and > reverting the commit fixes things, but given the commit message I guess > the diff below (which als

Re: mg: crash on re-search with a file containing an empty line

2020-06-29 Thread Hiltjo Posthuma
On Sun, Jun 28, 2020 at 08:10:05PM +0200, Theo Buehler wrote: > On Sun, Jun 28, 2020 at 06:58:22PM +0200, Hiltjo Posthuma wrote: > > Hi, > > > > I noticed a bug in mg with regex search. > > > > A way to reproduce the issue: > > > > * Create a file with atleast one empty line, for example: > > >

dev/usb/xhci.c, assertion "sc->sc_cmd_trb == trb" failed

2020-06-29 Thread Stuart Henderson
I have a uaudio that sometimes detaches/reattaches itself from my workstation. I think it maybe a problem with the cable, anyway the more interesting thing is that this acts as a "chaos monkey" and seems good at triggering problems in various parts of the stack :) Here's an xhci panic I encountere

Re: vmd linux guests unexpectedly hangs and time skew issue

2020-06-29 Thread Martin
Hi Pratik, Could you recommend some way how to enable tsc in Linux explicitly? I use Linux 5.4.43-1-virt #Alpine SMP mini build for virtual machines out of the box, and finally getting tsc error every boot with clock skew. I can't move to current on production machine. Maybe some patches availa

Re: dev/usb/xhci.c, assertion "sc->sc_cmd_trb == trb" failed

2020-06-29 Thread Gerhard Roth
Hi Stuart, what happens here is that the timeout kicks in and xhci_command_submit() resets sc_cmd_trb to NULL. But that doesn't retire the TRB that is still active in the controller and when it is done later, the KASSERT() in xhci_event_command() is bound to fail. My proposed fix would be: 1) xh

Re: mg: crash on re-search with a file containing an empty line

2020-06-29 Thread Theo Buehler
On Mon, Jun 29, 2020 at 01:17:56PM +0200, Hiltjo Posthuma wrote: > Hi, > > Thanks for looking into it, it looks better. > > With this patch I noticed re_backsrch() does not work fully correct yet. > > I think the line: > > > + regex_match[0].rm_so < tbo) { > > should be: > > > +

Re: dev/usb/xhci.c, assertion "sc->sc_cmd_trb == trb" failed

2020-06-29 Thread Stuart Henderson
On 2020/06/29 14:32, Gerhard Roth wrote: > Hi Stuart, > > what happens here is that the timeout kicks in and xhci_command_submit() > resets sc_cmd_trb to NULL. But that doesn't retire the TRB that is still > active in the controller and when it is done later, the KASSERT() in > xhci_event_command(