segmentation fault in opensmtpd mda

2023-03-18 Thread pjp
>Synopsis: segmentation fault in opensmtpd mda >Category: system >Environment: System : OpenBSD 7.2 Details : OpenBSD 7.2 (GENERIC.MP) #2: Thu Nov 24 23:53:03 MST 2022 r...@syspatch-72-arm64.openbsd.org:/usr/src/sys/arch/arm64/compile/GEN

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Peter J. Philipp
On Sat, Mar 18, 2023 at 03:06:43PM +0100, p...@delphinusdns.org wrote: > >Synopsis:segmentation fault in opensmtpd mda > >Category:system > >Environment: > System : OpenBSD 7.2 > Details : OpenBSD 7.2 (GENERIC.MP) #2: Thu Nov 24 23:53:03 MST 2022 >

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Omar Polo
On 2023/03/18 15:06:43 +0100, p...@delphinusdns.org wrote: > >Synopsis:segmentation fault in opensmtpd mda > >Category:system > >Environment: > System : OpenBSD 7.2 > Details : OpenBSD 7.2 (GENERIC.MP) #2: Thu Nov 24 23:53:03 MST 2022 > > r...@sy

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Todd C . Miller
Thanks, I was unable to get a backtrace so this really helped. I think the safest thing to do is to just return an error if the expanded string is NULL. I'm not sure if there are other expansions that can also be NULL here. Alternately, we could move the check to be specific to the else

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Peter J. Philipp
On Sat, Mar 18, 2023 at 01:10:49PM -0600, Todd C. Miller wrote: > Thanks, I was unable to get a backtrace so this really helped. I > think the safest thing to do is to just return an error if the > expanded string is NULL. I'm not sure if there are other expansions > that can also be NULL here. >

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Omar Polo
On 2023/03/18 13:10:49 -0600, "Todd C. Miller" wrote: > Thanks, I was unable to get a backtrace so this really helped. I > think the safest thing to do is to just return an error if the > expanded string is NULL. I'm not sure if there are other expansions > that can also be NULL here. > > Alter

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Todd C . Miller
On Sat, 18 Mar 2023 21:17:36 +0100, Omar Polo wrote: > If cscope is not missing anything, mda_expand_token is only called by > mda_expand_format which is only called by mda_unpriv. > > Now, mda_unpriv() always pass a NULL mda_command the first time (the > last argument) In smtpd.conf, under FORMA

Re: segmentation fault in opensmtpd mda

2023-03-18 Thread Omar Polo
On 2023/03/18 15:58:14 -0600, Todd C. Miller wrote: > On Sat, 18 Mar 2023 21:17:36 +0100, Omar Polo wrote: > > > If cscope is not missing anything, mda_expand_token is only called by > > mda_expand_format which is only called by mda_unpriv. > > > > Now, mda_unpriv() always pass a NULL mda_command

Re: stuck after attaching scsibus at softraid0

2023-03-18 Thread Jonathan Matthew
On Fri, Mar 17, 2023 at 10:26:55PM +0100, Paul de Weerd wrote: > I've gotten a lot further now, and can report things are not > completely not working .. they're just .. s l o w. > > I built a kernel with AHCI_DEBUG and some printf's in init_main.c > and a rather stupid diff for amd64's dkcsum