Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Mikolaj Kucharski
A question below.. On Wed, Feb 03, 2021 at 11:22:16AM +, Mikolaj Kucharski wrote: > On Wed, Feb 03, 2021 at 11:10:45AM +, Edd Barrett wrote: > > Hi, > > > > CCing ratchov@ and kettenis@ with some context. > > > > In short: my change broke ugen, which expects to scan up the interface > >

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Mark Kettenis
> Date: Wed, 3 Feb 2021 12:51:02 +0100 > From: Marcus Glocker > > On Wed, 3 Feb 2021 11:41:17 + > Edd Barrett wrote: > > > On Wed, Feb 03, 2021 at 11:17:01AM +, Stuart Henderson wrote: > > > btw the problem was seen with umb, it's not just ugen. > > > > From mglocker@'s explanation,

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Marcus Glocker
Hello Gerhard, On Wed, 3 Feb 2021 13:20:19 +0100 Gerhard Roth wrote: > On 2/3/21 12:51 PM, Marcus Glocker wrote: > > On Wed, 3 Feb 2021 11:41:17 + > > Edd Barrett wrote: > > > >> On Wed, Feb 03, 2021 at 11:17:01AM +, Stuart Henderson wrote: > >>> btw the problem was seen with umb,

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Gerhard Roth
On 2/3/21 12:51 PM, Marcus Glocker wrote: On Wed, 3 Feb 2021 11:41:17 + Edd Barrett wrote: On Wed, Feb 03, 2021 at 11:17:01AM +, Stuart Henderson wrote: btw the problem was seen with umb, it's not just ugen. From mglocker@'s explanation, I understood that it is the ugen driver

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Marcus Glocker
On Wed, 3 Feb 2021 11:41:17 + Edd Barrett wrote: > On Wed, Feb 03, 2021 at 11:17:01AM +, Stuart Henderson wrote: > > btw the problem was seen with umb, it's not just ugen. > > From mglocker@'s explanation, I understood that it is the ugen driver > trying to attach to some part of the

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Edd Barrett
On Wed, Feb 03, 2021 at 11:17:01AM +, Stuart Henderson wrote: > btw the problem was seen with umb, it's not just ugen. >From mglocker@'s explanation, I understood that it is the ugen driver trying to attach to some part of the device that in turn hoses umb for the same device? Maybe I

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Mikolaj Kucharski
On Wed, Feb 03, 2021 at 11:10:45AM +, Edd Barrett wrote: > Hi, > > CCing ratchov@ and kettenis@ with some context. > > In short: my change broke ugen, which expects to scan up the interface > range until an interface doesn't exist. > > On Wed, Feb 03, 2021 at 06:25:48AM +0100, Marcus

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Stuart Henderson
On 2021/02/03 11:10, Edd Barrett wrote: > Hi, > > CCing ratchov@ and kettenis@ with some context. > > In short: my change broke ugen, which expects to scan up the interface > range until an interface doesn't exist. btw the problem was seen with umb, it's not just ugen. > On Wed, Feb 03, 2021

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-03 Thread Edd Barrett
Hi, CCing ratchov@ and kettenis@ with some context. In short: my change broke ugen, which expects to scan up the interface range until an interface doesn't exist. On Wed, Feb 03, 2021 at 06:25:48AM +0100, Marcus Glocker wrote: > > Index: dev/usb/usbdi.c >

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Marcus Glocker
On Wed, Feb 03, 2021 at 05:11:41AM +, Mikolaj Kucharski wrote: > On Tue, Feb 02, 2021 at 10:02:57AM +, Edd Barrett wrote: > > Hi, > > > > Apologies for breaking stuff. > > No worries. > > > On Tue, Feb 02, 2021 at 07:24:34AM +0100, Marcus Glocker wrote: > > > Edd: > > > Can you please

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Marcus Glocker
On Tue, Feb 02, 2021 at 10:01:32PM +, Mikolaj Kucharski wrote: > Hi Marcus, > > Below diff makes umb(4) work for me. All good now. Cool, thanks for testing Mikolaj. So OK if I commit this fix Edd, Stuart? Index: dev/usb/usbdi.c

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Mikolaj Kucharski
On Tue, Feb 02, 2021 at 10:02:57AM +, Edd Barrett wrote: > Hi, > > Apologies for breaking stuff. No worries. > On Tue, Feb 02, 2021 at 07:24:34AM +0100, Marcus Glocker wrote: > > Edd: > > Can you please also double check if this still works with your > > uaudio(4) device? > > My device

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Mikolaj Kucharski
Hi Marcus, Below diff makes umb(4) work for me. All good now. OpenBSD 6.8-current (GENERIC.MP) #166: Tue Feb 2 21:51:12 UTC 2021 r...@pc1.home.local:/home/mkucharski/openbsd/src/sys/arch/amd64/compile/GENERIC.MP real mem = 4259872768 (4062MB) avail mem = 4115435520 (3924MB) random: good

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Edd Barrett
On Tue, Feb 02, 2021 at 02:28:52PM +0100, Marcus Glocker wrote: > Because of that ugen(4) calls usbd_deactivate(), > and the device is busted ... I see. And it looks like that device is also not compliant: its interfaces are again, non-contiguous. > Now we can argue whether the behavior of

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Marcus Glocker
On Tue, Feb 02, 2021 at 10:35:38AM +, Stuart Henderson wrote: > On 2021/02/02 10:02, Edd Barrett wrote: > > Hi, > > > > Apologies for breaking stuff. > > > > On Tue, Feb 02, 2021 at 07:24:34AM +0100, Marcus Glocker wrote: > > > Edd: > > > Can you please also double check if this still works

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Stuart Henderson
On 2021/02/02 10:02, Edd Barrett wrote: > Hi, > > Apologies for breaking stuff. > > On Tue, Feb 02, 2021 at 07:24:34AM +0100, Marcus Glocker wrote: > > Edd: > > Can you please also double check if this still works with your > > uaudio(4) device? > > My device works with your diff. > > But, I'm

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-02 Thread Edd Barrett
Hi, Apologies for breaking stuff. On Tue, Feb 02, 2021 at 07:24:34AM +0100, Marcus Glocker wrote: > Edd: > Can you please also double check if this still works with your > uaudio(4) device? My device works with your diff. But, I'm not sure I understand why the change broke the device. Maybe we

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Marcus Glocker
On Mon, Feb 01, 2021 at 10:16:37PM +, Mikolaj Kucharski wrote: > On Mon, Feb 01, 2021 at 10:57:43PM +0100, Marcus Glocker wrote: > > Ok. Then it was the usbd_device2interface_handle() change. > > Fixed one device (uaudio), broke the other device (umb) :-| > > Now lets see if we can find

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Mikolaj Kucharski
On Mon, Feb 01, 2021 at 10:16:37PM +, Mikolaj Kucharski wrote: > On Mon, Feb 01, 2021 at 10:57:43PM +0100, Marcus Glocker wrote: > > Ok. Then it was the usbd_device2interface_handle() change. > > Fixed one device (uaudio), broke the other device (umb) :-| > > Now lets see if we can find

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Mikolaj Kucharski
On Mon, Feb 01, 2021 at 10:57:43PM +0100, Marcus Glocker wrote: > Ok. Then it was the usbd_device2interface_handle() change. > Fixed one device (uaudio), broke the other device (umb) :-| > Now lets see if we can find something common to make both > work. Can you please send an lsusb -v of your

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Marcus Glocker
Ok. Then it was the usbd_device2interface_handle() change. Fixed one device (uaudio), broke the other device (umb) :-| Now lets see if we can find something common to make both work. Can you please send an lsusb -v of your umb? On Mon, Feb 01, 2021 at 09:39:43PM +, Mikolaj Kucharski wrote:

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Mikolaj Kucharski
Bingo! After applying your revert diff, umb0 works as expected: # ifconfig umb0 umb0: flags=8855 mtu 1500 index 7 priority 6 llprio 3 roaming disabled registration home network state up cell-class LTE rssi -99dBm speed 47.7Mbps up 286Mbps down SIM initialized PIN

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Marcus Glocker
Thanks. There were some changes going in that area recently. I think we need to try reverting some of them, and see which fixes it. Lets start with the most obvious one. Does this change anything? Index: dev/usb/usbdi.c === RCS

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Marcus Glocker
Can you also send a dmesg of the last working kernel please? On Mon, Feb 01, 2021 at 08:03:29PM +, miko...@kucharski.name wrote: > >Synopsis:umb(4) not working, ifconfig: SIOCGWG: Device not configured > >Category:kernel > >Environment: > System : OpenBSD 6.8 >

Re: 6.8-current ifconfig umb0 and Device not configured

2021-02-01 Thread Mikolaj Kucharski
Here dmesg when umb0 works: OpenBSD 6.8-current (GENERIC.MP) #157: Sat Jan 23 22:27:44 UTC 2021 r...@pc1.home.local:/home/mkucharski/openbsd/src/sys/arch/amd64/compile/GENERIC.MP real mem = 4259872768 (4062MB) avail mem = 4115431424 (3924MB) random: good seed from bootblocks mpath0 at root