bbolt can freeze 7.2 from userspace

2022-10-28 Thread Renato Aguiar
Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering some sort of deadlock in mmap because threads get stuck at vmmaplk. I managed to reproduce it consistently in a laptop with 4 cores (i5-1135G7) using one unit test from bbolt: $ doas pkg_add git go $ git clone https://gi

Re: bbolt can freeze 7.2 from userspace

2022-12-17 Thread David Hill
On 10/28/22 03:46, Renato Aguiar wrote: Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering some sort of deadlock in mmap because threads get stuck at vmmaplk. I managed to reproduce it consistently in a laptop with 4 cores (i5-1135G7) using one unit test from bbolt:

Re: bbolt can freeze 7.2 from userspace

2022-12-17 Thread Jacqueline Jolicoeur
On Dec 17 14:15, David Hill wrote: > > On 10/28/22 03:46, Renato Aguiar wrote: > > Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering > > some > > sort of deadlock in mmap because threads get stuck at vmmaplk. > > > > I managed to reproduce it consistently in a laptop with

Re: bbolt can freeze 7.2 from userspace

2022-12-18 Thread Martin Pieuchot
On 17/12/22(Sat) 14:15, David Hill wrote: > > > On 10/28/22 03:46, Renato Aguiar wrote: > > Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering > > some > > sort of deadlock in mmap because threads get stuck at vmmaplk. > > > > I managed to reproduce it consistently in a la

Re: bbolt can freeze 7.2 from userspace

2022-12-21 Thread Martin Pieuchot
On 18/12/22(Sun) 20:55, Martin Pieuchot wrote: > On 17/12/22(Sat) 14:15, David Hill wrote: > > > > > > On 10/28/22 03:46, Renato Aguiar wrote: > > > Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering > > > some > > > sort of deadlock in mmap because threads get stuck at vmm

Re: bbolt can freeze 7.2 from userspace

2022-12-21 Thread David Hill
On 12/21/22 05:33, Martin Pieuchot wrote: On 18/12/22(Sun) 20:55, Martin Pieuchot wrote: On 17/12/22(Sat) 14:15, David Hill wrote: On 10/28/22 03:46, Renato Aguiar wrote: Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering some sort of deadlock in mmap because threads

Re: bbolt can freeze 7.2 from userspace

2022-12-21 Thread David Hill
On 12/21/22 07:08, David Hill wrote: On 12/21/22 05:33, Martin Pieuchot wrote: On 18/12/22(Sun) 20:55, Martin Pieuchot wrote: On 17/12/22(Sat) 14:15, David Hill wrote: On 10/28/22 03:46, Renato Aguiar wrote: Use of bbolt Go library causes 7.2 to freeze. I suspect it is triggering some

Re: bbolt can freeze 7.2 from userspace

2022-12-21 Thread Martin Pieuchot
On 21/12/22(Wed) 09:20, David Hill wrote: > > > On 12/21/22 07:08, David Hill wrote: > > > > > > On 12/21/22 05:33, Martin Pieuchot wrote: > > > On 18/12/22(Sun) 20:55, Martin Pieuchot wrote: > > > > On 17/12/22(Sat) 14:15, David Hill wrote: > > > > > > > > > > > > > > > On 10/28/22 03:46, Re

Re: bbolt can freeze 7.2 from userspace

2022-12-21 Thread David Hill
On 12/21/22 11:23, Martin Pieuchot wrote: On 21/12/22(Wed) 09:20, David Hill wrote: On 12/21/22 07:08, David Hill wrote: On 12/21/22 05:33, Martin Pieuchot wrote: On 18/12/22(Sun) 20:55, Martin Pieuchot wrote: On 17/12/22(Sat) 14:15, David Hill wrote: On 10/28/22 03:46, Renato Aguia

Re: bbolt can freeze 7.2 from userspace

2023-01-20 Thread Martin Pieuchot
Hello David, On 21/12/22(Wed) 11:37, David Hill wrote: > On 12/21/22 11:23, Martin Pieuchot wrote: > > On 21/12/22(Wed) 09:20, David Hill wrote: > > > On 12/21/22 07:08, David Hill wrote: > > > > On 12/21/22 05:33, Martin Pieuchot wrote: > > > > > On 18/12/22(Sun) 20:55, Martin Pieuchot wrote: > >

Re: bbolt can freeze 7.2 from userspace

2023-01-23 Thread David Hill
On 1/20/23 09:02, Martin Pieuchot wrote: Hello David, On 21/12/22(Wed) 11:37, David Hill wrote: On 12/21/22 11:23, Martin Pieuchot wrote: On 21/12/22(Wed) 09:20, David Hill wrote: On 12/21/22 07:08, David Hill wrote: On 12/21/22 05:33, Martin Pieuchot wrote: On 18/12/22(Sun) 20:55, Marti

Re: bbolt can freeze 7.2 from userspace

2023-01-23 Thread Renato Aguiar
Hi Martin, "David Hill" writes: > > Yes, same result as before. This patch does not seem to help. > I could also reproduce it with patched 'current' :( -- Renato

Re: bbolt can freeze 7.2 from userspace

2023-01-29 Thread Martin Pieuchot
On 23/01/23(Mon) 22:57, David Hill wrote: > On 1/20/23 09:02, Martin Pieuchot wrote: > > > [...] > > > Ran it 20 times and all completed and passed. I was also able to > > > interrupt > > > it as well. no issues. > > > > > > Excellent! > > > > Here's the best fix I could come up with. We ma

Re: bbolt can freeze 7.2 from userspace

2023-01-29 Thread Mark Kettenis
> Date: Sun, 29 Jan 2023 12:31:22 +0100 > From: Martin Pieuchot > > On 23/01/23(Mon) 22:57, David Hill wrote: > > On 1/20/23 09:02, Martin Pieuchot wrote: > > > > [...] > > > > Ran it 20 times and all completed and passed. I was also able to > > > > interrupt > > > > it as well. no issues. >

Re: bbolt can freeze 7.2 from userspace

2023-01-29 Thread Martin Pieuchot
On 29/01/23(Sun) 14:36, Mark Kettenis wrote: > > Date: Sun, 29 Jan 2023 12:31:22 +0100 > > From: Martin Pieuchot > > > > On 23/01/23(Mon) 22:57, David Hill wrote: > > > On 1/20/23 09:02, Martin Pieuchot wrote: > > > > > [...] > > > > > Ran it 20 times and all completed and passed. I was also ab

Re: bbolt can freeze 7.2 from userspace

2023-02-17 Thread David Hill
On 12/17/22 14:15, David Hill wrote: ddb{3}> trace /t 0t409572 sleep_finish(8000344d1fd0,1) at sleep_finish+0xfe rw_enter(fd821cbcb220,21) at rw_enter+0x232 vm_map_lock_ln(fd821cbcb188,81f22ed0,6e7) at vm_map_lock_ln+0x92 uvmfault_lookup at uvmfault_lookup+0x73 uvm_fault_

Re: bbolt can freeze 7.2 from userspace

2023-02-18 Thread Martin Pieuchot
On 24/01/23(Tue) 04:40, Renato Aguiar wrote: > Hi Martin, > > "David Hill" writes: > > > > > Yes, same result as before. This patch does not seem to help. > > > > I could also reproduce it with patched 'current' :( Here's another possible fix I came up with. The idea is to deliberately allow

Re: bbolt can freeze 7.2 from userspace

2023-02-18 Thread Josh Rickmar
On Sat, Feb 18, 2023 at 09:23:06AM +0100, Martin Pieuchot wrote: > On 24/01/23(Tue) 04:40, Renato Aguiar wrote: > > Hi Martin, > > > > "David Hill" writes: > > > > > > > > Yes, same result as before. This patch does not seem to help. > > > > > > > I could also reproduce it with patched 'curren

Re: bbolt can freeze 7.2 from userspace

2023-02-18 Thread David Hill
On 2/18/23 03:23, Martin Pieuchot wrote: On 24/01/23(Tue) 04:40, Renato Aguiar wrote: Hi Martin, "David Hill" writes: Yes, same result as before. This patch does not seem to help. I could also reproduce it with patched 'current' :( Here's another possible fix I came up with. The id

Re: bbolt can freeze 7.2 from userspace

2023-02-19 Thread Renato Aguiar
"Martin Pieuchot" writes: > On 24/01/23(Tue) 04:40, Renato Aguiar wrote: >> Hi Martin, >> >> "David Hill" writes: >> >> > >> > Yes, same result as before. This patch does not seem to help. >> > >> >> I could also reproduce it with patched 'current' :( > > Here's another possible fix I came up

Re: bbolt can freeze 7.2 from userspace

2023-02-20 Thread Martin Pieuchot
On 20/02/23(Mon) 03:59, Renato Aguiar wrote: > [...] > I can't reproduce it anymore with this patch on 7.2-stable :) Thanks a lot for testing! Here's a better fix from Chuck Silvers. That's what I believe we should commit. The idea is to prevent sibling from modifying the vm_map by marking it a

Re: bbolt can freeze 7.2 from userspace

2023-02-20 Thread David Hill
On 2/20/23 03:43, Martin Pieuchot wrote: On 20/02/23(Mon) 03:59, Renato Aguiar wrote: [...] I can't reproduce it anymore with this patch on 7.2-stable :) Thanks a lot for testing! Here's a better fix from Chuck Silvers. That's what I believe we should commit. The idea is to prevent siblin

Re: bbolt can freeze 7.2 from userspace

2023-02-20 Thread Jacqueline Jolicoeur
On Feb 20 09:43, Martin Pieuchot wrote: > On 20/02/23(Mon) 03:59, Renato Aguiar wrote: > > [...] > > I can't reproduce it anymore with this patch on 7.2-stable :) > > Thanks a lot for testing! Here's a better fix from Chuck Silvers. > That's what I believe we should commit. > > The idea is to p

Re: bbolt can freeze 7.2 from userspace

2023-02-20 Thread Mark Kettenis
> Date: Mon, 20 Feb 2023 09:43:10 +0100 > From: Martin Pieuchot > > On 20/02/23(Mon) 03:59, Renato Aguiar wrote: > > [...] > > I can't reproduce it anymore with this patch on 7.2-stable :) > > Thanks a lot for testing! Here's a better fix from Chuck Silvers. > That's what I believe we should c

Re: bbolt can freeze 7.2 from userspace

2023-02-20 Thread Alexander Bluhm
On Mon, Feb 20, 2023 at 09:43:10AM +0100, Martin Pieuchot wrote: > On 20/02/23(Mon) 03:59, Renato Aguiar wrote: > > [...] > > I can't reproduce it anymore with this patch on 7.2-stable :) > > Thanks a lot for testing! Here's a better fix from Chuck Silvers. > That's what I believe we should comm

Re: bbolt can freeze 7.2 from userspace

2023-02-20 Thread Renato Aguiar
"Martin Pieuchot" writes: > On 20/02/23(Mon) 03:59, Renato Aguiar wrote: >> [...] >> I can't reproduce it anymore with this patch on 7.2-stable :) > > Thanks a lot for testing! Here's a better fix from Chuck Silvers. > That's what I believe we should commit. > > The idea is to prevent sibling