bpf_validate() uses BPF_RVAL() when it should use BPF_SRC()

2010-04-20 Thread Guy Harris
In bpf_validate, when it checks whether the divisor in a BPF_DIV instruction is a constant 0, it does case BPF_DIV: /* * Check for constant division by 0. */

Re: bpf_validate() uses BPF_RVAL() when it should use BPF_SRC()

2010-04-21 Thread Otto Moerbeek
On Tue, Apr 20, 2010 at 05:14:05PM -0700, Guy Harris wrote: > In bpf_validate, when it checks whether the divisor in a BPF_DIV instruction > is a constant 0, it does > > case BPF_DIV: > /* >* Check for constant di

Re: bpf_validate() uses BPF_RVAL() when it should use BPF_SRC()

2010-04-21 Thread Guy Harris
On Apr 21, 2010, at 5:25 AM, Otto Moerbeek wrote: > Indeed, thanks. You're welcome, but I can't take credit for it, just for forwarding the fix - I'd filed a bug against another BPF implementation, adding the OpenBSD checks, and the person who applied that fix changed BPF_RVAL() to BPF_SRC(), and