I'll append a version that i deem to be better, since it ensures
the message is written as a unity even in multithreaded+ programs.
It's not in OpenBSD style, though.
Yep, it seems there is a possibility to improve the codebase even
more, not only under the visual surface.
Ciao from horsy horse,
,
Date: Thu, 16 Jan 2014 16:56:11 +0100
From: Steffen (Daode) Nurpmeso sdao...@gmail.com
To: bugs@openbsd.org
Cc: Theo de Raadt dera...@cvs.openbsd.org, Philip Guenther
pguent...@proofpoint.com, Ted Unangst t...@tedunangst.com
Subject: Re: err.h / err(3): add missing errc(3)/verrc(3)/warnc(3
Description:
The *c() family, which exists in FreeBSD and derivatives, is
helpful whenever something has to be done in the error case
(like necessary cleanup), while still being able to inform the
user about the original error that caused the problem.
Fix:
I'll attach a diff against
argh. good i looked. same again, inline.
diff -Napru open.orig/include/err.h open/include/err.h
--- open.orig/include/err.h 2014-01-14 12:12:44.0 +0100
+++ open/include/err.h 2014-01-14 13:20:36.0 +0100
@@ -51,6 +51,10 @@ __dead void err(int, const char *, ...)
On Tue, Jan 14, 2014 at 15:08, Steffen Nurpmeso wrote:
Description:
The *c() family, which exists in FreeBSD and derivatives, is
helpful whenever something has to be done in the error case
(like necessary cleanup), while still being able to inform the
user about the original error that
Ted Unangst t...@tedunangst.com wrote:
|On Tue, Jan 14, 2014 at 15:08, Steffen Nurpmeso wrote:
| Description:
| The *c() family, which exists in FreeBSD and derivatives, is
| helpful whenever something has to be done in the error case
| (like necessary cleanup), while still being able to
On Tue, 14 Jan 2014, Theo de Raadt wrote:
I think it is worth adding this interface, given how frequently
this family is used:
$ git grep -E '(err|warn)\(' origin/master|wc -l
19583
all in all, including perl(1) stuff. A family that is used so
often can well tolerate a few
