pf panic with clean snapshot (GENERIC.MP) #570

2022-06-06 Thread Hrvoje Popovski
Hi, this is follow up mail from https://marc.info/?l=openbsd-tech&m=165450511622133&w=2 panic log: bcbnfw1# uvm_fault(0x822e5e48, 0x0, 0, 1) -> e kernel: page fault trap, code=0 Stopped at pf_state_export+0x38: movq0(%rax),%rcx TIDPIDUID PRFLAGS PFLAGS CPU

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-06 Thread Alexandr Nedvedicky
Hello, > > panic log: > > bcbnfw1# uvm_fault(0x822e5e48, 0x0, 0, 1) -> e > kernel: page fault trap, code=0 > Stopped at pf_state_export+0x38: movq0(%rax),%rcx > TIDPIDUID PRFLAGS PFLAGS CPU COMMAND > *186873 72386 0 0x14000 0x2001 sof

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-06 Thread Hrvoje Popovski
On 6.6.2022. 12:45, Alexandr Nedvedicky wrote: > this is most likely identical to crash you've reported ?two weeks ago? > I can not find an email with it. oh yes, yes it's on tech@ with subject pf_state_export panic with NET_TASKQ=6 and stuff i've totally forgot about that report :)

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-07 Thread Alexandr Nedvedicky
Hello Hrvoje, > > Hi, > > while booting with this diff I've got this log: > > starting early daemons: syslogd pflogd ntpdwitness: lock_object > uninitialized: 0xfd8785c81a > 90 > Starting stack trace... > witness_checkorder(fd8785c81a90,9,0) at witness_checkorder+0xad > mtx_enter(f

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-07 Thread Hrvoje Popovski
On 8.6.2022. 0:42, Alexandr Nedvedicky wrote: > Hello Hrvoje, > > >> Hi, >> >> while booting with this diff I've got this log: >> >> starting early daemons: syslogd pflogd ntpdwitness: lock_object >> uninitialized: 0xfd8785c81a >> 90 >> Starting stack trace... >> witness_checkorder(fd8785

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-09 Thread David Gwynne
i upgraded one of the work firewalls to -current and added the diff below in, and got what looks like a different panic: ddb{6}> tr db_enter() at db_enter+0x5 panic(81e2cc31) at panic+0xbf __assert(81eae23b,81ee4549,797,81e7fd91) at __assert+0x25 pfsync_insert_st

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-09 Thread Alexandr Nedvedicky
Hello, On Fri, Jun 10, 2022 at 09:54:47AM +1000, David Gwynne wrote: > > i upgraded one of the work firewalls to -current and added the diff > below in, and got what looks like a different panic: > > ddb{6}> tr > db_enter() at db_enter+0x5 > panic(81e2cc31) at panic+0xbf > __assert(f

Re: pf panic with clean snapshot (GENERIC.MP) #570

2022-06-12 Thread Hrvoje Popovski
On 8.6.2022. 7:33, Hrvoje Popovski wrote: > On 8.6.2022. 0:42, Alexandr Nedvedicky wrote: >> Hello Hrvoje, >> >> >>> Hi, >>> >>> while booting with this diff I've got this log: >>> >>> starting early daemons: syslogd pflogd ntpdwitness: lock_object >>> uninitialized: 0xfd8785c81a >>> 90 >>> St

Re: [External] : pf panic with clean snapshot (GENERIC.MP) #570

2022-06-06 Thread Alexandr Nedvedicky
Hello, below is a diff which hopes to fix the issue. Although diff is fairly large the change itself is kind of straightforward. Let me briefly explain what's going on here. Diff introduces a mutex to pf_state, which protects array of keys (pf_state::key) bound to state. The panic which diff belo

Re: [External] : pf panic with clean snapshot (GENERIC.MP) #570

2022-06-06 Thread Hrvoje Popovski
On 7.6.2022. 2:16, Alexandr Nedvedicky wrote: > Hello, > > below is a diff which hopes to fix the issue. Although diff is fairly > large the change itself is kind of straightforward. Let me briefly > explain what's going on here. Diff introduces a mutex to pf_state, > which protects array of keys