Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Philip Guenther
On Sat, 30 Mar 2013, Andres Perera wrote: freebsd has _null.h ...but their sys/queue.h doesn't include it. There are two questions here: 1) should sys/queue.h be standalone or does it require NULL to be defined separately? 2) if the latter, what should the manpage say? Currently, FreeBSD

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Otto Moerbeek
On Sun, Mar 31, 2013 at 12:16:16AM -0700, Philip Guenther wrote: On Sat, 30 Mar 2013, Andres Perera wrote: freebsd has _null.h ...but their sys/queue.h doesn't include it. There are two questions here: 1) should sys/queue.h be standalone or does it require NULL to be defined

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Theo de Raadt
a) document in queue(3) that some macros may require NULL to be defined b) make sys/queue.h define NULL c) stop using NULL in sys/queue.h (a) is the least invasive to queue.h; (c) is the least invasive to applications. I prefer (c). That requires a bit of contortuim, but this was not

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Mark Kettenis
Date: Sun, 31 Mar 2013 00:16:16 -0700 From: Philip Guenther guent...@sendmail.com On Sat, 30 Mar 2013, Andres Perera wrote: freebsd has _null.h ...but their sys/queue.h doesn't include it. There are two questions here: 1) should sys/queue.h be standalone or does it require NULL to be

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Andres Perera
On Sun, Mar 31, 2013 at 2:46 AM, Philip Guenther guent...@sendmail.com wrote: On Sat, 30 Mar 2013, Andres Perera wrote: freebsd has _null.h ...but their sys/queue.h doesn't include it. There are two questions here: 1) should sys/queue.h be standalone or does it require NULL to be

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Andres Perera
On Sun, Mar 31, 2013 at 5:09 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Sun, 31 Mar 2013 00:16:16 -0700 From: Philip Guenther guent...@sendmail.com On Sat, 30 Mar 2013, Andres Perera wrote: freebsd has _null.h ...but their sys/queue.h doesn't include it. There are two

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Ted Unangst
On Sun, Mar 31, 2013 at 12:12, Andres Perera wrote: On Sun, Mar 31, 2013 at 5:09 AM, Mark Kettenis mark.kette...@xs4all.nl c) wouldn't be terribly helpful either. The examples in queue(3) use NULL. It explicitly documents SLIST_END(), LIST_END(), SIMPLEQ_END() and TAILQ_END() macros as

Re: queue(3): Unacounted dependency on NULL

2013-03-31 Thread Andres Perera
the confusing part would be if they suddenly were made anything other than NULL at the header and/or documentation level they've been defined as NULL for a long time so it's to be expected that there's code and people out there that make such assumptions i don't think it matter whether the

Re: queue(3): Unacounted dependency on NULL

2013-03-30 Thread Otto Moerbeek
On Mon, Mar 18, 2013 at 03:31:29PM -0430, Andres Perera wrote: Various macros in sys/queue.h depend on NULL; however, the header does not define NULL, nor does it include another header that fulfills the dependency. diff --git a/share/man/man3/queue.3 b/share/man/man3/queue.3 index

Re: queue(3): Unacounted dependency on NULL

2013-03-30 Thread Andres Perera
freebsd has _null.h (and so does bitrig) that file's only purpose is to define NULL which i presume is the same as netbsd's null.h i think it's better than having tons of duplicate NULL definitions in the headers... (jmc@ pointed out to me in private more or less the same issue with my

queue(3): Unacounted dependency on NULL

2013-03-18 Thread Andres Perera
Various macros in sys/queue.h depend on NULL; however, the header does not define NULL, nor does it include another header that fulfills the dependency. diff --git a/share/man/man3/queue.3 b/share/man/man3/queue.3 index c54e932..5a2e30c 100644 --- a/share/man/man3/queue.3 +++