umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Jeremie Courreges-Anglas
Looks umb(4) triggers the NET_ASSERT_LOCKED() check in rtable_getsource() when the umb(4) interface comes up (here with kern.splassert=2 to get context). Reproduced with GENERIC.MP from Aug 28 as well with cvs HEAD/if_umb.c rev 1.54. Something to worry about? OpenBSD 7.3-current (GENERIC.MP)

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Vitaliy Makkoveev
On Thu, Aug 31, 2023 at 11:26:42AM +0200, Jeremie Courreges-Anglas wrote: > > Looks umb(4) triggers the NET_ASSERT_LOCKED() check in > rtable_getsource() when the umb(4) interface comes up (here with > kern.splassert=2 to get context). Reproduced with GENERIC.MP from Aug > 28 as well with cvs HEA

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Alexander Bluhm
On Thu, Aug 31, 2023 at 01:05:11PM +0300, Vitaliy Makkoveev wrote: > On Thu, Aug 31, 2023 at 11:26:42AM +0200, Jeremie Courreges-Anglas wrote: > > > > Looks umb(4) triggers the NET_ASSERT_LOCKED() check in > > rtable_getsource() when the umb(4) interface comes up (here with > > kern.splassert=2 to

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Jeremie Courreges-Anglas
On Thu, Aug 31 2023, Alexander Bluhm wrote: > On Thu, Aug 31, 2023 at 01:05:11PM +0300, Vitaliy Makkoveev wrote: >> On Thu, Aug 31, 2023 at 11:26:42AM +0200, Jeremie Courreges-Anglas wrote: >> > >> > Looks umb(4) triggers the NET_ASSERT_LOCKED() check in >> > rtable_getsource() when the umb(4) in

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Vitaliy Makkoveev
On Thu, Aug 31, 2023 at 01:42:45PM +0200, Alexander Bluhm wrote: > On Thu, Aug 31, 2023 at 01:05:11PM +0300, Vitaliy Makkoveev wrote: > > On Thu, Aug 31, 2023 at 11:26:42AM +0200, Jeremie Courreges-Anglas wrote: > > > > > > Looks umb(4) triggers the NET_ASSERT_LOCKED() check in > > > rtable_getsou

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Alexander Bluhm
On Thu, Aug 31, 2023 at 04:25:37PM +0300, Vitaliy Makkoveev wrote: > > NET_UNLOCK() and NET_LOCK_SHARED() just after each other does not > > make much sense. Just keep exclusive netlock for the few lines. > > Agreed. Both the cases perform route sockets walkthrough and message > transmission. No

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-08-31 Thread Vitaliy Makkoveev
On Thu, Aug 31, 2023 at 02:44:41PM +0200, Jeremie Courreges-Anglas wrote: > On Thu, Aug 31 2023, Alexander Bluhm wrote: > > On Thu, Aug 31, 2023 at 01:05:11PM +0300, Vitaliy Makkoveev wrote: > >> On Thu, Aug 31, 2023 at 11:26:42AM +0200, Jeremie Courreges-Anglas wrote: > >> > > >> > Looks umb(4)

Re: umb(4): splassert: rtable_getsource: want 2 have 0

2023-09-01 Thread Jeremie Courreges-Anglas
On Thu, Aug 31 2023, Vitaliy Makkoveev wrote: > On Thu, Aug 31, 2023 at 01:42:45PM +0200, Alexander Bluhm wrote: >> On Thu, Aug 31, 2023 at 01:05:11PM +0300, Vitaliy Makkoveev wrote: >> > On Thu, Aug 31, 2023 at 11:26:42AM +0200, Jeremie Courreges-Anglas wrote: >> > > >> > > Looks umb(4) triggers