vmd/vionet/vioblk: network + disk regression

2024-02-09 Thread Klemens Nanni
kern.version=OpenBSD 7.4-current (GENERIC.MP) #1667: Wed Feb 7 20:09:35 MST 2024 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP This boots fine: # cat /tmp/vm.conf vm foo { disable disk /tmp/linux.qcow2 }

Re: vmd/vionet/vioblk: network + disk regression

2024-02-09 Thread Klemens Nanni
On Fri, Feb 09, 2024 at 10:20:12AM +, Klemens Nanni wrote: > This terminates the VM immediately after startup: > > # cat /tmp/vm.conf > vm foo { > disable > disk /tmp/linux.qcow2 > interface > } Backing this out makes the VM start, b

Re: vmd/vionet/vioblk: network + disk regression

2024-02-09 Thread Dave Voutila
Klemens Nanni writes: > kern.version=OpenBSD 7.4-current (GENERIC.MP) #1667: Wed Feb 7 20:09:35 MST > 2024 > dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP > > This boots fine: > > # cat /tmp/vm.conf > vm foo { > disable > disk

Re: vmd/vionet/vioblk: network + disk regression

2024-02-09 Thread Klemens Nanni
On Fri, Feb 09, 2024 at 10:02:29AM -0500, Dave Voutila wrote: > Try this diff. There was an issue in the order of closing disk fds. I > also noticed we're not closing the sockets when closing the data fds, so > that's added into virtio_dev_closefds(). > > With this i can boot a guest that uses a n