Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Martin Buchholz
On Fri, Aug 29, 2008 at 3:37 AM, Anthony Petrov <[EMAIL PROTECTED]> wrote: > On 08/28/2008 08:33 PM Martin Buchholz wrote: >> >> I'm thinking: >> - the MMX support is in pnggccrd.c, >> - but that file is never compiled in OpenJDK > > Why? There's the following line in the make/sun/splashscreen/Make

Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Martin Buchholz
Hi Anthony, On Fri, Aug 29, 2008 at 3:30 AM, Anthony Petrov <[EMAIL PROTECTED]> wrote: > Hi Martin, > > The AWT folks think we need to guard this CPPFLAGS setting with the > following condition: > > ifneq ($(PLATFORM), windows) > ... > endif I am certain this would "work" for everyone, but ... I

Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Anthony Petrov
Hi Mark, On 08/28/2008 09:35 PM Mark Wielaard wrote: On Thu, 2008-08-28 at 14:23 +0400, Anthony Petrov wrote: 1. The patch cuts off the embedded versions of these libraries from OpenJDK source code. In fact, there may exist systems where these libraries are not installed. And currently OpenJDK

Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Anthony Petrov
On 08/28/2008 08:33 PM Martin Buchholz wrote: I'm thinking: - the MMX support is in pnggccrd.c, - but that file is never compiled in OpenJDK Why? There's the following line in the make/sun/splashscreen/Makefile: vpath %.c $(SHARE_SRC)/native/$(PKGDIR)/libpng that effectively includes all *.c

Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Anthony Petrov
Hi Martin, The AWT folks think we need to guard this CPPFLAGS setting with the following condition: ifneq ($(PLATFORM), windows) ... endif We don't use gcc on Windows, and everything works just fine with MS VS. Please feel free to submit the patch with this change, and please add OpenJDK us