Re: AWT Dev 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Andrew John Hughes
2009/6/17 Kelly O'Hair kelly.oh...@sun.com: Anthony Petrov wrote: So, build-dev, Any opinions? Can we make sure the header is always present on Sol10u2? I'm very much ok with this change. I hate copying system include stuff. We could add a specific sanity check, but my preference would

Re: AWT Dev 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
On 6/17/2009 8:44 PM Andrew John Hughes wrote: So should I push the original webrev http://fuseyism.com/xrender/webrev.01/ (which uses the standard header instead) to the awt gate? Given Kelly's point, I'm approving the fix. Please use the CR number 6851515 for your commit message. Thanks for

Re: AWT Dev 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
Andrew, Please update the README-builds.html file also as Kelly suggests. Thanks! -- best regards, Anthony On 6/17/2009 9:00 PM Anthony Petrov wrote: On 6/17/2009 8:44 PM Andrew John Hughes wrote: So should I push the original webrev http://fuseyism.com/xrender/webrev.01/ (which uses the

Re: AWT Dev 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Andrew John Hughes
2009/6/17 Anthony Petrov anthony.pet...@sun.com: Andrew, Please update the README-builds.html file also as Kelly suggests. Thanks! Ok here's an updated version with Xrender mentioned in README-builds: http://fuseyism.com/6851515/webrev.03/ Ok? -- best regards, Anthony On 6/17/2009

Re: AWT Dev 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
On 6/17/2009 10:13 PM Andrew John Hughes wrote: Please update the README-builds.html file also as Kelly suggests. Thanks! Ok here's an updated version with Xrender mentioned in README-builds: http://fuseyism.com/6851515/webrev.03/ Ok? Perfect! Approved. Feel free to push to the AWT gate.

Re: AWT Dev 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Andrew John Hughes
2009/6/17 Anthony Petrov anthony.pet...@sun.com: On 6/17/2009 10:13 PM Andrew John Hughes wrote: Please update the README-builds.html file also as Kelly suggests. Thanks! Ok here's an updated version with Xrender mentioned in README-builds: http://fuseyism.com/6851515/webrev.03/ Ok?