Kelly O'Hair wrote:
I need some formal reviewers on these jdk/test/Makefile changes.
More polish and changes may need to be done later, but there
is value in what I have now, and I need lots of help to improve
things (and fix some of our testcases).
Here is the bugid and webrev:
6888927: Fix
Martin,
It would be wrong to *just* mark the broken tests as @run othervm,
because then we would have no obvious way to distinguish between those
tests which are intentionally othervm, and those tests which should be
samevm but which are broken and have to be othervm for now.
It would be
Jonathan Gibbons wrote:
Kelly,
Wow, you've been busy.
The thing that stood out to me was the use of SLASH_JAVA which is
something of a Sun legacy which doesn't apply to folk outside Sun. And,
looking at the file as a whole, it's clear there are many different
sections, not all of which
Martin Buchholz wrote:
One of the things you've done is to create test sets.
I did something like that in my jtr script (ask Tim if you can't find it).
For each logical component, it's non-trivial to find all the tests
for that (e.g. how to test string handling).
This is especially true for
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I need some formal reviewers on these jdk/test/Makefile changes.
More polish and changes may need to be done later, but there
is value in what I have now, and I need lots of help to improve
things (and fix some of our testcases).
Here is the
Alan Bateman wrote:
Kelly O'Hair wrote:
:
It was more of a balancing act on the test groupings with regards to
timings
etc., and imageio did have io in it's name :^), and most of them ran
safely
in samevm mode. So we can move them to any other group that is run in
samevm
mode. Do you
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I'm basically ok with this, but have one concern.
There is no longer a default ant value for drops.dir, it is only
set via the Makefile. Maybe that's ok, just not sure.
I think it means that a plain 'ant' command will always download
from the url.
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I'm basically ok with this, but have one concern.
There is no longer a default ant value for drops.dir, it is only
set via the Makefile. Maybe that's ok, just not sure.
I think it means that a plain 'ant' command will
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I'm basically ok with this, but have one concern.
There is no longer a default ant value for drops.dir, it is only
set via the Makefile. Maybe that's ok, just not sure.
I
Changeset: 2bad7eac71b3
Author:mikejwre
Date: 2009-10-30 10:54 -0700
URL: http://hg.openjdk.java.net/jdk7/build/rev/2bad7eac71b3
Added tag jdk7-b75 for changeset d1516b9f2395
! .hgtags
Changeset: 0619361ff7c5
Author:ohair
Date: 2009-11-04 11:19 -0800
URL:
Changeset: c8a56aff861b
Author:mikejwre
Date: 2009-10-30 10:54 -0700
URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/c8a56aff861b
Added tag jdk7-b75 for changeset 0fb137085952
! .hgtags
Changeset: 6995f81e3b53
Author:ohair
Date: 2009-11-04 11:19 -0800
URL:
I've diff'd a few of the files from that patch, and it looks like the
code I have included the patch from jdk7-b47. I exported my local copy
on September 23, 2009 from http://hg.openjdk.java.net/bsd-port/bsd-
port, so my guess would be that it was around jdk7-b73 based on the
tag dates.
Hey -
A bit new to this project. Not sure what the procedure is here. I
found this doc to work from and it got me pretty far:
http://confluence.concord.org/display/CCTR/Build+OpenJDK+Java+1.7.0+on+Mac+OS+X+10.5
But then after quite a while building, I get the following. Yet, as
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I'm basically ok with this, but have one concern.
There is no longer a default ant value for drops.dir, it is only
set via the Makefile. Maybe that's
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I'm basically ok with this, but have one concern.
There is no longer a default ant value for
Martin Buchholz wrote:
On Wed, Nov 4, 2009 at 09:19, Kelly O'Hair kelly.oh...@sun.com wrote:
Managing the ProblemList (as Jon noted) will be a pain at times.
It's even more of a problem as development becomes more distributed,
as failures become platform-dependent, etc...
I would prefer to
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
Andrew John Hughes wrote:
2009/11/4 Kelly O'Hair kelly.oh...@sun.com:
I'm basically ok with this, but have one concern.
There is no longer a
Kelly O'Hair wrote:
I also like the approach I advocated some years ago:
- run tests under JDK 1
- run tests under JDK 2
- diff the results (JTreport directories)
See my diff-javatest script.
jtreg now has support for this (I haven't tried it lately).
In an ideal world, one set of results
18 matches
Mail list logo
