Review Request: 6911737: Module build: generate modules with native libraries and any other files

2009-12-17 Thread Mandy Chung
This is the next step toward modularizing the jdk: 6911737: Module build: generate modules with native libraries and any other files Webrev at: http://cr.openjdk.java.net/~mchung/6911737/webrev.00/ For classes and other resource files in jar files, we use simple patterns to match what c

Re: Please review: Bug ID: 6899737 JDK build fails in make/java/jli because of _vsnprintf macro redefinition

2009-12-17 Thread Kelly O'Hair
Looks ok to me. -kto Tim Bell wrote: Hi Folks Here is the bug report: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6899737 Here is the proposed fix (works when using both Visual Studio 2003 and VS 2008 on Windows XP SP2): http://cr.openjdk.java.net/~tbell/6899737.00/ This is a block

Re: Please review: Bug ID: 6899737 JDK build fails in make/java/jli because of _vsnprintf macro redefinition

2009-12-17 Thread Tim Bell
Artem Ananiev wrote: > Hi, Tim, > > is this problem specific to the newest MS compiler only (and do we care > of any other compiler when building JDK7 on windows)? If yes, we could I don't know of any other compiler building JDK7 on Windows, but in the past people have suggested both Intel's co

hg: jdk7/build/langtools: 11 new changesets

2009-12-17 Thread michael . wilkerson
Changeset: cff85998bf4d Author:jjg Date: 2009-11-17 16:45 -0800 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/cff85998bf4d 6898585: restructure langtools build.xml to facilitate more options for macro Reviewed-by: ohair ! make/build.xml Changeset: a509a22f9845 Author:

Re: Please review: Bug ID: 6899737 JDK build fails in make/java/jli because of _vsnprintf macro redefinition

2009-12-17 Thread Artem Ananiev
Hi, Tim, is this problem specific to the newest MS compiler only (and do we care of any other compiler when building JDK7 on windows)? If yes, we could change the condition to #if !defined(vsnprintf) && !defined(NO_vsnprintf) && (!defined(_MSC_VER) || (_MSC_VER >= 1500)) Thanks, Artem Ti

hg: jdk7/build: 4 new changesets

2009-12-17 Thread michael . wilkerson
Changeset: 382219a27386 Author:ohair Date: 2009-11-18 16:41 -0800 URL: http://hg.openjdk.java.net/jdk7/build/rev/382219a27386 6727046: Add message when docs are skipped in control build 6864011: typo? in top level Makefile: DAYE_STAMP Reviewed-by: jjg ! Makefile ! make/Defs-interna

Please review: Bug ID: 6899737 JDK build fails in make/java/jli because of _vsnprintf macro redefinition

2009-12-17 Thread Tim Bell
Hi Folks Here is the bug report: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6899737 Here is the proposed fix (works when using both Visual Studio 2003 and VS 2008 on Windows XP SP2): http://cr.openjdk.java.net/~tbell/6899737.00/ This is a blocker for my work on the full Visual Studio

Re: Review request for 6909572: Add a new target for building modules

2009-12-17 Thread Mandy Chung
I updated the class analyzer to generate a new .resources file. The jdk module build will include the non-java resource files in each module. The new webrev is at: http://cr.openjdk.java.net/~mchung/6909572/webrev.01 I also generate a webrev showing the class analyzer change w.r.t. the jig