Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Raffaello Giulietti
On 2010-06-07 01:20, cowwoc wrote: Hi, I'm trying to build OpenJDK under Windows7 64-bit with Visual Studio 2010. When I run jdk_generic_profile.sh I get: /cygdrive/c/Users/Gili/Documents/jdk7/jdk7/jdk/make/jdk_generic_profile.sh: line 177: PROCESSOR_IDENTIFIER: command not found I

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread cowwoc
Raffaello Giulietti wrote: Gili, you can find some instructions about how to download a working make here, in the section Make http://mail.openjdk.java.net/pipermail/build-dev/2010-May/002955.html Hope this helps Raffaello I ended up using

[PATCH FOR REVIEW]: Unnecessary calls to sync()

2010-06-07 Thread Andrew John Hughes
Is it really necessary for the sanity script to be flushing all buffers to disc on GNU/Linux boxes? ifeq ($(PLATFORM), linux) FREE_SPACE := $(shell $(DF) --sync -kP $(OUTPUTDIR) | $(TAIL) -1 | $(NAWK) '{print $$4;}') TEMP_FREE_SPACE := $(shell $(DF) --sync -kP $(TEMP_DISK) | $(TAIL) -1 |

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Kelly O'Hair
On Jun 7, 2010, at 11:42 AM, cowwoc wrote: David Holmes-9 wrote: Shouldn't jdk_generic_profile.sh use braces instead of round brackets? That is, ${PROCESSOR_IDENTIFIER} instead of $(PROCESSOR_IDENTIFIER)? Is this a bug in the makefile? It's a bug in the script - a typo introduced

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Alan Bateman
Kelly O'Hair wrote: : Anyone care to be the reviewer? 6959116: Fix regression in make/jdk_generic_profile.sh (PROCESSOR_IDENTIFIER) diff --git a/make/jdk_generic_profile.sh b/make/jdk_generic_profile.sh --- a/make/jdk_generic_profile.sh +++ b/make/jdk_generic_profile.sh @@ -174,7 +174,7 @@

Re: Help building under Windows7 64-bit

2010-06-07 Thread cowwoc
Andrew John Hughes wrote: I've never built on Windows, nor would I ever want to. But at a guess, your problem here is that you have spaces in your path to ant. Move it to something like C:\ant and you'll probably get further. You are right, but I can't figure out why. Here is the script

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Kelly O'Hair
On Jun 7, 2010, at 11:57 AM, Alan Bateman wrote: Kelly O'Hair wrote: : Anyone care to be the reviewer? 6959116: Fix regression in make/jdk_generic_profile.sh (PROCESSOR_IDENTIFIER) diff --git a/make/jdk_generic_profile.sh b/make/ jdk_generic_profile.sh ---

Differences in Visual Studio vs OpenJDK compiles - jchar vs OLECHAR

2010-06-07 Thread Pete Brunet
I'm working on a new file for OpenJDK. I get no compile errors in my Visual Studio IDE environment but interestingly enough get a set of problems all like this one in the OpenJDK environment: Source: const jchar* jcstr = env-GetStringCritical(name, NULL); *pszName = ::SysAllocStringLen(jcstr,

Re: Help building under Windows7 64-bit

2010-06-07 Thread Lussier, Denis
The latest Freetype sources build quite easily on Windoze (at least on Win32 using VS2003). On 6/7/10, Kelly O'Hair kelly.oh...@oracle.com wrote: Note that Windows7 is a bit of an unknown to use as far as being a build machine, it should work, but in general, the formal 32bit builds of jdk7