Re: Differences in Visual Studio vs OpenJDK compiles - jchar vs OLECHAR

2010-06-07 Thread Pete Brunet
I resolved this by disabling the Zc:wchar_t- option in Visual Studio. >From the GUI I had set this via the file's property page: C++, Language settings, Treat wchar_t as Built-in Type, Yes which is the default and which also matches the state of that option for the OpenJDK build. I had set tha

Re: Help building under Windows7 64-bit

2010-06-07 Thread cowwoc
Hi Kelly, kelly.ohair-2 wrote: > > Note that Windows7 is a bit of an unknown to use as far as being a > build machine, it should work, but in > general, the formal 32bit builds of jdk7 use older Windows releases, > e.g. 2000 and soon that newer one "XP" ;^) > You are trying a 64bit build wi

Re: Help building under Windows7 64-bit

2010-06-07 Thread Kelly O'Hair
Can you provide some detailed instructions so I could add it to the README-builds.html file? -kto On Jun 7, 2010, at 4:11 PM, Lussier, Denis wrote: The latest Freetype sources build quite easily on Windoze (at least on Win32 using VS2003). On 6/7/10, Kelly O'Hair wrote: Note that Window

Re: Help building under Windows7 64-bit

2010-06-07 Thread Lussier, Denis
The latest Freetype sources build quite easily on Windoze (at least on Win32 using VS2003). On 6/7/10, Kelly O'Hair wrote: > > Note that Windows7 is a bit of an unknown to use as far as being a > build machine, it should work, but in > general, the formal 32bit builds of jdk7 use older Windows r

Differences in Visual Studio vs OpenJDK compiles - jchar vs OLECHAR

2010-06-07 Thread Pete Brunet
I'm working on a new file for OpenJDK. I get no compile errors in my Visual Studio IDE environment but interestingly enough get a set of problems all like this one in the OpenJDK environment: Source: const jchar* jcstr = env->GetStringCritical(name, NULL); *pszName = ::SysAllocStringLen(jcstr, en

hg: jdk7/build/jdk: 6959116: Fix regression in make/jdk_generic_profile.sh (PROCESSOR_IDENTIFIER)

2010-06-07 Thread kelly . ohair
Changeset: be0d055db574 Author:ohair Date: 2010-06-07 12:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/be0d055db574 6959116: Fix regression in make/jdk_generic_profile.sh (PROCESSOR_IDENTIFIER) Reviewed-by: alanb ! make/jdk_generic_profile.sh

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Kelly O'Hair
On Jun 7, 2010, at 11:57 AM, Alan Bateman wrote: Kelly O'Hair wrote: : Anyone care to be the reviewer? 6959116: Fix regression in make/jdk_generic_profile.sh (PROCESSOR_IDENTIFIER) diff --git a/make/jdk_generic_profile.sh b/make/ jdk_generic_profile.sh --- a/make/jdk_generic_profile.sh

Re: Help building under Windows7 64-bit

2010-06-07 Thread Kelly O'Hair
Note that Windows7 is a bit of an unknown to use as far as being a build machine, it should work, but in general, the formal 32bit builds of jdk7 use older Windows releases, e.g. 2000 and soon that newer one "XP" ;^) You are trying a 64bit build with Visual Studio 10, on Windows 7, an even

Re: Help building under Windows7 64-bit

2010-06-07 Thread cowwoc
Andrew John Hughes wrote: > > I've never built on Windows, nor would I ever want to. But at a > guess, your problem here is that you have spaces in your path to ant. > Move it to something like C:\ant and you'll probably get further. > You are right, but I can't figure out why. Here is the sc

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Alan Bateman
Kelly O'Hair wrote: : Anyone care to be the reviewer? 6959116: Fix regression in make/jdk_generic_profile.sh (PROCESSOR_IDENTIFIER) diff --git a/make/jdk_generic_profile.sh b/make/jdk_generic_profile.sh --- a/make/jdk_generic_profile.sh +++ b/make/jdk_generic_profile.sh @@ -174,7 +174,7 @@

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Kelly O'Hair
On Jun 7, 2010, at 11:42 AM, cowwoc wrote: David Holmes-9 wrote: Shouldn't jdk_generic_profile.sh use braces instead of round brackets? That is, ${PROCESSOR_IDENTIFIER} instead of $(PROCESSOR_IDENTIFIER)? Is this a bug in the makefile? It's a bug in the script - a typo introduced by

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Kelly O'Hair
On Jun 6, 2010, at 4:20 PM, cowwoc wrote: Hi, I'm trying to build OpenJDK under Windows7 64-bit with Visual Studio 2010. When I run jdk_generic_profile.sh I get: /cygdrive/c/Users/Gili/Documents/jdk7/jdk7/jdk/make/ jdk_generic_profile.sh: line 177: PROCESSOR_IDENTIFIER: command not foun

Re: Using Java7 as Boot JDK?

2010-06-07 Thread cowwoc
Andrew John Hughes wrote: > >> Assuming you're talking about building JDK7, this should work.   In fact, >> one of the standard tests for a JDK build is to see if it can build >> itself. >> This is done by setting SKIP_BOOT_CYCLE=false on the make command line. >> If >> you set this parameter, t

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread cowwoc
David Holmes-9 wrote: > >> Shouldn't jdk_generic_profile.sh use braces instead of round brackets? >> That >> is, ${PROCESSOR_IDENTIFIER} instead of $(PROCESSOR_IDENTIFIER)? Is this a >> bug in the makefile? > > It's a bug in the script - a typo introduced by this recent changeset: > > changese

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Kelly O'Hair
On Jun 6, 2010, at 11:00 PM, David Holmes wrote: cowwoc said the following on 06/07/10 15:25: That being said, I don't think the PROCESSOR_IDENTIFIER error is specific to Make. I noticed the makefile contains echo $ (PROCESSOR_IDENTIFIER). Running this under cygwin's bash gives: echo $(PR

Re: Help building under Windows7 64-bit

2010-06-07 Thread Andrew John Hughes
On 7 June 2010 19:27, cowwoc wrote: > > Hi, > > I am attempting to build OpenJDK under Windows7 64-bit, Visual Studio 2010. > Here is the output of "make sanity": > > -- > ( cd  ./jdk/make && \ >          make sanity HOTSPOT_IMPORT_CHECK=false > JDK_TOPDIR=C:/users/gili/DOCUME~1/jdk7/j

Re: Using Java7 as Boot JDK?

2010-06-07 Thread Andrew John Hughes
On 7 June 2010 19:30, Jonathan Gibbons wrote: > On 06/07/2010 11:16 AM, cowwoc wrote: >> >> Hi, >> >> Has anyone tried building OpenJDK using a JDK7 as the boot JDK? Is there >> any >> reason to expect this will fail? Ideally I don't want two different JDK >> versions installed on my machine ;) >>

Re: Using Java7 as Boot JDK?

2010-06-07 Thread Jonathan Gibbons
On 06/07/2010 11:16 AM, cowwoc wrote: Hi, Has anyone tried building OpenJDK using a JDK7 as the boot JDK? Is there any reason to expect this will fail? Ideally I don't want two different JDK versions installed on my machine ;) Gili Assuming you're talking about building JDK7, this should

Help building under Windows7 64-bit

2010-06-07 Thread cowwoc
Hi, I am attempting to build OpenJDK under Windows7 64-bit, Visual Studio 2010. Here is the output of "make sanity": -- ( cd ./jdk/make && \ make sanity HOTSPOT_IMPORT_CHECK=false JDK_TOPDIR=C:/users/gili/DOCUME~1/jdk7/jdk7/jdk JDK_MAKE_SHARED_DIR=C:/users/gili/DOCUME~1/jd

[PATCH FOR REVIEW]: Unnecessary calls to sync()

2010-06-07 Thread Andrew John Hughes
Is it really necessary for the sanity script to be flushing all buffers to disc on GNU/Linux boxes? ifeq ($(PLATFORM), linux) FREE_SPACE := $(shell $(DF) --sync -kP $(OUTPUTDIR) | $(TAIL) -1 | $(NAWK) '{print $$4;}') TEMP_FREE_SPACE := $(shell $(DF) --sync -kP $(TEMP_DISK) | $(TAIL) -1 | $(NA

Using Java7 as Boot JDK?

2010-06-07 Thread cowwoc
Hi, Has anyone tried building OpenJDK using a JDK7 as the boot JDK? Is there any reason to expect this will fail? Ideally I don't want two different JDK versions installed on my machine ;) Gili -- View this message in context: http://old.nabble.com/Using-Java7-as-Boot-JDK--tp28808783p28808783.

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread cowwoc
Raffaello Giulietti wrote: > > Gili, > > you can find some instructions about how to download a working make > here, in the section "Make" > > http://mail.openjdk.java.net/pipermail/build-dev/2010-May/002955.html > > Hope this helps > Raffaello > > I ended up using http://www.cmake.org/fil

Re: PROCESSOR_IDENTIFIER: command not found

2010-06-07 Thread Raffaello Giulietti
On 2010-06-07 01:20, cowwoc wrote: > > Hi, > > I'm trying to build OpenJDK under Windows7 64-bit with Visual Studio 2010. > When I run jdk_generic_profile.sh I get: > > /cygdrive/c/Users/Gili/Documents/jdk7/jdk7/jdk/make/jdk_generic_profile.sh: > line > 177: PROCESSOR_IDENTIFIER: command not fo