Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Ulf Zibis
Am 30.06.2010 19:50, schrieb Martin Buchholz: On Wed, Jun 30, 2010 at 01:22, Ulf Zibisulf.zi...@gmx.de wrote: Am 29.06.2010 02:29, schrieb Martin Buchholz: I tried to do that, but Character.java is one of those classes that needs to be compilable by the bootstrap JDK, so this

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Ulf Zibis
Oops, it's never superfluous to review again: Line 245: too much spaces Compare line 363 vs 376 etc.: inconsistent indentation after @since Line 598: can be deleted Line 600: 2 spaces after @exception Line 600: 2 spaces after NullPointerException Line 600: better use @throws Line 652: shoudn't

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Martin Buchholz
On Wed, Jun 30, 2010 at 23:49, Ulf Zibis ulf.zi...@gmx.de wrote: Am 30.06.2010 19:50, schrieb Martin Buchholz: On Wed, Jun 30, 2010 at 01:22, Ulf Zibisulf.zi...@gmx.de  wrote: Am 29.06.2010 02:29, schrieb Martin Buchholz: I tried to do that, but Character.java is one of those classes

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Jonathan Gibbons
On 07/01/2010 01:32 AM, Ulf Zibis wrote: Am 01.07.2010 09:38, schrieb Martin Buchholz: On Wed, Jun 30, 2010 at 23:49, Ulf Zibisulf.zi...@gmx.de wrote: Am 30.06.2010 19:50, schrieb Martin Buchholz: On Wed, Jun 30, 2010 at 01:22, Ulf Zibisulf.zi...@gmx.dewrote: Am 29.06.2010 02:29,

NetBeans build

2010-07-01 Thread Pete Brunet
I'm trying to build (on Windows) the NetBeans jdk7 awt2d project and get the following: *C:/SLASHJ~1/re/jdk/1.7.0/promoted/latest/binaries/windows-i586/bin/javac* -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx896m -J-Xms128m

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Ulf Zibis
Jonathan, much thanks. My question is not about the generated parts, it's about following lines 652 private static MapString, UnicodeBlock map 653 = new HashMapString, UnicodeBlock(256); in

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Ulf Zibis
Am 02.07.2010 02:15, schrieb Jonathan Gibbons: Ulf, Have you tried it, and if so, what error do you get? Sorry, no. It was Martin. I don't know the exact error message. Building the whole JDK is outside my resources (Windows, labtop, etc.) :-( . Anyway thanks for your time. -Ulf If you

Re: NetBeans build

2010-07-01 Thread Pete Brunet
I don't know if this has anything to do with the problem but due to this advice The ALT_JDK_IMPORT_PATH setting is only needed if you are not building the entire JDK. from http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html#importjdk I didn't define a ALT_JDK_IMPORT_PATH when

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Martin Buchholz
I just tried to reproduce the failure ... and could not, so it may have been either my fuzzy memory, or perhaps some issue with the import JDK not being sufficiently up to date. Sorry for wasting bandwidth... Standard response to Q: Shouldn't we start using the diamond operator? A: Yes. Write

Re: Pending Character-related work - Character-warnings

2010-07-01 Thread Kelly O'Hair
One of the build tools in jdk/make/tools/src might be using some of the sources in the jdk/src tree, or processing the sources? I don't recall the exact details. In any case, there may be some issue here, sorry I don't recall the details. I'm thinking that the more likely scenario is that