Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread David Holmes
Kelly, Kelly O'Hair said the following on 12/29/10 07:37: Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is in the top repository at make/scripts/update_copyright_year.sh. It finds all changesets created

hg: jdk7/build/jdk: 6991482: Add global jdk makefile options to silence some VS2010 warnings

2010-12-28 Thread kelly . ohair
Changeset: 1c72adc9d5f3 Author:ohair Date: 2010-12-28 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1c72adc9d5f3 6991482: Add global jdk makefile options to silence some VS2010 warnings Reviewed-by: prr ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windo

hg: jdk7/build/langtools: 6962318: Update copyright year

2010-12-28 Thread kelly . ohair
Changeset: 4868a36f6fd8 Author:ohair Date: 2010-12-28 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/4868a36f6fd8 6962318: Update copyright year Reviewed-by: xdono ! make/Makefile ! make/build.properties ! make/tools/CompileProperties/CompileProperties.java !

hg: jdk7/build/jaxp: 6962318: Update copyright year

2010-12-28 Thread kelly . ohair
Changeset: 57ed1f3bec72 Author:ohair Date: 2010-12-28 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/57ed1f3bec72 6962318: Update copyright year Reviewed-by: xdono ! build.properties ! make/Makefile

hg: jdk7/build/jaxws: 6962318: Update copyright year

2010-12-28 Thread kelly . ohair
Changeset: 86f60e5b3975 Author:ohair Date: 2010-12-28 15:53 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/86f60e5b3975 6962318: Update copyright year Reviewed-by: xdono ! build.properties ! jaxws.properties ! make/Makefile

hg: jdk7/build/corba: 6962318: Update copyright year

2010-12-28 Thread kelly . ohair
Changeset: f90b3e014e83 Author:ohair Date: 2010-12-28 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/f90b3e014e83 6962318: Update copyright year Reviewed-by: xdono ! make/Makefile ! make/com/sun/corba/minclude/com_sun_corba_se_impl_io.jmk ! make/common/Defs-linux.

hg: jdk7/build: 6962318: Update copyright year

2010-12-28 Thread kelly . ohair
Changeset: 024a6755895b Author:ohair Date: 2010-12-28 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/build/rev/024a6755895b 6962318: Update copyright year Reviewed-by: xdono ! make/Defs-internal.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread Kelly O'Hair
These changes are only adding the year 2010, to the copyright for files modified in 2010. The "first" year should be preserved. The pattern "YEAR1, YEAR2," in the Oracle copyright line is the equivalent of the old Sun copyright year range "YEAR1-YEAR2". So if the file originally was created

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread Xiomara Jayasena
The changes look good to me. -Xiomara On 12/28/2010 1:37 PM, Kelly O'Hair wrote: Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is in the top repository at make/scripts/update_copyright_year.sh. It fi

Re: Need Reviewer: OpenJDK7 Windows VS2010 warning silencing

2010-12-28 Thread Phil Race
Looks ok to me. -phil. On 12/28/2010 3:19 PM, Kelly O'Hair wrote: Need Reviewer: Windows VS2010 warning silencing With Windows VS2010 compilers, we started seeing many warnings about supposedly insecure function usage. These are not actually detecting errors as much as indicating that certai

Need Reviewer: OpenJDK7 Windows VS2010 warning silencing

2010-12-28 Thread Kelly O'Hair
Need Reviewer: Windows VS2010 warning silencing With Windows VS2010 compilers, we started seeing many warnings about supposedly insecure function usage. These are not actually detecting errors as much as indicating that certain functions used have been known to cause security issues when used

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread John Yeary
Hello Kelly, Shouldn't the original copyrights remain in place? I see there are changes that remove Sun and replace it with Oracle on files from 1995. I would expect that code with changes should include the additional copyright for 2010. Sincerely, John Yeary On Tue, Dec 28, 2010 at 4:37 PM, K

Need reviewer: OpenJDK7 Copyright year updates

2010-12-28 Thread Kelly O'Hair
Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is in the top repository at make/scripts/ update_copyright_year.sh. It finds all changesets created in 2010 and verifies that any sources with copyrights me