Re: Need reviewer: Add vsvars.sh script to jdk7 repo

2010-12-29 Thread Kelly O'Hair
On Dec 29, 2010, at 8:44 PM, Brad Wetmore wrote: Regarding the script you added to the repository: What expectations does this script have in terms of the environment already being setup? For example, can I just install VS2010/cygwin, then run this script, or do I need to set my path to s

Re: Need reviewer: Add vsvars.sh script to jdk7 repo

2010-12-29 Thread Brad Wetmore
Regarding the script you added to the repository: What expectations does this script have in terms of the environment already being setup? For example, can I just install VS2010/cygwin, then run this script, or do I need to set my path to something before I run this? Here's what I hoped I'd

hg: jdk7/build/hotspot: 6 new changesets

2010-12-29 Thread christine . lu
Changeset: cd8189d84e92 Author:trims Date: 2010-12-22 19:20 -0800 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/cd8189d84e92 Added tag hs20-b04 for changeset 9669f9b28410 ! .hgtags Changeset: b03260081e9b Author:johnc Date: 2010-12-17 11:26 -0800 URL: http:

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-29 Thread Kelly O'Hair
On Dec 28, 2010, at 11:13 PM, David Holmes wrote: Kelly, Kelly O'Hair said the following on 12/29/10 07:37: Need reviewer: OpenJDK7 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is in the top repository at make/scripts/ upda

Re: Need Reviewer: OpenJDK7 Windows VS2010 warning silencing

2010-12-29 Thread John Yeary
Looks OK to me. On Tue, Dec 28, 2010 at 6:19 PM, Kelly O'Hair wrote: > Need Reviewer: Windows VS2010 warning silencing > > With Windows VS2010 compilers, we started seeing many warnings about > supposedly insecure function usage. > These are not actually detecting errors as much as indicating tha

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-29 Thread John Yeary
Hello All, Andrew is correct. I was expecting that the copyrights would include the original and then the modified copyrights on the following lines. That has been the case with all of the companies I have worked for when we acquired companies. It has likely been changed for a while in the curren

Re: Need reviewer: OpenJDK7 Copyright year updates

2010-12-29 Thread Dr Andrew John Hughes
On 15:50 Tue 28 Dec , Kelly O'Hair wrote: > These changes are only adding the year 2010, to the copyright for > files modified in 2010. > The "first" year should be preserved. > > The pattern "YEAR1, YEAR2," in the Oracle copyright line is the > equivalent of the old Sun > copyright year r