Changeset: 1f056ddda771
Author:ohair
Date: 2011-01-28 14:32 -0800
URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1f056ddda771
7014301: Change make 3.81 sanity check to a fatal, 3.81 is needed now
Reviewed-by: alanb
! make/common/shared/Sanity.gmk
Changeset: 3f77dae85c85
Author
Changeset: 001dcfd0be4b
Author:ohair
Date: 2011-02-08 16:30 -0800
URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/001dcfd0be4b
7016976: Documentation for required ant version on JDK7 builds on Solaris 10
and Solaris 11
Reviewed-by: rinaldo
! make/common/shared/Defs-versions.gm
Changeset: a6b015b59fbc
Author:ohair
Date: 2011-02-08 16:28 -0800
URL: http://hg.openjdk.java.net/jdk7/build/rev/a6b015b59fbc
7016976: Documentation for required ant version on JDK7 builds on Solaris 10
and Solaris 11
Reviewed-by: rinaldo
! README-builds.html
Need reviewer: ant 1.7.1 or newer needed
This changes the minimum required ant version to 1.7.1 and also makes
it a fatal sanity error
to try and use anything older.
The ant 1.7.1 release was done in July 2008 and is a well known stable
ant release.
7016976: Documentation for required ant
I take that back. Welcome rinaldo to the OpenJDK commit list!
I will put you down as a reviewer. I didn't think you had the OpenJDK
ID yet.
-kto
On Feb 8, 2011, at 4:17 PM, Kelly O'Hair wrote:
I did not know that an ant 1.7.3 even existed.
Thanks for the review. But I still need a second
The changes look good to me as well.
-Xiomara
On 2/8/2011 4:17 PM, Kelly O'Hair wrote:
I did not know that an ant 1.7.3 even existed.
Thanks for the review. But I still need a second reviewer.
-kto
On Feb 8, 2011, at 4:02 PM, Rinaldo DiGiorgio wrote:
Looks good to me. It also worked wit
deploy/make/common/Sanity.gmk has same check i think.
May be it is not needed anymore and we can just start using target fron
JDK makefiles?
We already import Sanity.gmk from jdk workspace there.
Otherwise looks ok to me.
-igor
On 2/8/11 4:17 PM, Kelly O'Hair wrote:
I did not know that an
I did not know that an ant 1.7.3 even existed.
Thanks for the review. But I still need a second reviewer.
-kto
On Feb 8, 2011, at 4:02 PM, Rinaldo DiGiorgio wrote:
Looks good to me. It also worked with 1.7.3
On Feb 8, 2011, at 7:00 PM, Kelly O'Hair wrote:
Need reviewer: ant 1.7.1 or newer
