On 3/7/11 10:10 PM, David Holmes wrote:
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has
been updated - same location.
Looks good. Sorry I didn't catch that CTARGDIR isn't defined as it
exists in the
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has been
updated - same location.
Verified with i586 and non-i586 builds.
Thanks,
David
Gary Benson said the following on 03/07/11 19:57:
Hi David,
I'm good
On Mar 7, 2011, at 4:32 PM, David Holmes wrote:
> Kelly,
>
> Many thanks for the comments.
>
> I could try to lift a single use of JAVASE_EMBEDDED up to the top-level to
> control things like: COMPRESS_JARS=true/false; REDUCED_JRE etc. In which, of
> the many, makefiles would you suggest plac
Andrew,
Many thanks for the feedback:
Dr Andrew John Hughes said the following on 03/08/11 04:30:
On 09:39 Mon 07 Mar , Kelly O'Hair wrote:
General comments:
* Could this not be broken up into smaller changesets to make it easier to
review and catch regressions?
In theory probably, in
Kelly,
Many thanks for the comments.
I could try to lift a single use of JAVASE_EMBEDDED up to the top-level
to control things like: COMPRESS_JARS=true/false; REDUCED_JRE etc. In
which, of the many, makefiles would you suggest placing this? In the
case of COMPRESS_JARS would you want this to
On 09:39 Mon 07 Mar , Kelly O'Hair wrote:
General comments:
* Could this not be broken up into smaller changesets to make it easier to
review and catch regressions?
* There seem to be some whitespace changes that shouldn't be there.
e.g.
- sane-msvcrt_path \
+ sane-msvcrt_path
Just to clarify for people, BUILD_CLIENT_ONLY refers to building the client VM
only.
Some of these variables should be documented in the top level
README-builds.html file, but that
can be done under a separate CR if necessary.
The Library.gmk file seems like it is just a leftover debugging echo?
http://cr.openjdk.java.net/~dholmes/7025066/webrev/
The SE-Embedded product is a combination of open and closed sources. To
allow SE-Embedded to be built from standard OpenJDK sources we need to
apply a number of changes to the SE 7 build system:
- support for building the hotspot client comp
Hi David,
I'm good with these changes, and I'm happy for ergo_zero.c to vanish.
Thanks,
Gary
David Holmes wrote:
> Hopefully all interested parties are addressed in the cc lists.
>
> webrev at:
>
> http://cr.openjdk.java.net/~dholmes/7022370/webrev/
>
> The launcher ergonomics (ergo.c) currently
