Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-08 Thread David Holmes
I've updated the webrev - same location: http://cr.openjdk.java.net/~dholmes/7025066/webrev/ The main section for SE-Embedded is in Defs.gmk as there were some dependencies on settings created in other gmk files. A few files are no longer changed and I removed some unnecessary checks (ie that

Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-08 Thread Kelly O'Hair
Can the echo in Library.gmk be changed to @$(ECHO) ? Otherwise I'm ok with these changes. -kto On Mar 8, 2011, at 3:39 AM, David Holmes wrote: I've updated the webrev - same location: http://cr.openjdk.java.net/~dholmes/7025066/webrev/ The main section for SE-Embedded is in Defs.gmk as

Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-08 Thread Dr Andrew John Hughes
On 10:51 Tue 08 Mar , David Holmes wrote: Andrew, Many thanks for the feedback: Dr Andrew John Hughes said the following on 03/08/11 04:30: On 09:39 Mon 07 Mar , Kelly O'Hair wrote: General comments: * Could this not be broken up into smaller changesets to make it easier

Review request: 7025631 Remove the modules build support from jdk 7

2011-03-08 Thread Mandy Chung
7025631: Remove the modules build support from jdk 7 Webrev at: http://cr.openjdk.java.net/~mchung/7025631/webrev.00/ JDK modularity is targetted for JDK 8 [1]. The modules build is supported in the jigsaw repository [2] and updated to work with the module system. The modules build

Re: Review request: 7025631 Remove the modules build support from jdk 7

2011-03-08 Thread Kelly O'Hair
I think this looks ok, but when we spin up the jdk8 repositories, from jdk7, you will need to get this all back, right? I'm assuming you did full open and open+closed SKIP_BOOT_CYCLE=false builds? You may also want to look at the compare images output and make sure it matches before and

Re: Review request: 7025631 Remove the modules build support from jdk 7

2011-03-08 Thread Mandy Chung
On 03/08/11 14:29, Kelly O'Hair wrote: I think this looks ok, but when we spin up the jdk8 repositories, from jdk7, you will need to get this all back, right? It'll go into jdk8 repo when we integrate jigsaw into it. I can't say for sure whether the same makefile change will stay at that

Re: Review request: 7025631 Remove the modules build support from jdk 7

2011-03-08 Thread Kelly O'Hair
Looks fine. -kto On Mar 8, 2011, at 2:53 PM, Mandy Chung wrote: On 03/08/11 14:29, Kelly O'Hair wrote: I think this looks ok, but when we spin up the jdk8 repositories, from jdk7, you will need to get this all back, right? It'll go into jdk8 repo when we integrate jigsaw into it. I

hg: jdk7/deploy: Added tag jdk7-b132 for changeset 0f62a65fb666

2011-03-08 Thread igor . nekrestyanov
Changeset: b1fafacc3040 Author:katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/rev/b1fafacc3040 Added tag jdk7-b132 for changeset 0f62a65fb666 ! .hgtags

hg: jdk7/deploy/corba: Added tag jdk7-b132 for changeset 1b1e75e8f476

2011-03-08 Thread igor . nekrestyanov
Changeset: 671fe2e623ff Author:katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/corba/rev/671fe2e623ff Added tag jdk7-b132 for changeset 1b1e75e8f476 ! .hgtags

hg: jdk7/deploy/hotspot: 2 new changesets

2011-03-08 Thread igor . nekrestyanov
Changeset: a8d643a4db47 Author:katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/a8d643a4db47 Added tag jdk7-b132 for changeset 0e531ab5ba04 ! .hgtags Changeset: 1b3a350709e4 Author:trims Date: 2011-03-03 15:13 -0800 URL:

hg: jdk7/deploy/jaxp: Added tag jdk7-b132 for changeset abe04c59a556

2011-03-08 Thread igor . nekrestyanov
Changeset: 8e1148c7911b Author:katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/8e1148c7911b Added tag jdk7-b132 for changeset abe04c59a556 ! .hgtags

hg: jdk7/deploy/jaxws: Added tag jdk7-b132 for changeset 0e57c3272d37

2011-03-08 Thread igor . nekrestyanov
Changeset: 359d0c8c00a0 Author:katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/359d0c8c00a0 Added tag jdk7-b132 for changeset 0e57c3272d37 ! .hgtags

hg: jdk7/deploy/jdk: 61 new changesets

2011-03-08 Thread igor . nekrestyanov
Changeset: 7905b047a475 Author:prr Date: 2011-02-08 14:24 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/7905b047a475 7006865: Regression: Corrupted output when printing images with bit depth of 4 Reviewed-by: bae, jgodinez !

hg: jdk7/deploy/langtools: 19 new changesets

2011-03-08 Thread igor . nekrestyanov
Changeset: c6cb387190ee Author:jjg Date: 2011-02-09 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/c6cb387190ee 7016750: tools/javac/nio/CompileTest failing in nightly test Reviewed-by: mcimadamore ! test/tools/javac/nio/compileTest/CompileTest.java