Re: Need preliminary reviewers: Solaris/Linux shared library version changes

2011-03-16 Thread Kelly O'Hair
The logic in the hotspot makefiles that plops the hotspot just built into a copy of the BOOTDIR jdk (normally a jdk6 image) and expects that to run has always been an issue to me. In general, each JDK release changes compilers and potentially C++ runtimes, in my opinion, it is never guaranteed t

Re: Need preliminary reviewers: Solaris/Linux shared library version changes

2011-03-16 Thread David Holmes
Hi Kelly, On the Hotspot side this change would appear to bake in the version info at build time. So when I build Hotspot I will either build for JDK6 or JDK7 or ... and then I wont be able to drop the VM libs I just built into a different version of the JDK - is that right? If so I'd want a

Formal request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-16 Thread David Holmes
webrev: http://cr.openjdk.java.net/~dholmes/7025066/webrev/ This places the SE-Embedded specific targets and definitions into Release-embedded.gmk and Defs-embedded.gmk respectively. These files are unconditionally included but then guarded with ifdef JAVASE_EMBEDDED internally. This avoids th

Need preliminary reviewers: Solaris/Linux shared library version changes

2011-03-16 Thread Kelly O'Hair
Need preliminary reviewers: Solaris/Linux shared library version changes Long story, but the background may be important. It's not a slam dunk that these changes will go into JDK7, we may decide to do this in JDK8. I recognize it is late to be doing this in JDK7. If you have any experience with

hg: jdk7/build/jdk: 7027923: Disable VS2003 use in preparation for all VS2003 make logic removal

2011-03-16 Thread kelly . ohair
Changeset: 554adcfb615e Author:ohair Date: 2011-03-16 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/554adcfb615e 7027923: Disable VS2003 use in preparation for all VS2003 make logic removal Reviewed-by: prr ! make/common/shared/Compiler-msvc.gmk

hg: jdk7/build/jdk: 2 new changesets

2011-03-16 Thread david . katleman
Changeset: d6c6d9566126 Author:katleman Date: 2011-03-16 09:30 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/d6c6d9566126 6973319: incorrect spec version in jdk 7 rt.jar manifest Reviewed-by: ohair ! make/tools/manifest.mf Changeset: 76a2ea69f47f Author:katleman Dat

Re: demo vs. sample directories in the jdk

2011-03-16 Thread mark . reinhold
2011/3/16 7:55 -0700, alan.bate...@oracle.com: > ... Today we have a "sample" and a "demo" directory > and > it's not always clear where to put new sample code. I'm trying to remember why > we have two locations. I think, but might be wrong, that the demo directory is > sam

demo vs. sample directories in the jdk

2011-03-16 Thread Alan Bateman
This isn't really a build issue, more of a question as to where to put sample code in the jdk repository. Today we have a "sample" and a "demo" directory and it's not always clear where to put new sample code. I'm trying to remember why we have two locations. I think, but might be wrong, that

Re: Request for review: Build changes in preparation for SE-Embedded support

2011-03-16 Thread David Holmes
FYI I filed: 7027897 Build support for client-VM only configurations Final webrev at: http://cr.openjdk.java.net/~dholmes/7027897/webrev/ This has now been pushed. Thanks to Mike for picking an error in the comment written into the jvm.cfg file. --- Also filed: 7027910 Add basic cross-com

Re: where is rebase.exe used?

2011-03-16 Thread Weijun Wang
Oh, this is great! Thanks. -Max On 03/16/2011 02:30 PM, Phil Race wrote: I suspect you are interested in the fix for 7020815: REBASE should not be required for windows jdk repo builds - can't build with VS 2010 Express It was pushed a few days ago ... -phil. On 3/15/2011 11:09 PM, Weijun Wa

hg: jdk7/build/jdk: 2 new changesets

2011-03-16 Thread kelly . ohair
Changeset: 3de1fed4b9ec Author:ohair Date: 2011-03-15 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/3de1fed4b9ec 6710813: SwingSet2 source display tabs do not work since JDK 7 b20 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.j