Re: Project Proposal: Build Infrastructure Changes

2011-04-26 Thread Florian Weimer
* Julien Ponge: Did you consider using a tool like cmake to manage the build? Isn't the documentation a bit hard to get? IIRC, it is a self-published book which is not available from many book stores. -- Florian Weimerfwei...@bfk.de BFK edv-consulting GmbH

Re: Project Proposal: Build Infrastructure Changes

2011-04-26 Thread Steve Poole
On 26/04/11 00:36, Kelly O'Hair wrote: On Apr 24, 2011, at 12:17 PM, Lussier, Denis wrote: My two cents are: I think this is great. To say the least, it has historically been challenging and/or non-standard to build OpenJDK (most especially on Windoze). Kelly, a big +1 for this proposal (is

Re: Fwd: Project Proposal: Build Infrastructure Changes

2011-04-26 Thread Steve Poole
On 24/04/11 18:12, Kelly O'Hair wrote: FYI... I sent this, but I'm not seeing any record it was received... :^( -kto Begin forwarded message: *From: *Kelly O'Hair kelly.oh...@oracle.com mailto:kelly.oh...@oracle.com *Date: *April 22, 2011 16:49:29 PM PDT *To: *annou...@openjdk.java.net

Re: Project Proposal: Build Infrastructure Changes

2011-04-26 Thread Julien Ponge
There are other alternatives to cmake, including SCons and such. I asked this because cmake is widely recognized as an excellent cross-platform makefile generator, and you could probably get rid of the need for cygwin on MS Windows. If gmake is the best option then fine, but exploring such

Re: Project Proposal: Build Infrastructure Changes

2011-04-26 Thread Kelly O'Hair
On Apr 26, 2011, at 12:57 AM, Steve Poole wrote: People can become quickly enthused (and stay with it to become a long term contributor) OR they go away and incorrectly assume OpenJDK isn't really open. I'm concerned that your definition of open means we must strictly follow a style or

hg: jdk7/build/langtools: 7039493: incorporating WPTG translation bug fixes

2011-04-26 Thread michael . fang
Changeset: 841e1c6a5914 Author:mfang Date: 2011-04-25 20:16 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/841e1c6a5914 7039493: incorporating WPTG translation bug fixes Reviewed-by: yhuang !

hg: jdk7/build: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: 3bd41d40ab97 Author:ohair Date: 2011-04-26 16:30 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/3bd41d40ab97 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore ! Makefile

hg: jdk7/build/hotspot: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: 4ca65400aa33 Author:ohair Date: 2011-04-26 16:20 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4ca65400aa33 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore

hg: jdk7/build/jaxp: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: 9f7c281af543 Author:ohair Date: 2011-04-26 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/9f7c281af543 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore

hg: jdk7/build/jdk: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: dc63c52bc61f Author:ohair Date: 2011-04-26 16:27 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/dc63c52bc61f 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore ! make/common/Release.gmk ! make/common/shared/Defs-utils.gmk !

Re: Review request (XS): 7037081 Remove com.sun.tracing from NON_CORE_PKGS

2011-04-26 Thread Jonathan Gibbons
On 04/25/2011 11:08 AM, Mandy Chung wrote: Jon, Kelly, Can you review the fix for 7037081: Remove com.sun.tracing from NON_CORE_PKGS This fix removes the generation of javadoc for this package and adds com.sun.tracing to the javac's legacy.properties that javac will issue warnings of any

hg: jdk7/build/langtools: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: c2e7291e98e7 Author:ohair Date: 2011-04-26 16:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/c2e7291e98e7 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore

hg: jdk7/build: 2 new changesets

2011-04-26 Thread kelly . ohair
Changeset: b1fafacc3040 Author:katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/build/rev/b1fafacc3040 Added tag jdk7-b132 for changeset 0f62a65fb666 ! .hgtags Changeset: 27384dd2d8ed Author:ohair Date: 2011-03-03 15:29 -0800 URL:

Need reviewer: Turn off warnings for mapfiles in fastdebug builds

2011-04-26 Thread Kelly O'Hair
Need reviewer: Turn off warnings for mapfiles in fastdebug builds The mapfiles are generally not used on fastdebug or debug builds, this just turns off the warning in these cases, making it just an informative piece of information. 7033960: Do not check for mapfiles when fastdebug building

Re: Need reviewer: Copyright year updates

2011-04-26 Thread Kelly O'Hair
Correct. I ran this first, to make sure some of the last 2010 changesets pushed in were covered for 2010: sh ./make/scripts/update_copyright_year.sh 2010 Then I ran sh ./make/scripts/update_copyright_year.sh 2011 To catch all the 2011 changesets. So I would expect a few to be updates to

Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-04-26 Thread David Holmes
Andrew, Dr Andrew John Hughes said the following on 03/09/11 03:24: On 10:51 Tue 08 Mar , David Holmes wrote: Just to clarify for people, BUILD_CLIENT_ONLY refers to building the client VM only. Some of these variables should be documented in the top level README-builds.html file, but

Re: JDK8 Preliminary Repository Layout

2011-04-26 Thread Jonathan Gibbons
Having jdk/test and jdk/closed/test will make it harder[*] to run all the jdk tests in a single run using jtreg directly. -- Jon [*] Brit-speak for impossible. On 03/08/2011 06:32 PM, Kelly O'Hair wrote: First, if we talk about the mercurial forests, it has nothing to do with the

hg: jdk7/build: 7026167: Broken fastdebug only build

2011-04-26 Thread kelly . ohair
Changeset: c6f380693342 Author:ohair Date: 2011-03-09 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/build/rev/c6f380693342 7026167: Broken fastdebug only build Reviewed-by: cl ! Makefile

Re: hg: jdk7/deploy/langtools: 19 new changesets

2011-04-26 Thread Dr Andrew John Hughes
Is it necessary to have all these posted to build-dev? There doesn't seem to be any work going on, just merging as far as I can see. Shouldn't this be on its own deploy-dev list? As far as I'm aware, the deploy team don't do any OpenJDK work anyway. On 01:30 Wed 09 Mar ,

hg: jdk7/build/jdk: 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places

2011-04-26 Thread kelly . ohair
Changeset: c28f5ac2d5f8 Author:ohair Date: 2011-03-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c28f5ac2d5f8 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung, herrick ! make/common/shared/Defs-javadoc.gmk !

hg: jdk7/build/jdk: 2 new changesets

2011-04-26 Thread kelly . ohair
Changeset: 9d1f5ad258f8 Author:ohair Date: 2011-04-04 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9d1f5ad258f8 7029905: demo applets missing some html files Reviewed-by: omajid, mchung, igor ! make/mkdemo/jfc/Font2DTest/Makefile ! make/mkdemo/jfc/Java2D/Makefile

Re: Need reviewer: Turn off warnings for mapfiles in fastdebug builds

2011-04-26 Thread Kelly O'Hair
On Apr 5, 2011, at 8:30 PM, Daniel D. Daugherty wrote: Looks good to me also. :-) Dan P.S. So the missing endif at the end didn't cause any errors? Before I changed the files, they ended with endif and no newline, I just added a newline at the end -kto On 4/5/2011 6:29 PM, Kelly

hg: jdk7/build/jdk: 7019210: Fix misc references to /bugreport websites

2011-04-26 Thread kelly . ohair
Changeset: eaca823dd3fe Author:ohair Date: 2011-04-07 19:59 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/eaca823dd3fe 7019210: Fix misc references to /bugreport websites Reviewed-by: skannan ! make/docs/Makefile ! src/share/classes/com/sun/beans/TypeResolver.java !

hg: jdk7/build: Added tag jdk7-b133 for changeset c6f380693342

2011-04-26 Thread michael . fang
Changeset: ddc2fcb3682f Author:cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/build/rev/ddc2fcb3682f Added tag jdk7-b133 for changeset c6f380693342 ! .hgtags

Re: Need reviewer: demo fixes from a long time ago ...

2011-04-26 Thread Kelly O'Hair
On Mar 15, 2011, at 3:50 PM, Mandy Chung wrote: On 3/15/11 2:25 PM, Kelly O'Hair wrote: Need reviewer for these 2 demo fixes: 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.jar 6710813: SwingSet2 source display tabs do not work since JDK 7 b20

Auto Reply: build-dev Digest, Vol 48, Issue 9

2011-04-26 Thread ivan . krylov
This is an automated reply message. I will be at JavaOne in Moscow on April 11th-13th. The response time might be bigger than usual. For all urgent issues please contact Misha Bykov at misha.by...@oracle.com. Please keep me in CC lists for all emails so that I catch up with the status upon

Re: Need reviewer: CC_VER checks on compiler options

2011-04-26 Thread Kelly O'Hair
On Apr 22, 2011, at 12:12 AM, David Holmes wrote: Hi Kelly, Kelly O'Hair said the following on 04/22/11 07:33: This started out as an annoyance around the use of -Wno-clobber on Linux when the gcc might not support it. Turned into fixing several CC_VER checks in the makefiles: 7038711:

hg: jdk7/build/jaxws: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: 576612237ba6 Author:ohair Date: 2011-04-26 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/576612237ba6 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore

Re: Need reviewer: Correcting jar manifests

2011-04-26 Thread Mandy Chung
On 4/21/11 7:31 PM, Kelly O'Hair wrote: Need reviewer for these jar manifest changes. Multiple issues here: * Bean manifest information should only be in rt.jar, not resources.jar, jsse.jar, * Added missing basic jdk manifest information into demo jar manifests * JCE jars manifest

Re: Fwd: Project Proposal: Build Infrastructure Changes

2011-04-26 Thread Alan Bateman
Kelly O'Hair wrote: FYI... I sent this, but I'm not seeing any record it was received... :^( -kto I don't see it in the archives either. Anyway it is great to hear that the build will be getting attention, it's long overdue. I think the project will need to work closely with the Jigsaw

Error when building openjdk 7

2011-04-26 Thread jingguo yao
I am using Ubuntu desktop 10.04. And I ran the following commands to set up the build environment (SUN JDK 1.6.0_24 is used): export LANG=C expor ALT_BOOTDIR=/usr/lib/jvm/java-6-sun And make sanity passed. There was the following error when running make: make[5]: Leaving directory

Need Reviewer: change MAX_VM_MEMORY to 512

2011-04-26 Thread suchen.ch...@oracle.com
Need Reviewer: change MAX_VM_MEMORY to 512 Windows systems may not be able to handle 896 max memory on every java app started up. Depends on what the system is running, even on a 2Gb system. Recommend lowering the 896 to 640 or maybe even 512 if possible. 6903609: Max memory of 896 may be

hg: jdk7/build: Added tag jdk7-b138 for changeset fc47c97bbbd9

2011-04-26 Thread kelly . ohair
Changeset: 7ed6d0b9aaa1 Author:schien Date: 2011-04-14 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/7ed6d0b9aaa1 Added tag jdk7-b138 for changeset fc47c97bbbd9 ! .hgtags

hg: jdk7/build/hotspot: Added tag jdk7-b138 for changeset 0930dc920c18

2011-04-26 Thread kelly . ohair
Changeset: 2705303a05c4 Author:schien Date: 2011-04-14 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/2705303a05c4 Added tag jdk7-b138 for changeset 0930dc920c18 ! .hgtags

Re: openJDK7 build fails on 64bit cblfs linux

2011-04-26 Thread luxInteg
On Sunday 17 April 2011 14:39:59 luxInteg wrote: On Sunday 17 April 2011 12:15:56 luxInteg wrote: On Sunday 17 April 2011 06:50:42 David Holmes wrote: -- I then fumbled around and seem to have goot lucky -the build miraclously ended like so:-

Re: Need reviewer: CC_VER checks on compiler options

2011-04-26 Thread Igor Nekrestyanov
I do not see anything obviously wrong in this change (did not validate that all used macros actually equivalent though). So, looks ok for push. -igor On 4/21/11 2:33 PM, Kelly O'Hair wrote: This started out as an annoyance around the use of -Wno-clobber on Linux when the gcc might not

Re: Need reviewer: CC_VER checks on compiler options

2011-04-26 Thread Kelly O'Hair
On Apr 21, 2011, at 2:53 PM, Dr Andrew John Hughes wrote: On 14:33 Thu 21 Apr , Kelly O'Hair wrote: This started out as an annoyance around the use of -Wno-clobber on Linux when the gcc might not support it. Turned into fixing several CC_VER checks in the makefiles: 7038711: Fix

Re: Need reviewer: Correcting jar manifests

2011-04-26 Thread Julien Ponge
I'm certainly not qualified to have a voice on the review, but I looked anyway and it is ok. Cheers -- Julien Ponge http://julien.ponge.info/ On Friday, April 22, 2011 at 4:31 AM, Kelly O'Hair wrote: Need reviewer for these jar manifest changes. Multiple issues here: * Bean manifest

hg: jdk7/build/corba: 6631003: Add hg tip changeset to build image

2011-04-26 Thread kelly . ohair
Changeset: 96dd337fc845 Author:ohair Date: 2011-04-26 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/96dd337fc845 6631003: Add hg tip changeset to build image Reviewed-by: mduigou ! .hgignore