Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

2011-05-04 Thread John Coomes
David Holmes (david.hol...@oracle.com) wrote: > Okay now that my brain is functioning again lets see if it is third-time > lucky: > > http://cr.openjdk.java.net/~dholmes/7036525/webrev.2/ > > This reverts things back to my original webrev where we set > HS_ALT_SRC_REL to NO_SUCH_PATH. It has to

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

2011-05-04 Thread David Holmes
Okay now that my brain is functioning again lets see if it is third-time lucky: http://cr.openjdk.java.net/~dholmes/7036525/webrev.2/ This reverts things back to my original webrev where we set HS_ALT_SRC_REL to NO_SUCH_PATH. It has to be a non-existent path otherwise it will appear in the ge

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

2011-05-04 Thread David Holmes
John Coomes said the following on 05/05/11 04:36: David Holmes (david.hol...@oracle.com) wrote: John Coomes said the following on 05/04/11 02:37: David Holmes (david.hol...@oracle.com) wrote: I've just made the change as John suggested and to be honest I don't know why I didn't think of that m

hg: jdk7/build/jdk: 7041284: arm/ppc Missing launcher mapfiles prevent build

2011-05-04 Thread david . holmes
Changeset: fbe3a3401786 Author:dholmes Date: 2011-05-04 22:16 -0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/fbe3a3401786 7041284: arm/ppc Missing launcher mapfiles prevent build Summary: Disable use of launcher mapfiles when cross-compiling Reviewed-by: ohair, ksrini ! m

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Kelly O'Hair
On May 4, 2011, at 5:42 PM, Dr Andrew John Hughes wrote: >> >> 7042040: Remove disk space sanity check >> > > Ok, if > > http://cr.openjdk.java.net/~andrew/sync/webrev.02/ > > looks ok, I'll push it to the build tree. Files: jdk/make/common/shared/Defs-versions.gmk jdk/make/common/share

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Dr Andrew John Hughes
On 16:27 Wed 04 May , Kelly O'Hair wrote: > > > I agree we should toss the check. > > > > > I'll need a bug ID for this. > > 7042040: Remove disk space sanity check > Ok, if http://cr.openjdk.java.net/~andrew/sync/webrev.02/ looks ok, I'll push it to the build tree. > > -kto > > >

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Kelly O'Hair
On May 4, 2011, at 4:19 PM, Dr Andrew John Hughes wrote: > On 15:37 Wed 04 May , David Katleman wrote: >> Would be interesting to know the original objection to Andrew's change >> last year. >> > > If there was one, it never reached me either publicly or otherwise. > The archives show no r

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Dr Andrew John Hughes
On 15:37 Wed 04 May , David Katleman wrote: > Would be interesting to know the original objection to Andrew's change > last year. > If there was one, it never reached me either publicly or otherwise. The archives show no responses. > Absent that, I see no reason this could not be removed an

hg: jdk7/build/langtools: 2 new changesets

2011-05-04 Thread kelly . ohair
Changeset: 2637cf09460b Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/2637cf09460b Added tag jdk7-b140 for changeset 258e6654aba2 ! .hgtags Changeset: 90adb5d6adc7 Author:schien Date: 2011-05-02 09:38 -0700 URL:

hg: jdk7/build/jdk: 6 new changesets

2011-05-04 Thread kelly . ohair
Changeset: 1501eb97583c Author:schien Date: 2011-04-29 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1501eb97583c 6903609: Max memory of 896 may be too large for typical windows developer environment Reviewed-by: ksrini, katleman ! make/common/shared/Platform.gmk

hg: jdk7/build/jaxws: 2 new changesets

2011-05-04 Thread kelly . ohair
Changeset: e3c53d486eec Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/e3c53d486eec Added tag jdk7-b140 for changeset 82a9022c4f21 ! .hgtags Changeset: 66826b0aec5a Author:schien Date: 2011-05-02 09:36 -0700 URL: http

hg: jdk7/build/jaxp: 2 new changesets

2011-05-04 Thread kelly . ohair
Changeset: 2d68646d98ba Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/2d68646d98ba Added tag jdk7-b140 for changeset c8136fd161c8 ! .hgtags Changeset: e1b5ef243445 Author:schien Date: 2011-05-02 09:36 -0700 URL: http:

hg: jdk7/build/hotspot: 34 new changesets

2011-05-04 Thread kelly . ohair
Changeset: f789bf584429 Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f789bf584429 Added tag jdk7-b140 for changeset d283b8296671 ! .hgtags Changeset: 41c663fc6be1 Author:schien Date: 2011-05-02 09:36 -0700 URL: ht

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Erik Trimble
On 5/4/2011 3:37 PM, David Katleman wrote: Would be interesting to know the original objection to Andrew's change last year. Absent that, I see no reason this could not be removed and the change looks fine. When originally implemented 10+ years ago, disk space was considerably smaller, as w

hg: jdk7/build/corba: 2 new changesets

2011-05-04 Thread kelly . ohair
Changeset: befd1fce6339 Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/befd1fce6339 Added tag jdk7-b140 for changeset cdf5d19ec142 ! .hgtags Changeset: a58635cdd921 Author:schien Date: 2011-05-02 09:35 -0700 URL: http

hg: jdk7/build: 2 new changesets

2011-05-04 Thread kelly . ohair
Changeset: 13db01f974ce Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/13db01f974ce Added tag jdk7-b140 for changeset dcfe74f1c655 ! .hgtags Changeset: c6569c558585 Author:schien Date: 2011-05-02 09:35 -0700 URL: http://hg.

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread David Katleman
Would be interesting to know the original objection to Andrew's change last year. Absent that, I see no reason this could not be removed and the change looks fine. When originally implemented 10+ years ago, disk space was considerably smaller, as were buffers, so an accurate count was more r

Re: Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Dr Andrew John Hughes
On 17:35 Wed 04 May , Omair Majid wrote: > Hi, > > Can someone please review the following webrev? > > http://cr.openjdk.java.net/~omajid/webrevs/no-sync/01/ > > It modifies the sanity check (under linux) to use df without --sync when > it computes the free space. This is what is done in th

Request for review: do not use --sync with df during sanity check

2011-05-04 Thread Omair Majid
Hi, Can someone please review the following webrev? http://cr.openjdk.java.net/~omajid/webrevs/no-sync/01/ It modifies the sanity check (under linux) to use df without --sync when it computes the free space. This is what is done in the solaris case. The accuracy gained by using --sync is prob

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

2011-05-04 Thread John Coomes
David Holmes (david.hol...@oracle.com) wrote: > John Coomes said the following on 05/04/11 02:37: > > David Holmes (david.hol...@oracle.com) wrote: > >> I've just made the change as John suggested and to be honest I don't > >> know why I didn't think of that myself. I do see your point though, by