Re: Build portability: enable or disable warnings

2011-05-19 Thread Alan Bateman
David Holmes wrote: : In contrast, there are basically two Java compilers in general use (javac and ecj) and one is part of OpenJDK. Yet, the Java code does not have -Werror enabled by default and there are a mass of warnings there as a result. I don't understand the point you are making h

Re: Build portability: enable or disable warnings

2011-05-19 Thread Erik Trimble
On 5/18/2011 12:23 PM, Dr Andrew John Hughes wrote: On 07:25 Mon 16 May , Erik Trimble wrote: On 5/16/2011 6:03 AM, Andrew Haley wrote: On 05/16/2011 12:08 PM, Dalibor Topic wrote: The reason I'm asking is that I'm wondering if this is something we should expect to crop up in different pa

Re: Build portability: enable or disable warnings

2011-05-19 Thread Kelly O'Hair
On May 19, 2011, at 11:32 AM, Alan Bateman wrote: > David Holmes wrote: >> : >> >>> In contrast, there are basically two Java compilers in general use (javac >>> and ecj) >>> and one is part of OpenJDK. Yet, the Java code does not have -Werror >>> enabled by default and there >>> are a mass o

Re: Build portability: enable or disable warnings

2011-05-19 Thread Jonathan Gibbons
On 05/19/2011 08:00 AM, Kelly O'Hair wrote: On May 19, 2011, at 11:32 AM, Alan Bateman wrote: David Holmes wrote: : In contrast, there are basically two Java compilers in general use (javac and ecj) and one is part of OpenJDK. Yet, the Java code does not have -Werror enabled by default an

Re: Build portability: enable or disable warnings

2011-05-19 Thread Dr Andrew John Hughes
On 09:47 Thu 19 May , David Holmes wrote: > Dr Andrew John Hughes said the following on 05/19/11 05:29: > > On 08:35 Mon 16 May , Kelly O'Hair wrote: > > >> The -Werror option is a blessing and a curse. I find it highly commendable > >> that teams (like > >> hotspot) have taken a 'no war

Re: Build portability: enable or disable warnings

2011-05-19 Thread Dr Andrew John Hughes
On 10:32 Thu 19 May , Alan Bateman wrote: > David Holmes wrote: > > : > > > >> In contrast, there are basically two Java compilers in general use > >> (javac and ecj) > >> and one is part of OpenJDK. Yet, the Java code does not have -Werror > >> enabled by default and there > >> are a mass o

Re: Build portability: enable or disable warnings

2011-05-19 Thread Dr Andrew John Hughes
On 17:00 Thu 19 May , Kelly O'Hair wrote: > snip... > > But yes, a great project would be to see if we could get to 'javac -Xlint:all > -Werror' someday. > We really should... in fact it should be a requirement moving forward that > all java code be warning free, and stay that way. > S

Re: Build portability: enable or disable warnings

2011-05-19 Thread Alan Bateman
Jonathan Gibbons wrote There's a useful interim milestone which is relatively trivial to do. If javac -Xlint:all gives warnings, you can go javac -Xlint:all,-xyz to disable the xyz category of warnings. The specific value of xyz to use is given at the beginning of the warning message in squa

Re: Build portability: enable or disable warnings

2011-05-19 Thread David Holmes
Dr Andrew John Hughes said the following on 05/20/11 06:24: On 09:47 Thu 19 May , David Holmes wrote: Dr Andrew John Hughes said the following on 05/19/11 05:29: On 08:35 Mon 16 May , Kelly O'Hair wrote: The -Werror option is a blessing and a curse. I find it highly commendable that t

Re: Build portability: enable or disable warnings

2011-05-19 Thread Jonathan Gibbons
On 05/19/2011 02:20 PM, David Holmes wrote: javac produces new warnings because new language features cause new potential issues. David, FYI, javac has more warnings than you describe. For example, -Xlint:fallthrough warns about falling from one case in a switch statement into another. T

Re: Build portability: enable or disable warnings

2011-05-19 Thread David Holmes
Jonathan Gibbons said the following on 05/20/11 09:39: On 05/19/2011 02:20 PM, David Holmes wrote: javac produces new warnings because new language features cause new potential issues. David, FYI, javac has more warnings than you describe. For example, -Xlint:fallthrough warns about fall

Fwd: Heads up, new jaxp source drop

2011-05-19 Thread Kelly O'Hair
FYI... -kto Begin forwarded message: > From: "Kelly O'Hair" > Date: May 19, 2011 17:53:36 PM GMT+02:00 > To: core-libs-dev > Subject: Heads up, new jaxp source drop > > Heads up. The jdk7/tl forest has a new jaxp source drop dependency. > > 7044493: Incorrectly formated GPL headers in JDK7