Re: Review Request: Build-infra M1

2012-03-22 Thread Fredrik Öhrström
- david.hol...@oracle.com skrev: > My major concern with the transition here is being able to take > existing knowledge of the build system and be able to figure out where in the > new system certain things are handled. How can I tell if a Makefile is > part of the old build or the new build?

Re: Review Request: Build-infra M1

2012-03-22 Thread Erik Joelsson
Hello, Fredrik already answered most of this but I will add my own comments. On 2012-03-22 07:15, David Holmes wrote: Hi Erik, My major concern with the transition here is being able to take existing knowledge of the build system and be able to figure out where in the new system certain thin

Re: Review Request: Build-infra M1

2012-03-22 Thread David Holmes
Hi Fredrik, On 22/03/2012 5:05 PM, Fredrik Öhrström wrote: - david.hol...@oracle.com skrev: It is still unclear to me how cross-compilation is to be set up. You can cross compile from x64 linux to ia32 linux, with the following commandline: ../autoconf/configure \ --host=i686-unknown

Re: Review Request: Build-infra M1

2012-03-22 Thread David Holmes
On 22/03/2012 6:35 PM, Fredrik Öhrström wrote: - david.hol...@oracle.com skrev: I tried this today and got a javac error compiling a Java2D demo - as report to the build-infra list. You are building a closed demo. The fix that written by Alan 2 weeks ago: "Java2Demo breaks build, incompa

Re: Review Request: Build-infra M1

2012-03-22 Thread Fredrik Öhrström
- david.hol...@oracle.com skrev: > > I tried this today and got a javac error compiling a Java2D demo - as > report to the build-infra list. You are building a closed demo. The fix that written by Alan 2 weeks ago: "Java2Demo breaks build, incompatible method in the same class" has not been

Re: Review Request: Build-infra M1

2012-03-22 Thread Fredrik Öhrström
- david.hol...@oracle.com skrev: > I couldn't access /home/ohrstrom either :( You can replace my home directory with yours. ;-) > I guess this needs to be taken up internally to see how this > build-deps > stuff is to be setup, configured, and maintained. Something for M2 > perhaps. Yes,

Re: Review Request: Build-infra M1

2012-03-22 Thread Fredrik Öhrström
Until we have done the integration later today. Please just build the openjdk. Thanks! //Fredrik - david.hol...@oracle.com skrev: > On 22/03/2012 6:35 PM, Fredrik Öhrström wrote: > > > > - david.hol...@oracle.com skrev: > >> > >> I tried this today and got a javac error compiling a Jav

Re: Review Request: Build-infra M1

2012-03-22 Thread Erik Joelsson
On 2012-03-22 09:32, David Holmes wrote: The question was why do I have to cd into common/makefiles to run the configure script. I think the answer is "because if you are in common/makefiles then a build directory will be created at the top-level of the repo forest; otherwise the pwd will b

Re: Review Request: Build-infra M1

2012-03-22 Thread Erik Joelsson
I just noticed that due to a hg config error, my last integ didn't get pushed to this particular repo. Fixed now. /Erik On 2012-03-22 09:37, David Holmes wrote: On 22/03/2012 6:35 PM, Fredrik Öhrström wrote: - david.hol...@oracle.com skrev: I tried this today and got a javac error comp

Re: RFR: 7155585: Fix ifeq errors in makefiles [macosx]

2012-03-22 Thread Anthony Petrov
Hi Michael, Changes to awt/font makefiles look fine to me. -- best regards, Anthony On 03/21/12 19:03, Michael McMahon wrote: Could I get the following change reviewed please for jdk 8? It is to fix a number of minor build warnings caused by the macosx changes. http://cr.openjdk.java.net/~mi

java -version different on Win vs Cygwin

2012-03-22 Thread Pete Brunet
I get different versions when I do the following. Why? Win 7 DOS prompt: \Windows\System32\java -version Cygwin prompt: /cygdrive/c/Windows/System32/java -version Is that java.exe a stub that routes to a different java.exe? How do I control which java is activated?

Fwd: java -version different on Win vs Cygwin

2012-03-22 Thread Pete Brunet
I think I found the answer here: http://www.curlybrace.com/words/2010/12/17/console-and-cygwin-dont-show-all-files-on-64-bit-windows/ Quote: This is because Cygwin bash and Console are 32-bit applications, and I'm running 64-bit Windows. With filesystem virtualization on Windows, when a 32-bit pro

Re: Fwd: java -version different on Win vs Cygwin

2012-03-22 Thread Fredrik Öhrström
Interesting. Could it be the 64 bit windows file system virtualization that slow down cygwin so much on 64-bit windows? Are other 32 bit applications as slow? //Fredrik - peter.bru...@oracle.com skrev: > I think I found the answer here: > http://www.curlybrace.com/words/2010/12/17/con

Fwd: Fwd: java -version different on Win vs Cygwin

2012-03-22 Thread Pete Brunet
Should the 64 bit Win installer also install the 32 bit program? If not it would be good to put a warning on download page. Original Message Subject:Fwd: java -version different on Win vs Cygwin Date: Thu, 22 Mar 2012 09:49:43 -0500 From: Pete Brunet Reply-To:

Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Martijn Verburg
Hi all, I'm back from holiday and am building the latest ( http://hg.openjdk.java.net/jdk8/tl/jdk) project for our 3rd Java User Group OpenJDK hack day. I've run across an error that I haven't been able to resolve. .. .. ../../../build/linux-i586/tmp/java/java.lang/java/obj/Thread.o:(.data.rel+0x

Re: Review Request: Build-infra M1

2012-03-22 Thread Andrew Hughes
- Original Message - > - david.hol...@oracle.com skrev: > snip... > > > It is still unclear to me how cross-compilation is to be set up. > > You can cross compile from x64 linux to ia32 linux, with the > following > commandline: > > ../autoconf/configure \ >--host=i686-unkn

Re: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Andrew Hughes
- Original Message - > Hi all, > > I'm back from holiday and am building the latest ( > http://hg.openjdk.java.net/jdk8/tl/jdk ) project for our 3rd Java > User Group OpenJDK hack day. I've run across an error that I haven't > been able to resolve. > > .. > .. > ../../../build/linux-i586/

Re: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Andrew Hughes
- Original Message - > - Original Message - > > Hi all, > > > > I'm back from holiday and am building the latest ( > > http://hg.openjdk.java.net/jdk8/tl/jdk ) project for our 3rd Java > > User Group OpenJDK hack day. I've run across an error that I > > haven't > > been able to res

Re: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Alan Bateman
On 22/03/2012 15:19, Martijn Verburg wrote: Hi all, I'm back from holiday and am building the latest (http://hg.openjdk.java.net/jdk8/tl/jdk) project for our 3rd Java User Group OpenJDK hack day. I've run across an error that I haven't been able to resolve. .. .. ../../../build/linux-i586/t

Re: Review Request: Build-infra M1

2012-03-22 Thread Jonathan Gibbons
On 03/22/2012 08:33 AM, Andrew Hughes wrote: It's not clear to me why it's a good idea to remove traces of the 'closed' JDK from the makefiles. Wouldn't this only cause more divergence and mean that the core OpenJDK makefiles aren't being tested as much? Andrew, Many developers, and our inte

Re: Review Request: Build-infra M1

2012-03-22 Thread Fredrik Öhrström
- ahug...@redhat.com skrev: > What is this builddeps server? Is it something that's worth emulating > elsewhere? A builddeps server is simply an ftp server with tar.gz or zip archives. The builddeps autoconf macros are inspired by the pkg-config macros. Lets look at this extract from configu

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-22 Thread Daniel D. Daugherty
Greetings, I've backported the FDS changes to JDK7u6. Here's the webrevs: http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-jdk/ http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/0-7u6-hotspot/

Re: Review Request: Build-infra M1

2012-03-22 Thread Dalibor Topic
On 3/22/12 5:34 PM, Fredrik Öhrström wrote: > I know, but the benefit of having the configure script executable > in the repo is tremendous, so the extra hassle is worth it. > In particular if you want to use builddeps to bootstrap the build > environment on for example a Solaris machine. Not to

Re: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Martijn Verburg
Hi Andrew/Alan, Thanks for responding! I suspect you are right, I'm only building the tl project, which i guess is a partial build? I saw the patch that Andrew mentioned but hadn't put 2 and 2 together that I'd need to build the hotspot part separately first. I'll try that next, my next post will

Re: Review Request: Build-infra M1

2012-03-22 Thread Alan Bateman
On 21/03/2012 14:07, Erik Joelsson wrote: : jdk, all changes including a partial copy of the old makefiles. http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-new/ Fredrik - I think it would be better to leave Modul

Re: Review Request: Build-infra M1

2012-03-22 Thread Fredrik Öhrström
Yes, of course, I just pushed a fix. Have you changed the class analyzer to output a text file with the mapping of the sources? e.g. java/lang/Object.java jdk.base/java/langObject.java //Fredrik - alan.bate...@oracle.com skrev: > On 21/03/2012 14:07, Erik Joelsson wrote: : > > jdk,

Re: Review Request: Build-infra M1

2012-03-22 Thread David Holmes
A few specific comments ... On 23/03/2012 2:34 AM, Fredrik Öhrström wrote: - ahug...@redhat.com skrev: What is this builddeps server? Is it something that's worth emulating elsewhere? This feature to easily acquire the build dependencies is very useful for us, since it makes it easy to

Re: Review Request: Build-infra M1

2012-03-22 Thread Alan Bateman
On 22/03/2012 21:21, Fredrik Öhrström wrote: Yes, of course, I just pushed a fix. Thanks, I just wanted to check as it is the webrev. Have you changed the class analyzer to output a text file with the mapping of the sources? e.g. java/lang/Object.java jdk.base/java/langObject.java We should

Re: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Alan Bateman
On 22/03/2012 17:51, Martijn Verburg wrote: Hi Andrew/Alan, Thanks for responding! I suspect you are right, I'm only building the tl project, which i guess is a partial build? I saw the patch that Andrew mentioned but hadn't put 2 and 2 together that I'd need to build the hotspot part separat

Re: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName

2012-03-22 Thread Weijun Wang
A partial build is you go inside tl/jdk/make/ and run make there, it only builds the tl/jdk part, and the output goes to tl/jdk/build/linux-i586. A full build is you go inside tl/ and run make there, it builds all repos, and output goes to tl/build/linux-i586. I suspect you're doing a partial