Need reviewer - @GenerateNativeHeader

2012-05-22 Thread Kelly O'Hair
7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). On classes that have "native" m

Re: Review Request: Build-infra update

2012-05-22 Thread Kelly O'Hair
Not sure where we are on these changes. I have made sure that they don't regress the old builds and am ready to integrate, but I'm concerned on Alan's modularity comment, and also who should I be adding to the "Reviewed-by" list. Also, I'm thinking I should separate the changes in the jdk repo

Re: Review Request: Build-infra update

2012-05-22 Thread Erik Joelsson
New webrevs published (those ending in .1): http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ All issues below have been addressed. There are also some other improvements that we felt should get in now. /Erik On 2012-05-16 23:21, Fre

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-05-22 Thread Magnus Ihse Bursie
On 2012-05-22 03:48, Kelly O'Hair wrote: On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote: On 2012-05-02 00:19, Kelly Ohair wrote: Magnus, Do you still need this integrated? I can integrate the exact same changset to awt, 2d, and build forests if you want. Yes, I still like to have th