Re: Need reviewer: build-infra makefile changes

2012-06-11 Thread Magnus Ihse Bursie
On 2012-06-11 14:57, Erik Joelsson wrote: And I've found two issues in the windows build that I would like to correct. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ Looks fine to me! /Magnus

Re: Need reviewer: build-infra makefile changes

2012-06-11 Thread Kelly O'Hair
I just pushed this change in. -kto On Jun 11, 2012, at 5:57 AM, Erik Joelsson wrote: > And I've found two issues in the windows build that I would like to correct. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ > > makefiles/java/redist/sajdi/Makefile > The windo

hg: jdk8/build/jdk: 7175966: Fix windows build issues for build-infra project

2012-06-11 Thread kelly . ohair
Changeset: e00f450a3c5f Author:erikj Date: 2012-06-11 09:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e00f450a3c5f 7175966: Fix windows build issues for build-infra project Reviewed-by: ohair ! makefiles/CompileJavaClasses.gmk ! makefiles/java/redist/sajdi/Makefile

Re: Need reviewer: build-infra makefile changes

2012-06-11 Thread Erik Joelsson
And I've found two issues in the windows build that I would like to correct. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ makefiles/java/redist/sajdi/Makefile The windows build broke when the full debug symbols were introduced.

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-11 Thread Keith McGuigan
I can shepherd this through the hotspot-rt repository, where it will filter up to hotspot-main and then jdk8/hotspot. I'll make a CR for this too. http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot -- - Keith On 6/11/2012 6:10 AM, Volker Simonis wrote: Should this change be against http://

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-11 Thread Volker Simonis
Should this change be against http://hg.openjdk.java.net/jdk8/build/hotspot or better for http://hg.openjdk.java.net/hsx/hotspot-main/hotspot? On Mon, Jun 11, 2012 at 12:01 PM, Volker Simonis wrote: > I found the problem! > > It's related to the use of precompiled headers. We need to use > '-fpch

Re: Missing/wrong build dependencies for inline functions in HotSpot

2012-06-11 Thread Volker Simonis
I found the problem! It's related to the use of precompiled headers. We need to use '-fpch-deps' in order to get the full dependencies, otherwise all the dependencies from the pch file are omitted. I'm currently preparing a webrev which fixes the problem. It would be nice if somebody could meanw