Kelly, that's correct, you did. It was my oversight that you were not
listed. Dan - thanks again.
Brace yourselves for the rest of the MinGW/MSYS changes in bug #7152336
- hotspot got off relatively easily.
Tim
On 08/03/12 18:34, Daniel D. Daugherty wrote:
On 8/3/12 6:08 PM, Kelly O'Hair
On 8/3/12 6:08 PM, Kelly O'Hair wrote:
I thought you would have done ahg commit --user tbell so it belongs to
Tim?
Yes, the changeset belongs to Tim, but I also listed
him as a reviewer since he reviewed the code as well.
I did a review too, but no big deal.
Sorry, I wasn't aware of
I thought you would have done ahg commit --user tbell so it belongs to
Tim?
I did a review too, but no big deal.
-kto
On Aug 3, 2012, at 4:21 PM, Daniel D. Daugherty wrote:
> Added you to the reviewer list. You're also the "user" for the
> changeset. The job is in the JPRT-hotspotwest qu
Added you to the reviewer list. You're also the "user" for the
changeset. The job is in the JPRT-hotspotwest queue heading to
RT_Baseline.
Dan
On 8/3/12 5:08 PM, Tim Bell wrote:
On 08/03/12 15:09, Daniel D. Daugherty wrote:
Gotta put 'tbell' in there some where...
Can I add you as a reviewer
On 08/03/12 15:09, Daniel D. Daugherty wrote:
Gotta put 'tbell' in there some where...
Can I add you as a reviewer?
Oh - that's right. Sure, add me as a reviewer.
Tim
Dan
On 8/3/12 3:58 PM, Tim Bell wrote:
Thanks, Dan
How about this for a commit message:
7181175: Enable builds on Win
Gotta put 'tbell' in there some where...
Can I add you as a reviewer?
Dan
On 8/3/12 3:58 PM, Tim Bell wrote:
Thanks, Dan
How about this for a commit message:
7181175: Enable builds on Windows with MinGW/MSYS
Summary: This fix is the minimum number of Makefile changes to enable
building Hot
Thanks, Dan
How about this for a commit message:
7181175: Enable builds on Windows with MinGW/MSYS
Summary: This fix is the minimum number of Makefile changes to enable
building HotSpot with MinGW/MSYS
Contributed-by: [email protected]
Reviewed-by: jcoomes, dcubed,
Tim
On 08/03/12 13:
Thumbs up on this version.
Do you have a commit message ready for this patch?
Dan
On 8/3/12 1:26 PM, Tim Bell wrote:
On 08/02/12 14:20, Daniel D. Daugherty wrote:
http://cr.openjdk.java.net/~tbell/7181175/webrev.01/
Thanks for the review, Dan.
make/windows/makefiles/defs.make
No com
On 08/02/12 14:20, Daniel D. Daugherty wrote:
http://cr.openjdk.java.net/~tbell/7181175/webrev.01/
Thanks for the review, Dan.
make/windows/makefiles/defs.make
No comments.
make/windows/makefiles/rules.make
lines 28-33: Might want to comment on why these paths still
use back
