Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-13 Thread David Holmes
Ni Naoto, Where will this be pushed to initially? It is a big set of changes, albeit localized (no pun intended :) ), so it would be good to see this get some bake time before propagating up. Further we're just about to have a "flag day" between hotspot and JDK due to JSR292 changes, so it wo

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-13 Thread Erik Joelsson
I finished making the changes yesterday, but didn't manage to get the patch completed before I had to run. (webrev and mercurial wouldn't cooperate). I will get it done asap today. /Erik On 2012-08-13 23:43, Naoto Sato wrote: Since I haven't heard any more comments from Erik/Kelly, I would lik

Re: /NO_BOOTDIR

2012-08-13 Thread Weijun Wang
It's ALT_BOOTDIR, not ALT_BOOT_DIR. On 08/14/2012 11:47 AM, vikram_sp wrote: I am building openjdk for on x86 machine running Fedora 14. I have these settings ALT_BOOT_DIR=/opt/java/jdk1.7.0 After some build this problem is comming: boot strap java is not installed in /NO_BOOTDIR Why this pro

/NO_BOOTDIR

2012-08-13 Thread vikram_sp
I am building openjdk for on x86 machine running Fedora 14. I have these settings ALT_BOOT_DIR=/opt/java/jdk1.7.0 After some build this problem is comming: boot strap java is not installed in /NO_BOOTDIR Why this problem is comming & what is the remedy? A call for help! - Vikram -- View t

hg: jdk8/build/jdk: 2 new changesets

2012-08-13 Thread michael . fang
Changeset: 93ddd9560751 Author:youdwei Date: 2012-08-13 10:45 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/93ddd9560751 7189611: Venezuela current Currency should be Bs.F. Reviewed-by: okutsu ! src/share/classes/sun/util/resources/CurrencyNames_es_VE.properties ! test/s

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-13 Thread Kumar Srinivasan
I have pointed out some changes below, but there is a serious problem. You are checking for the system arch using uname but the java architecture may not be the same. For example we run 32-bit jdk on a 64bit system, this will cause test failures since we will be using the wrong path names. Yo

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-13 Thread Naoto Sato
Since I haven't heard any more comments from Erik/Kelly, I would like to push the changeset without the new build infra patch. Erik/Kelly, can you please give us an official "GO" in terms of the build related changes? Aside from build changes, I have updated the changeset based on an internal

Re: webrev failure?

2012-08-13 Thread Mark Wielaard
On Sun, Aug 12, 2012 at 12:39:57PM +0100, Martijn Verburg wrote: > Aha! :-). Any ideas on how far I need to downgrade the version of hg? > (I'm 2.3 at the moment). I am at 2.2.3. The hgforest extension as maintained at http://icedtea.classpath.org/hg/hgforest (which is a merge of various hgforest

RFR : 7185965 Build error in javadoc make stage for bundles not containing crypto package

2012-08-13 Thread Seán Coffey
Similar to 7163470, the JDK has historically allowed builds without the javax.crypto package src. In such cases a jce.jar bootstrap should be used where necessary. One remaining use case is during javadoc building process. Simple fix and I've verified with a test build of docs. bug report :

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-13 Thread Omair Majid
On 08/13/2012 10:39 AM, Anthony Petrov wrote: > The test looks great, and I like that it doesn't depend on the JAWT > machinery, but tests the actual problematic RPATH entry only. I generally go for tests that verify behaviour (that jawt-linked programs are working) rather than implementation deta

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-13 Thread Anthony Petrov
The test looks great, and I like that it doesn't depend on the JAWT machinery, but tests the actual problematic RPATH entry only. +1 from me. -- best regards, Anthony On 08/13/12 18:22, Kumar Srinivasan wrote: Hi Anthony, Omair. Here is the patch for the test, this will live in test/tools/la

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-13 Thread Kumar Srinivasan
Hi Anthony, Omair. Here is the patch for the test, this will live in test/tools/launcher, also I don't have access to a MacOS system, appreciate if you can add this otherwise I will file a bug and add the macosx case later on. Thanks Kumar Hi Omair and Kumar, As to me, the fix and the tes

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-13 Thread Anthony Petrov
Hi Omair and Kumar, As to me, the fix and the test look good. A few suggestions: 1. Mac is also a supported platform now, so you need to add the "Darwin" option to the "SunOS | Windows_* )" case in the .sh file. 2. If gcc is not present, this should be considered that the test is passed. Sys

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-13 Thread Kumar Srinivasan
On 8/10/2012 1:56 PM, Omair Majid wrote: Hi Anthony, On 08/10/2012 08:29 AM, Anthony Petrov wrote: Actually, if Omair has a good automatic jtreg test, we would be happy to get it checked in with this fix. Could we see a webrev for the test please? I have uploaded a new webrev that includes a t